{"id":15328,"url":"https://patchwork.libcamera.org/api/patches/15328/?format=json","web_url":"https://patchwork.libcamera.org/patch/15328/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220204133814.303217-2-tomi.valkeinen@ideasonboard.com>","date":"2022-02-04T13:38:10","name":"[libcamera-devel,v4,1/5] HACK: libcamera: Camera public destructor","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5fbccee71d7e2215585b0b31f23ed099a418fec2","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15328/mbox/","series":[{"id":2916,"url":"https://patchwork.libcamera.org/api/series/2916/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2916","date":"2022-02-04T13:38:09","name":"Python bindings","version":4,"mbox":"https://patchwork.libcamera.org/series/2916/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15328/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15328/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFF81BDCBF\n\tfor ;\n\tFri, 4 Feb 2022 13:38:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED246609E1;\n\tFri, 4 Feb 2022 14:38:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7566609A9\n\tfor ;\n\tFri, 4 Feb 2022 14:38:42 +0100 (CET)","from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 331F9475;\n\tFri, 4 Feb 2022 14:38:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GmuEzxhc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1643981922;\n\tbh=ONUtTujr3cB+0P01cje8BCjDYxRpLDD+pm2TluEsvE8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GmuEzxhc/G4MpxOl4aCO6QCLYQnlonOqZcTu2YFPpcFI1e0ywqnREwuAS/Kq8L0xH\n\tr+TjdRgr/D53W3Kacrlf36e4MI9dHbTLaBILf+Ga9a6Mkg7jpMJFqAAIJpfAQFlHnp\n\t72VcJ2y94X+Xo4hRzwWDGUsmObwfyeMQLQHJen/I=","From":"Tomi Valkeinen ","To":"libcamera-devel@lists.libcamera.org,\n\tDavid Plowman ,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Date":"Fri, 4 Feb 2022 15:38:10 +0200","Message-Id":"<20220204133814.303217-2-tomi.valkeinen@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220204133814.303217-1-tomi.valkeinen@ideasonboard.com>","References":"<20220204133814.303217-1-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 1/5] HACK: libcamera: Camera public\n\tdestructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"pybind11 needs a public destructor for Camera to be able to manage the\nshared_ptr. It's not clear why this is needed, and can it be fixed in\npybind11.\n\nLooks like there's a suggested fix, which has not been merged:\n\nhttps://github.com/pybind/pybind11/pull/2067\n\nSigned-off-by: Tomi Valkeinen \n---\n include/libcamera/camera.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex 5bb06584..e753cd23 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -114,12 +114,12 @@ public:\n \tint start(const ControlList *controls = nullptr);\n \tint stop();\n \n+\t~Camera();\n private:\n \tLIBCAMERA_DISABLE_COPY(Camera)\n \n \tCamera(std::unique_ptr d, const std::string &id,\n \t const std::set &streams);\n-\t~Camera();\n \n \tfriend class PipelineHandler;\n \tvoid disconnect();\n","prefixes":["libcamera-devel","v4","1/5"]}