[{"id":22087,"web_url":"https://patchwork.libcamera.org/comment/22087/","msgid":"","date":"2022-02-01T09:38:49","subject":"Re: [libcamera-devel] [PATCH v1 1/2] pipeline: raspberrypi: Fix log\n\tmessage","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch.\n\nOn Tue, 1 Feb 2022 at 09:27, Naushir Patuck wrote:\n>\n> Fix a typo in a logging message.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nBest regards\nDavid\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 8c03eecefe42..6a46e6bc89fa 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -2070,7 +2070,7 @@ void RPiCameraData::tryRunPipeline()\n> ispPrepare.embeddedBufferPresent = true;\n>\n> LOG(RPI, Debug) << \"Signalling signalIspPrepare:\"\n> - << \" Bayer buffer id: \" << embeddedId;\n> + << \" Embedded buffer id: \" << embeddedId;\n> }\n>\n> ipa_->signalIspPrepare(ispPrepare);\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B615BDCBF\n\tfor ;\n\tTue, 1 Feb 2022 09:39:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 399FB609DF;\n\tTue, 1 Feb 2022 10:39:01 +0100 (CET)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 53A97609AF\n\tfor ;\n\tTue, 1 Feb 2022 10:39:00 +0100 (CET)","by mail-wm1-x331.google.com with SMTP id\n\tbg21-20020a05600c3c9500b0035283e7a012so1191087wmb.0\n\tfor ;\n\tTue, 01 Feb 2022 01:39:00 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QP0NvR7K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=NrltiZSwNrYwaEkYXxx9u25WHIbr4w6Fyd0nd9qaJj4=;\n\tb=QP0NvR7Knt8IAR74goeDEpE53k7tGdGdEXdPScAOcgkzgwHPQO3bpChJ8KQ4Pkz7jA\n\t0M+/sYMEA8voV+dVXlViawtcJtJoOGfEKnapDfVCMAqCEkMq71FaBTCXusHGr125UIwQ\n\th3l01bBriS9YB1MtWEe3onrzmLPIP9f3T1ZOCClDGRc5ClMCVJMrNxbMtEkvUfkYuG+e\n\tZ5i8EG+ad7Hhe7USm85csVBWuh4hnqQWA4wfcOi5hpLwbOi3CrQ3ptFGlcGCRW+JcEm3\n\tnoejx2gLHIBdvXtsGz3HAggo8BwZj0e72FAmiWeiUcmaTH9TDuhMU12VtJIEBAmUKYJv\n\tuznQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=NrltiZSwNrYwaEkYXxx9u25WHIbr4w6Fyd0nd9qaJj4=;\n\tb=AehwQEXr4O0Vv6CWH87FqO04mXmLi2DI6aVUqYLKdxTV4+IRZhXjavVY8rczrmmMgj\n\t/7NrvwxyrsbylRS+njdicyVMTTn40dvCpe8cYEW0vBJcpDBOAigPbMrcxJWqQhjMbu4h\n\tWh9qNTaWhNLjdeB/Z6reGf/eQidOOXaos/jPmKIhYIVb0JPPtRVYHDJDGeEDFRkPCUA3\n\tffmPye4uDIb7Xi/GLTK0Uyg5dEJZNtJQloKXZqY3LJQ8V5h8wPYw1I9LlK28sI7n2sVo\n\tR15ooUGxGtF2NDx02WEGR024/qu2225Popr7OTycOKYRQAZpEKV7inTp4RujRRed/ydI\n\tgxdg==","X-Gm-Message-State":"AOAM5323iw0u8nbVixVd48fPxIfClWpDAc/w1WtaUX2g3oFSnrFGJldC\n\tNAEQqaBPA++sXDG+8f/W2PGxjqdyDjV6wq11rrPKHeDkf3WTUg==","X-Google-Smtp-Source":"ABdhPJyQI7bmCEhzUsimwcPYnXbQ0oYeou1bGx4sGI8r7n5nJ3RYSb7YFTcqOS8/sNp8YuhUc3xpBp7cN33PsRYSj+w=","X-Received":"by 2002:a05:600c:4fc7:: with SMTP id\n\to7mr974826wmq.184.1643708339923; \n\tTue, 01 Feb 2022 01:38:59 -0800 (PST)","MIME-Version":"1.0","References":"<20220201092738.804028-1-naush@raspberrypi.com>","In-Reply-To":"<20220201092738.804028-1-naush@raspberrypi.com>","From":"David Plowman ","Date":"Tue, 1 Feb 2022 09:38:49 +0000","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1 1/2] pipeline: raspberrypi: Fix log\n\tmessage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22089,"web_url":"https://patchwork.libcamera.org/comment/22089/","msgid":"","date":"2022-02-01T10:06:24","subject":"Re: [libcamera-devel] [PATCH v1 1/2] pipeline: raspberrypi: Fix log\n\tmessage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Tue, Feb 01, 2022 at 09:27:37AM +0000, Naushir Patuck wrote:\n> Fix a typo in a logging message.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 8c03eecefe42..6a46e6bc89fa 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -2070,7 +2070,7 @@ void RPiCameraData::tryRunPipeline()\n> \t\tispPrepare.embeddedBufferPresent = true;\n> \n> \t\tLOG(RPI, Debug) << \"Signalling signalIspPrepare:\"\n> -\t\t\t\t<< \" Bayer buffer id: \" << embeddedId;\n> +\t\t\t\t<< \" Embedded buffer id: \" << embeddedId;\n> \t}\n> \n> \tipa_->signalIspPrepare(ispPrepare);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04D5EBDCBF\n\tfor ;\n\tTue, 1 Feb 2022 10:06:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48351609DF;\n\tTue, 1 Feb 2022 11:06:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D7BF609AF\n\tfor ;\n\tTue, 1 Feb 2022 11:06:49 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 911AF332;\n\tTue, 1 Feb 2022 11:06:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cKYucK1F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1643710009;\n\tbh=fhMmPDobcMhlEqkii/UMJp8JpkM0EbqHd5w0FeTQZk0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cKYucK1FidmMSgV1pEBIEs0V9b1HBgnD3MaUJgWV2UF1NP2z26DM2Lxe5R5pUvdzE\n\trEf4dTza9T14BlRVHFdVjmuZpsFjw7wPzNeDJRb3IezfnZxMliD5NzXnKuhQjANsmN\n\tIJNyBS4uRO2r1o8zg8bMXBEeeIPef4SpDsEfjEv0=","Date":"Tue, 1 Feb 2022 12:06:24 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20220201092738.804028-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220201092738.804028-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/2] pipeline: raspberrypi: Fix log\n\tmessage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]