{"id":15311,"url":"https://patchwork.libcamera.org/api/patches/15311/?format=json","web_url":"https://patchwork.libcamera.org/patch/15311/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220131223330.61563-7-djrscally@gmail.com>","date":"2022-01-31T22:33:27","name":"[libcamera-devel,v4,6/9] libcamera: ipa: Add lens control member to ipu3 ipa interface","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9587ac2496d8a1e758e9122900e4c0e86fd78703","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15311/mbox/","series":[{"id":2906,"url":"https://patchwork.libcamera.org/api/series/2906/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2906","date":"2022-01-31T22:33:21","name":"Enumerate CameraLens by following sensor's ancillary links","version":4,"mbox":"https://patchwork.libcamera.org/series/2906/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15311/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15311/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06C58C325A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 31 Jan 2022 22:33:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEC48609C7;\n\tMon, 31 Jan 2022 23:33:49 +0100 (CET)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C743609EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Jan 2022 23:33:47 +0100 (CET)","by mail-wr1-x433.google.com with SMTP id e8so28326548wrc.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Jan 2022 14:33:47 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tq2sm6986740wrw.14.2022.01.31.14.33.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 31 Jan 2022 14:33:46 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"AUx+Q5nX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=CN2Z8QoM3E2akRLSrUKptfBqOnf/BP1kVA/6OXokjQk=;\n\tb=AUx+Q5nXySVdD//PUByhv5+KXPIYkGbfnhmf0gaXEp4gRkwO7ZVjDWzfPi2Um9baxh\n\tE5INLdblY4b1GhxfSLts+zdYf1Tmi2edaQxANE4jX1MNKBSI55umd1i12X8QfunSnQRQ\n\tAaI2+OjUwoxWq//jCi3YDNZBXyJlWfKIHBlQoGPteHf2qNzccQIX8JqyETHLPbyr8Wwx\n\tDcUyru0WUrqAfTWx/C5Xqwfp5+wZ4943jh6kZ58so5waFQrPU1eQVQCif68tel7PY/yk\n\tai6gBKevlYw6EotBNEJirIXNxVFpAhlnMqQuYgFviR5kJnFXPvBvjv0tiVC5ZWb800of\n\tSHsA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=CN2Z8QoM3E2akRLSrUKptfBqOnf/BP1kVA/6OXokjQk=;\n\tb=wc38vD2wnmlZTAoTx+MVI7PtDpeLCbdlktsjQx1U4puROUn6bQeSZI789Konh4tUtv\n\tctpfUuAtlO+mm6Yza1k+5xDCdhyM4kz8nvU9ApkeDugOZNPiqnhYJB1KWfau2I6+H4AU\n\te7oIuhIJcMWxG6YWPKxxwsgQOSSi+Ad6CUHv7wnSSvqhdAhdcCZuQk4flBWRX4ZJax65\n\tRbhsfnJUHpBgiYrdoXsFTRcCyhDTN4EOUVYuq9lodjIw3br9JRlylCvxGDrmo8yHsIJ0\n\t2UxfTbeQCZS0MnK6Xo3c8BLdVFidPF4wsWUTrUaJGHCkoTMUZXrk7MlcbJnKedTFq3kK\n\tvX0Q==","X-Gm-Message-State":"AOAM532bWVTH7kDFq3bSCJ0hpeLnT4bIbBl//iWaM8WfxZXfR4K1QKGf\n\toXYWZHx1Mh6s8CZbbb5QQVw2FOg30Ag=","X-Google-Smtp-Source":"ABdhPJxI4vS48z3J226RzuF927nG6HB7WDSpMRu3/iNE+9xVKPT+5G7DWBohfXT9qYokvp8Ze9N8YA==","X-Received":"by 2002:adf:ee8b:: with SMTP id\n\tb11mr19482283wro.430.1643668427171; \n\tMon, 31 Jan 2022 14:33:47 -0800 (PST)","From":"Daniel Scally <djrscally@gmail.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 31 Jan 2022 22:33:27 +0000","Message-Id":"<20220131223330.61563-7-djrscally@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220131223330.61563-1-djrscally@gmail.com>","References":"<20220131223330.61563-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 6/9] libcamera: ipa: Add lens control\n\tmember to ipu3 ipa interface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add further members to the ipu3 ipa interface that will hold lens\ncontrols passed in by configInfo\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\nChanges since v4:\n\n\t- None\n\nChanges in v3:\n\n\t- None\n\n include/libcamera/ipa/ipu3.mojom | 1 +\n src/ipa/ipu3/ipu3.cpp            | 3 +++\n 2 files changed, 4 insertions(+)","diff":"diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex cc0d822f..18cdc744 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -37,6 +37,7 @@ struct IPU3Action {\n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\n+\tlibcamera.ControlInfoMap lensControls;\n \tlibcamera.Size bdsOutputSize;\n \tlibcamera.Size iif;\n };\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b5149bcd..008f93a7 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -163,6 +163,7 @@ private:\n \tstd::map<unsigned int, MappedFrameBuffer> buffers_;\n \n \tControlInfoMap ctrls_;\n+\tControlInfoMap lensCtrls_;\n \n \tIPACameraSensorInfo sensorInfo_;\n \n@@ -450,6 +451,8 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \n \tsensorInfo_ = configInfo.sensorInfo;\n \n+\tlensCtrls_ = configInfo.lensControls;\n+\n \t/*\n \t * Compute the sensor V4L2 controls to be used by the algorithms and\n \t * to be set on the sensor.\n","prefixes":["libcamera-devel","v4","6/9"]}