[{"id":22075,"web_url":"https://patchwork.libcamera.org/comment/22075/","msgid":"<202201312326.TkliJ318-lkp@intel.com>","date":"2022-01-31T16:00:58","subject":"Re: [libcamera-devel] [PATCH v2 5/6] media: entity: Add support for\n\tancillary links","submitter":{"id":45,"url":"https://patchwork.libcamera.org/api/people/45/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Daniel,\n\nI love your patch! Perhaps something to improve:\n\n[auto build test WARNING on media-tree/master]\n[also build test WARNING on v5.17-rc2 next-20220131]\n[If your patch is applied to the wrong git tree, kindly drop us a note.\nAnd when submitting patch, we suggest to use '--base' as documented in\nhttps://git-scm.com/docs/git-format-patch]\n\nurl: https://github.com/0day-ci/linux/commits/Daniel-Scally/Introduce-ancillary-links/20220131-080041\nbase: git://linuxtv.org/media_tree.git master\nreproduce: make htmldocs\n\nIf you fix the issue, kindly add following tag as appropriate\nReported-by: kernel test robot \n\nAll warnings (new ones prefixed by >>):\n\n>> include/media/media-entity.h:1126: warning: expecting prototype for media_entity_call(). Prototype was for media_create_ancillary_link() instead\n\nvim +1126 include/media/media-entity.h\n\n 1094\t\n 1095\t/**\n 1096\t * media_entity_call - Calls a struct media_entity_operations operation on\n 1097\t *\tan entity\n 1098\t *\n 1099\t * @entity: entity where the @operation will be called\n 1100\t * @operation: type of the operation. Should be the name of a member of\n 1101\t *\tstruct &media_entity_operations.\n 1102\t *\n 1103\t * This helper function will check if @operation is not %NULL. On such case,\n 1104\t * it will issue a call to @operation\\(@entity, @args\\).\n 1105\t */\n 1106\t\n 1107\t/**\n 1108\t * media_create_ancillary_link() - create an ancillary link between two\n 1109\t *\t\t\t\t instances of &media_entity\n 1110\t *\n 1111\t * @primary:\tpointer to the primary &media_entity\n 1112\t * @ancillary:\tpointer to the ancillary &media_entity\n 1113\t *\n 1114\t * Create an ancillary link between two entities, indicating that they\n 1115\t * represent two connected pieces of hardware that form a single logical unit.\n 1116\t * A typical example is a camera lens being linked to the sensor that it is\n 1117\t * supporting.\n 1118\t *\n 1119\t * The function sets both MEDIA_LNK_FL_ENABLED and MEDIA_LNK_FL_IMMUTABLE for\n 1120\t * the new link. This behaviour may be subject to change in the future, so\n 1121\t * userspace applications using ancillary links should ensure that ancillary\n 1122\t * links are enabled when in use.\n 1123\t */\n 1124\tstruct media_link *\n 1125\tmedia_create_ancillary_link(struct media_entity *primary,\n> 1126\t\t\t\t struct media_entity *ancillary);\n 1127\t\n\n---\n0-DAY CI Kernel Test Service, Intel Corporation\nhttps://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 790FABDCBF\n\tfor ;\n\tMon, 31 Jan 2022 16:01:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B726E609C6;\n\tMon, 31 Jan 2022 17:01:48 +0100 (CET)","from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A434C609AC\n\tfor ;\n\tMon, 31 Jan 2022 17:01:45 +0100 (CET)","from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t31 Jan 2022 08:01:41 -0800","from lkp-server01.sh.intel.com (HELO 276f1b88eecb)\n\t([10.239.97.150])\n\tby orsmga001.jf.intel.com with ESMTP; 31 Jan 2022 08:01:37 -0800","from kbuild by 276f1b88eecb with local (Exim 4.92)\n\t(envelope-from )\n\tid 1nEZ7Z-000S7H-B4; Mon, 31 Jan 2022 16:01:37 +0000"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"PlaSUamx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1643644905; x=1675180905;\n\th=date:from:to:cc:subject:message-id:references:\n\tmime-version:in-reply-to;\n\tbh=TicKd4P+h5PhqRQkwsLkviKMfF72vF63G9NpY9Gv5HY=;\n\tb=PlaSUamxkzrq66x+kUDOebWqfDY4Vnly03d5yx2qesFoOideMpiha0UW\n\tUmPD7SGVsi0CenlgwiyziVyIRQqAE4ksSRizmu9WD4BG/mM4GjssAurlY\n\twlO62sTThAnoda9ZUPYN6JDAWW8xTxMR4BFTaxmzpWt6LytcOi+T4rx5M\n\trff+DXNBOqFGlwY40N2f6InRkMD3KGA1qFEVvsBM5ffLJbPIZYpX3zTsf\n\tIyfksVg9FQu2G3GqccXCLLggBJHEjtEDAaK2yHvgrjswixCybIDXIhXfw\n\tMzg8dOhG/cGohyoNAHqfSdAenNTE9Kl5HZY79pc0znZYNJX8PS4qhL4e3 Q==;","X-IronPort-AV":["E=McAfee;i=\"6200,9189,10244\"; a=\"231058789\"","E=Sophos;i=\"5.88,331,1635231600\"; d=\"scan'208\";a=\"231058789\"","E=Sophos;i=\"5.88,331,1635231600\"; d=\"scan'208\";a=\"565164185\""],"X-ExtLoop1":"1","Date":"Tue, 1 Feb 2022 00:00:58 +0800","From":"kernel test robot ","To":"Daniel Scally , linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<202201312326.TkliJ318-lkp@intel.com>","References":"<20220130235821.48076-6-djrscally@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220130235821.48076-6-djrscally@gmail.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] media: entity: Add support for\n\tancillary links","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kbuild-all@lists.01.org, sakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22111,"web_url":"https://patchwork.libcamera.org/comment/22111/","msgid":"","date":"2022-02-02T23:32:26","subject":"Re: [libcamera-devel] [PATCH v2 5/6] media: entity: Add support for\n\tancillary links","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Sun, Jan 30, 2022 at 11:58:20PM +0000, Daniel Scally wrote:\n> Add functions to create ancillary links, so that they don't need to\n> be manually created by users.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> \n> Changes since v1:\n> \n> \t- Hardcoded MEDIA_LINK_FL_IMMUTABLE and MEDIA_LINK_FL_ENABLED (Laurent)\n> \n> Changes since the rfc:\n> \n> \t- (Laurent) Set gobj0 and gobj1 directly instead of the other union\n> \tmembers\n> \t- (Laurent) Added MEDIA_LNK_FL_IMMUTABLE to the kerneldoc for the new\n> \tcreate function\n> \n> drivers/media/mc/mc-entity.c | 22 ++++++++++++++++++++++\n> include/media/media-entity.h | 21 +++++++++++++++++++++\n> 2 files changed, 43 insertions(+)\n> \n> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\n> index 29d1285c805a..7bf2c73a3886 100644\n> --- a/drivers/media/mc/mc-entity.c\n> +++ b/drivers/media/mc/mc-entity.c\n> @@ -1050,3 +1050,25 @@ void media_remove_intf_links(struct media_interface *intf)\n> \tmutex_unlock(&mdev->graph_mutex);\n> }\n> EXPORT_SYMBOL_GPL(media_remove_intf_links);\n> +\n> +struct media_link *media_create_ancillary_link(struct media_entity *primary,\n> +\t\t\t\t\t struct media_entity *ancillary)\n> +{\n> +\tstruct media_link *link;\n> +\n> +\tlink = media_add_link(&primary->links);\n> +\tif (!link)\n> +\t\treturn ERR_PTR(-ENOMEM);\n> +\n> +\tlink->gobj0 = &primary->graph_obj;\n> +\tlink->gobj1 = &ancillary->graph_obj;\n> +\tlink->flags = MEDIA_LNK_FL_IMMUTABLE | MEDIA_LNK_FL_ENABLED |\n> +\t\t MEDIA_LNK_FL_ANCILLARY_LINK;\n> +\n> +\t/* Initialize graph object embedded in the new link */\n> +\tmedia_gobj_create(primary->graph_obj.mdev, MEDIA_GRAPH_LINK,\n> +\t\t\t &link->graph_obj);\n> +\n> +\treturn link;\n> +}\n> +EXPORT_SYMBOL_GPL(media_create_ancillary_link);\n> diff --git a/include/media/media-entity.h b/include/media/media-entity.h\n> index fea489f03d57..afeda41ece4c 100644\n> --- a/include/media/media-entity.h\n> +++ b/include/media/media-entity.h\n> @@ -1104,6 +1104,27 @@ void media_remove_intf_links(struct media_interface *intf);\n> * it will issue a call to @operation\\(@entity, @args\\).\n> */\n> \n> +/**\n> + * media_create_ancillary_link() - create an ancillary link between two\n> + *\t\t\t\t instances of &media_entity\n> + *\n> + * @primary:\tpointer to the primary &media_entity\n> + * @ancillary:\tpointer to the ancillary &media_entity\n> + *\n> + * Create an ancillary link between two entities, indicating that they\n> + * represent two connected pieces of hardware that form a single logical unit.\n\nHere you say logical unit, while in patch 3/6 you use the term \"physical\nrelationship\". I think I'd go for \"logical\" there too.\n\n> + * A typical example is a camera lens being linked to the sensor that it is\n\ns/lens/lens controller/\n\n> + * supporting.\n> + *\n> + * The function sets both MEDIA_LNK_FL_ENABLED and MEDIA_LNK_FL_IMMUTABLE for\n> + * the new link. This behaviour may be subject to change in the future, so\n> + * userspace applications using ancillary links should ensure that ancillary\n> + * links are enabled when in use.\n\nI'd drop the last two lines as this is kernel documentation, not\nuserspace documentation.\n\n> + */\n> +struct media_link *\n> +media_create_ancillary_link(struct media_entity *primary,\n> +\t\t\t struct media_entity *ancillary);\n\nAs reported by the kernel buildbot, this should go after\nmedia_entity_call().\n\n> +\n> #define media_entity_call(entity, operation, args...)\t\t\t\\\n> \t(((entity)->ops && (entity)->ops->operation) ?\t\t\t\\\n> \t (entity)->ops->operation((entity) , ##args) : -ENOIOCTLCMD)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64BE0BDCBF\n\tfor ;\n\tWed, 2 Feb 2022 23:32:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEA67609E1;\n\tThu, 3 Feb 2022 00:32:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32FC5609B5\n\tfor ;\n\tThu, 3 Feb 2022 00:32:50 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 85C5149C;\n\tThu, 3 Feb 2022 00:32:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fZlZukLF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1643844769;\n\tbh=7PG1YGDT03OmPOVcvAQShxeI9MUP3kjSm7LNFCNsKWo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fZlZukLFO9deBDMrIViA9xYBHCfn2j3PANsZo6fHgWwFrL/ElNqRHUYg4Op6nc74u\n\tnO0lchT5FxNyUR7XgTtyDFChvb93Fk4FnsSPHARSB+9qzdhjk5Gywk10PkuojY/96L\n\tVDmuTDgFJKgPZA6JC9o917wjdBpVIoPI5kv7da4c=","Date":"Thu, 3 Feb 2022 01:32:26 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20220130235821.48076-1-djrscally@gmail.com>\n\t<20220130235821.48076-6-djrscally@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220130235821.48076-6-djrscally@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] media: entity: Add support for\n\tancillary links","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, sakari.ailus@linux.intel.com,\n\tlinux-media@vger.kernel.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22112,"web_url":"https://patchwork.libcamera.org/comment/22112/","msgid":"","date":"2022-02-02T23:32:51","subject":"Re: [libcamera-devel] [PATCH v2 5/6] media: entity: Add support for\n\tancillary links","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Feb 03, 2022 at 01:32:28AM +0200, Laurent Pinchart wrote:\n> Hi Dan,\n> \n> Thank you for the patch.\n> \n> On Sun, Jan 30, 2022 at 11:58:20PM +0000, Daniel Scally wrote:\n> > Add functions to create ancillary links, so that they don't need to\n> > be manually created by users.\n> > \n> > Signed-off-by: Daniel Scally \n> > ---\n> > \n> > Changes since v1:\n> > \n> > \t- Hardcoded MEDIA_LINK_FL_IMMUTABLE and MEDIA_LINK_FL_ENABLED (Laurent)\n> > \n> > Changes since the rfc:\n> > \n> > \t- (Laurent) Set gobj0 and gobj1 directly instead of the other union\n> > \tmembers\n> > \t- (Laurent) Added MEDIA_LNK_FL_IMMUTABLE to the kerneldoc for the new\n> > \tcreate function\n> > \n> > drivers/media/mc/mc-entity.c | 22 ++++++++++++++++++++++\n> > include/media/media-entity.h | 21 +++++++++++++++++++++\n> > 2 files changed, 43 insertions(+)\n> > \n> > diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\n> > index 29d1285c805a..7bf2c73a3886 100644\n> > --- a/drivers/media/mc/mc-entity.c\n> > +++ b/drivers/media/mc/mc-entity.c\n> > @@ -1050,3 +1050,25 @@ void media_remove_intf_links(struct media_interface *intf)\n> > \tmutex_unlock(&mdev->graph_mutex);\n> > }\n> > EXPORT_SYMBOL_GPL(media_remove_intf_links);\n> > +\n> > +struct media_link *media_create_ancillary_link(struct media_entity *primary,\n> > +\t\t\t\t\t struct media_entity *ancillary)\n> > +{\n> > +\tstruct media_link *link;\n> > +\n> > +\tlink = media_add_link(&primary->links);\n> > +\tif (!link)\n> > +\t\treturn ERR_PTR(-ENOMEM);\n> > +\n> > +\tlink->gobj0 = &primary->graph_obj;\n> > +\tlink->gobj1 = &ancillary->graph_obj;\n> > +\tlink->flags = MEDIA_LNK_FL_IMMUTABLE | MEDIA_LNK_FL_ENABLED |\n> > +\t\t MEDIA_LNK_FL_ANCILLARY_LINK;\n> > +\n> > +\t/* Initialize graph object embedded in the new link */\n> > +\tmedia_gobj_create(primary->graph_obj.mdev, MEDIA_GRAPH_LINK,\n> > +\t\t\t &link->graph_obj);\n> > +\n> > +\treturn link;\n> > +}\n> > +EXPORT_SYMBOL_GPL(media_create_ancillary_link);\n> > diff --git a/include/media/media-entity.h b/include/media/media-entity.h\n> > index fea489f03d57..afeda41ece4c 100644\n> > --- a/include/media/media-entity.h\n> > +++ b/include/media/media-entity.h\n> > @@ -1104,6 +1104,27 @@ void media_remove_intf_links(struct media_interface *intf);\n> > * it will issue a call to @operation\\(@entity, @args\\).\n> > */\n> > \n> > +/**\n> > + * media_create_ancillary_link() - create an ancillary link between two\n> > + *\t\t\t\t instances of &media_entity\n> > + *\n> > + * @primary:\tpointer to the primary &media_entity\n> > + * @ancillary:\tpointer to the ancillary &media_entity\n> > + *\n> > + * Create an ancillary link between two entities, indicating that they\n> > + * represent two connected pieces of hardware that form a single logical unit.\n> \n> Here you say logical unit, while in patch 3/6 you use the term \"physical\n> relationship\". I think I'd go for \"logical\" there too.\n> \n> > + * A typical example is a camera lens being linked to the sensor that it is\n> \n> s/lens/lens controller/\n> \n> > + * supporting.\n> > + *\n> > + * The function sets both MEDIA_LNK_FL_ENABLED and MEDIA_LNK_FL_IMMUTABLE for\n> > + * the new link. This behaviour may be subject to change in the future, so\n> > + * userspace applications using ancillary links should ensure that ancillary\n> > + * links are enabled when in use.\n> \n> I'd drop the last two lines as this is kernel documentation, not\n> userspace documentation.\n> \n> > + */\n> > +struct media_link *\n> > +media_create_ancillary_link(struct media_entity *primary,\n> > +\t\t\t struct media_entity *ancillary);\n> \n> As reported by the kernel buildbot, this should go after\n> media_entity_call().\n\nAnd I forgot to add\n\nReviewed-by: Laurent Pinchart \n\n> > +\n> > #define media_entity_call(entity, operation, args...)\t\t\t\\\n> > \t(((entity)->ops && (entity)->ops->operation) ?\t\t\t\\\n> > \t (entity)->ops->operation((entity) , ##args) : -ENOIOCTLCMD)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C69FBDCBF\n\tfor ;\n\tWed, 2 Feb 2022 23:33:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40888609E1;\n\tThu, 3 Feb 2022 00:33:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7467B609B5\n\tfor ;\n\tThu, 3 Feb 2022 00:33:14 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BF7549C;\n\tThu, 3 Feb 2022 00:33:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bUdWSm2j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1643844794;\n\tbh=wRrsC2iMGlyF/1+fE7WyaC3wqDd8+P5KmW+/tFUCdG8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bUdWSm2jH4/NarUzTTauL4SlSy7Z4FBf1CsaV6iy+U45O8ot/mjhI8scgw7TFjdwC\n\tW1TpkdEsA4WYoDQNvQr9EQk0ZV89F4DGlfU06KE7cVVEzVSmiHXetQDL1zh5uMnpzU\n\tWa+4IN6xl6fyURVPakZpROvibU9DISBEqf16/XLA=","Date":"Thu, 3 Feb 2022 01:32:51 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20220130235821.48076-1-djrscally@gmail.com>\n\t<20220130235821.48076-6-djrscally@gmail.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] media: entity: Add support for\n\tancillary links","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, sakari.ailus@linux.intel.com,\n\tlinux-media@vger.kernel.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]