{"id":15301,"url":"https://patchwork.libcamera.org/api/patches/15301/?format=json","web_url":"https://patchwork.libcamera.org/patch/15301/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220130235821.48076-5-djrscally@gmail.com>","date":"2022-01-30T23:58:19","name":"[libcamera-devel,v2,4/6] media: entity: Add link_type_name() helper","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"0dbb692040381c718cbb0b38c1e53cbf7d955523","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15301/mbox/","series":[{"id":2904,"url":"https://patchwork.libcamera.org/api/series/2904/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2904","date":"2022-01-30T23:58:15","name":"Introduce ancillary links","version":2,"mbox":"https://patchwork.libcamera.org/series/2904/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15301/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15301/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 247D0BDCBF\n\tfor ;\n\tSun, 30 Jan 2022 23:59:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2AB4609F2;\n\tMon, 31 Jan 2022 00:59:14 +0100 (CET)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF81D609DD\n\tfor ;\n\tMon, 31 Jan 2022 00:59:09 +0100 (CET)","by mail-wr1-x42a.google.com with SMTP id s9so22036845wrb.6\n\tfor ;\n\tSun, 30 Jan 2022 15:59:09 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\t11sm11993663wrb.30.2022.01.30.15.59.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 30 Jan 2022 15:59:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mi2/QUg5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=OPpoJnU/qyg2/VoeGoW1Rn4aPz6S0A9ibACKGoGZN18=;\n\tb=mi2/QUg5gWiGvQqVrMJ9tD3a+99R4h/pf625IaJ5ekxUwfe734jVrYfEvS85V7l82X\n\tKi2ZNyC4CmrYAdOhONydYzPPH/nkEbr7yvZfJrBqWfi9EgYKJ2GcPq9S95q4z2TpH8lD\n\t+qvFsW2c5zoy52JHyL3IWnmxVzoKFUWDcsL668OxOy5CtbiRNRhgpuHJs4mF0T1BY9y5\n\txHnb9JAmFP8TSUD9I5LHLfjlsHDhczP1rVnFdq7iqoLZsFcvRnNVAn4+LK82R12OIKjD\n\t7snvR3fzYVdRcjPD2t4m+eNDVf99bHr/EIL0nv77fY903gPOumGeARe1NQp1ZaT0cZ++\n\tn36g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=OPpoJnU/qyg2/VoeGoW1Rn4aPz6S0A9ibACKGoGZN18=;\n\tb=4sd895W/g4MThcByKKWkQrJXyP3Fc30XitGWnaBE2XnDffmBj1n6XPrePZefKVzRJ1\n\tD+/7MNVM2MtAeRYgYae1kLEzxK7TG+jjy+Sbl0aaCs6zjv0iAg1hYP05xUvMCTfEVgOC\n\tD0cSR3lIDA5/41baUXTUJuRILK7txelydSazUF42RRf35excrz9Ygsc8N2EjbY8fM9Nc\n\tX0RqTjPGVvOY8mNcr6wH4/iUs1XmYxflskapjT/VZKX+l7NfCcsdJBlemXT8rWBCjD/Z\n\tZiaH4lvlnzqTqDY68C9P2wrzYzaCwkjfYBmcXVjcmQRA45WnwpoLwxzZgUz/+KWTA4Io\n\tcRRg==","X-Gm-Message-State":"AOAM532qp2b8FrIipnpUHlPkdUEsXVkY/bU/5wzukC/XbfO0vmQmcirZ\n\tlEHEkJR5qA6uRTgl2qMfvFo=","X-Google-Smtp-Source":"ABdhPJw/ZKDFFuQpy2pfkYk48xdzvk7TXgvZRkEm9DSG5fVyY1ZAxYR7N9RhYmUdcddXvCxA23DvNg==","X-Received":"by 2002:a5d:47cf:: with SMTP id\n\to15mr15151828wrc.577.1643587149642; \n\tSun, 30 Jan 2022 15:59:09 -0800 (PST)","From":"Daniel Scally ","To":"linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 30 Jan 2022 23:58:19 +0000","Message-Id":"<20220130235821.48076-5-djrscally@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220130235821.48076-1-djrscally@gmail.com>","References":"<20220130235821.48076-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 4/6] media: entity: Add\n\tlink_type_name() helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now we have three types of media link, printing the right name during\ndebug output is slightly more complicated. Add a helper function to\nmake it easier.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Daniel Scally \n---\nChanges since v1:\n\n\t- renamed function to link_type_name() (Laurent)\n\nChanges since the rfc:\n\n\t- new patch\n\n drivers/media/mc/mc-entity.c | 18 +++++++++++++++---\n 1 file changed, 15 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\nindex 2a6e16fb0048..29d1285c805a 100644\n--- a/drivers/media/mc/mc-entity.c\n+++ b/drivers/media/mc/mc-entity.c\n@@ -60,6 +60,20 @@ static inline const char *intf_type(struct media_interface *intf)\n \t}\n };\n \n+static inline const char *link_type_name(struct media_link *link)\n+{\n+\tswitch (link->flags & MEDIA_LNK_FL_LINK_TYPE) {\n+\tcase MEDIA_LNK_FL_DATA_LINK:\n+\t\treturn \"data\";\n+\tcase MEDIA_LNK_FL_INTERFACE_LINK:\n+\t\treturn \"interface\";\n+\tcase MEDIA_LNK_FL_ANCILLARY_LINK:\n+\t\treturn \"ancillary\";\n+\tdefault:\n+\t\treturn \"unknown\";\n+\t}\n+}\n+\n __must_check int __media_entity_enum_init(struct media_entity_enum *ent_enum,\n \t\t\t\t\t int idx_max)\n {\n@@ -107,9 +121,7 @@ static void dev_dbg_obj(const char *event_name, struct media_gobj *gobj)\n \n \t\tdev_dbg(gobj->mdev->dev,\n \t\t\t\"%s id %u: %s link id %u ==> id %u\\n\",\n-\t\t\tevent_name, media_id(gobj),\n-\t\t\tmedia_type(link->gobj0) == MEDIA_GRAPH_PAD ?\n-\t\t\t\t\"data\" : \"interface\",\n+\t\t\tevent_name, media_id(gobj), link_type_name(link),\n \t\t\tmedia_id(link->gobj0),\n \t\t\tmedia_id(link->gobj1));\n \t\tbreak;\n","prefixes":["libcamera-devel","v2","4/6"]}