[{"id":22109,"web_url":"https://patchwork.libcamera.org/comment/22109/","msgid":"","date":"2022-02-02T23:15:24","subject":"Re: [libcamera-devel] [PATCH v2 2/6] media: media.h: Add new media\n\tlink type","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Sun, Jan 30, 2022 at 11:58:17PM +0000, Daniel Scally wrote:\n> To describe in the kernel the connection between devices and their\n> supporting peripherals (for example, a camera sensor and the vcm\n> driving the focusing lens for it), add a new type of media link\n> to introduce the concept of these ancillary links.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> Changes since v1:\n> \n> \t- None\n> \n> changes since the rfc:\n> \n> \t- Split out into its own patch (mostly so it can be followed by patch\n> \t#3, which corrects some media-core code that is otherwise broken by the\n> \tnew links)\n> \n> include/uapi/linux/media.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h\n> index 200fa8462b90..afbae7213d35 100644\n> --- a/include/uapi/linux/media.h\n> +++ b/include/uapi/linux/media.h\n> @@ -226,6 +226,7 @@ struct media_pad_desc {\n> #define MEDIA_LNK_FL_LINK_TYPE\t\t\t(0xf << 28)\n> # define MEDIA_LNK_FL_DATA_LINK\t\t(0 << 28)\n> # define MEDIA_LNK_FL_INTERFACE_LINK\t\t(1 << 28)\n> +# define MEDIA_LNK_FL_ANCILLARY_LINK\t\t(2 << 28)\n\nI'd squash this with 3/6. Apart from that,\n\nReviewed-by: Laurent Pinchart \n\n> \n> struct media_link_desc {\n> \tstruct media_pad_desc source;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31E42BDCBF\n\tfor ;\n\tWed, 2 Feb 2022 23:15:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFD92609C3;\n\tThu, 3 Feb 2022 00:15:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADCF9609B5\n\tfor ;\n\tThu, 3 Feb 2022 00:15:47 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B75B49C;\n\tThu, 3 Feb 2022 00:15:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QdHFKNpo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1643843747;\n\tbh=AYRpR73QY2e/AQLiWfzpyBaCApS8oGaOCfqjTTtth7s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QdHFKNpo7bi6tbPStbB6ZE7ODXa5c8YMsJZepyyG+BymGjSPL/bk8E5y38Pdl1qby\n\tYQ0J7Frc+ieTL+RxTLQfQbLZZQLoiaUiPqJLl1A/MbCNqydXt7dAFQkEQ+MK4u+a7r\n\tfTzPCFlQcQBmkIDax4/qpg4pX7DtQJNZUG2bY5Qo=","Date":"Thu, 3 Feb 2022 01:15:24 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20220130235821.48076-1-djrscally@gmail.com>\n\t<20220130235821.48076-3-djrscally@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220130235821.48076-3-djrscally@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] media: media.h: Add new media\n\tlink type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, sakari.ailus@linux.intel.com,\n\tlinux-media@vger.kernel.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]