[{"id":22048,"web_url":"https://patchwork.libcamera.org/comment/22048/","msgid":"","date":"2022-01-19T00:41:51","subject":"Re: [libcamera-devel] [PATCH] test: Ensure CameraTest tests are not\n\trun in parallel","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Jan 19, 2022 at 12:09:59AM +0000, Kieran Bingham wrote:\n> The fence and mapped-buffer tests both use the VIMC test device and must\n> not be run at the same time.\n> \n> Split these tests to a new group to force their isolation from running\n> in parallel.\n> \n> Signed-off-by: Kieran Bingham \n\nI've seen occasional failures in the mapped-buffer test, thanks for\nbeating me to fixing it.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/meson.build | 16 ++++++++++++++--\n> 1 file changed, 14 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/meson.build b/test/meson.build\n> index 2c9487e203e2..fd4c5ca07c15 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -39,11 +39,9 @@ internal_tests = [\n> ['event', 'event.cpp'],\n> ['event-dispatcher', 'event-dispatcher.cpp'],\n> ['event-thread', 'event-thread.cpp'],\n> - ['fence', 'fence.cpp'],\n> ['file', 'file.cpp'],\n> ['flags', 'flags.cpp'],\n> ['hotplug-cameras', 'hotplug-cameras.cpp'],\n> - ['mapped-buffer', 'mapped-buffer.cpp'],\n> ['message', 'message.cpp'],\n> ['object', 'object.cpp'],\n> ['object-delete', 'object-delete.cpp'],\n> @@ -58,6 +56,11 @@ internal_tests = [\n> ['utils', 'utils.cpp'],\n> ]\n> \n> +internal_non_parallel_tests = [\n> + ['fence', 'fence.cpp'],\n> + ['mapped-buffer', 'mapped-buffer.cpp'],\n> +]\n> +\n> foreach t : public_tests\n> exe = executable(t[0], t[1],\n> dependencies : libcamera_public,\n> @@ -75,3 +78,12 @@ foreach t : internal_tests\n> \n> test(t[0], exe)\n> endforeach\n> +\n> +foreach t : internal_non_parallel_tests\n> + exe = executable(t[0], t[1],\n> + dependencies : libcamera_private,\n> + link_with : test_libraries,\n> + include_directories : test_includes_internal)\n> +\n> + test(t[0], exe, is_parallel : false)\n> +endforeach","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD081BE086\n\tfor ;\n\tWed, 19 Jan 2022 00:42:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7CD460944;\n\tWed, 19 Jan 2022 01:42:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B43086017D\n\tfor ;\n\tWed, 19 Jan 2022 01:42:05 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2835E464;\n\tWed, 19 Jan 2022 01:42:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bULv/bOg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1642552925;\n\tbh=A8mCk8VAgLAxgrQiQllikCkPGCl+AEgdfX4sD96tp70=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bULv/bOgyvQahnQlX13X2dkXr+/b0ihxZGSHv53lPhtRVZjo6ZRyswVPzEgvOHLSP\n\tccDQd7dvG9UOGMG2DNf2563uPu97hp+hu0XNfPSVxDyXYZLPXzZqhmZFRbXVJxW+Vn\n\tBareLIJGzgM3AkkYvj+DChHQ3GITJJcMhYSpfr4I=","Date":"Wed, 19 Jan 2022 02:41:51 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20220119000959.2500172-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220119000959.2500172-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: Ensure CameraTest tests are not\n\trun in parallel","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22049,"web_url":"https://patchwork.libcamera.org/comment/22049/","msgid":"<20220119082923.avvlbott5s6qm2ru@uno.localdomain>","date":"2022-01-19T08:29:23","subject":"Re: [libcamera-devel] [PATCH] test: Ensure CameraTest tests are not\n\trun in parallel","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Wed, Jan 19, 2022 at 12:09:59AM +0000, Kieran Bingham wrote:\n> The fence and mapped-buffer tests both use the VIMC test device and must\n> not be run at the same time.\n>\n> Split these tests to a new group to force their isolation from running\n> in parallel.\n>\n> Signed-off-by: Kieran Bingham \n\nThanks, sorry, I added fences there without too much thinking\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> test/meson.build | 16 ++++++++++++++--\n> 1 file changed, 14 insertions(+), 2 deletions(-)\n>\n> diff --git a/test/meson.build b/test/meson.build\n> index 2c9487e203e2..fd4c5ca07c15 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -39,11 +39,9 @@ internal_tests = [\n> ['event', 'event.cpp'],\n> ['event-dispatcher', 'event-dispatcher.cpp'],\n> ['event-thread', 'event-thread.cpp'],\n> - ['fence', 'fence.cpp'],\n> ['file', 'file.cpp'],\n> ['flags', 'flags.cpp'],\n> ['hotplug-cameras', 'hotplug-cameras.cpp'],\n> - ['mapped-buffer', 'mapped-buffer.cpp'],\n> ['message', 'message.cpp'],\n> ['object', 'object.cpp'],\n> ['object-delete', 'object-delete.cpp'],\n> @@ -58,6 +56,11 @@ internal_tests = [\n> ['utils', 'utils.cpp'],\n> ]\n>\n> +internal_non_parallel_tests = [\n> + ['fence', 'fence.cpp'],\n> + ['mapped-buffer', 'mapped-buffer.cpp'],\n> +]\n> +\n> foreach t : public_tests\n> exe = executable(t[0], t[1],\n> dependencies : libcamera_public,\n> @@ -75,3 +78,12 @@ foreach t : internal_tests\n>\n> test(t[0], exe)\n> endforeach\n> +\n> +foreach t : internal_non_parallel_tests\n> + exe = executable(t[0], t[1],\n> + dependencies : libcamera_private,\n> + link_with : test_libraries,\n> + include_directories : test_includes_internal)\n> +\n> + test(t[0], exe, is_parallel : false)\n> +endforeach\n> --\n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 850B3BE086\n\tfor ;\n\tWed, 19 Jan 2022 08:28:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB42A60944;\n\tWed, 19 Jan 2022 09:28:22 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::223])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 695136017F\n\tfor ;\n\tWed, 19 Jan 2022 09:28:21 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id E1C0A60013;\n\tWed, 19 Jan 2022 08:28:20 +0000 (UTC)"],"Date":"Wed, 19 Jan 2022 09:29:23 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20220119082923.avvlbott5s6qm2ru@uno.localdomain>","References":"<20220119000959.2500172-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220119000959.2500172-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: Ensure CameraTest tests are not\n\trun in parallel","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]