[{"id":22016,"web_url":"https://patchwork.libcamera.org/comment/22016/","msgid":"","date":"2022-01-12T07:33:22","subject":"Re: [libcamera-devel] [PATCH 5/5] android: camera_device: Print the\n\tcorrect number of completed streams","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thank you for the patch.\n\nOn Tue, Jan 11, 2022 at 1:54 AM Jacopo Mondi wrote:\n>\n> When a request completes, a debug message is generated to help\n> identify the request and the number of streams if contains.\n>\n> The printed number of streams is however the number of output buffers\n> requested by the camera framework, not the number of streams generated\n> by libcamera. In facts, some output buffers are generated by\n> post-processing, and not directly from the camera.\n>\n> As the debug message prints the libcamera identifier for the Request, it\n> is more logical to print the number of streams generated by the camera\n> instead of the total number of streams.\n>\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Hirokazu Honda \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 4e44bcfa0852..88cb4f943757 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1196,7 +1196,7 @@ void CameraDevice::requestComplete(Request *request)\n> notifyShutter(descriptor->frameNumber_, sensorTimestamp);\n>\n> LOG(HAL, Debug) << \"Request \" << request->cookie() << \" completed with \"\n> - << descriptor->buffers_.size() << \" streams\";\n> + << descriptor->request_->buffers().size() << \" streams\";\n>\n> /*\n> * Generate the metadata associated with the captured buffers.\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6220EBF415\n\tfor ;\n\tWed, 12 Jan 2022 07:33:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E30660935;\n\tWed, 12 Jan 2022 08:33:35 +0100 (CET)","from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n\t[IPv6:2a00:1450:4864:20::535])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9987C60217\n\tfor ;\n\tWed, 12 Jan 2022 08:33:33 +0100 (CET)","by mail-ed1-x535.google.com with SMTP id b13so6470471edn.0\n\tfor ;\n\tTue, 11 Jan 2022 23:33:33 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"m3NYrW8f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=44kjLwnl9yPtD7YsI0s7mF/P1bR4axokA/wAts67z7M=;\n\tb=m3NYrW8fXZzG2qNAhbKWcG6s3gGUGp9jJ+5qE6YNhBth9EhiYB+4fHx2ZRgI1qrgAT\n\t7Qb5Y/b5oiBL6wGkDMzMj8IQM2T4TLLpFpebWUgjhpFeLWit1ef9jz01g3fP/rCd/j4W\n\tsy8dMoXetBwRZUxhvxHCkCsAtM8QJwc9ZU3Ms=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=44kjLwnl9yPtD7YsI0s7mF/P1bR4axokA/wAts67z7M=;\n\tb=BeEITlLDr2y9asvxx9Fzxg3JWNgKhClPoQt4ZtsSO9Aygu1wmoCQ+z5K2h05vFgWEc\n\tXZIuVWt4npQlUTsFplohGvHx/i45SohQTtaxQzHfSQUuhXq3FTvKXEkctlU+re4fmtB2\n\tCzhscFlrKCV2cKHRCNpaGlRTZ0gCA+/J8MEiPMCFu2D567VqzpQnKG43sTVdjUswyyd2\n\tHtRjZm58yjU8VCaoHOvXLSLCbxLJXbqSLXPVqsNDM0LlBPobMQlxm7mfZLumY5CEESkz\n\tlWpNbZ2oamPfvQjKphj68boJj1lcp3PKJhSW+DNOCFpIX0nGAdP8JK8vye+b7M8Jgwbm\n\t67dw==","X-Gm-Message-State":"AOAM532+ZDAY9JODMM+3B55F7WED9UdUzldjRfPUMNmQnv6XeW9ekzH+\n\tUYqUyAMxeHyciUpLiUG3PmHSaM0jFaabS7jf9IVWO3JsmgY=","X-Google-Smtp-Source":"ABdhPJyUv7qLNsaYwj+qmkgUFNvjUCkWuOcn68/qsCu4+8eZ44UdBdwqTsYxHKukmUrhqbg+82fXfMnQJPxyTPqTafc=","X-Received":"by 2002:a17:906:2f0c:: with SMTP id\n\tv12mr6722061eji.761.1641972813298; \n\tTue, 11 Jan 2022 23:33:33 -0800 (PST)","MIME-Version":"1.0","References":"<20220110165524.72978-1-jacopo@jmondi.org>\n\t<20220110165524.72978-6-jacopo@jmondi.org>","In-Reply-To":"<20220110165524.72978-6-jacopo@jmondi.org>","From":"Hirokazu Honda ","Date":"Wed, 12 Jan 2022 16:33:22 +0900","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 5/5] android: camera_device: Print the\n\tcorrect number of completed streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]