{"id":15270,"url":"https://patchwork.libcamera.org/api/patches/15270/?format=json","web_url":"https://patchwork.libcamera.org/patch/15270/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220110165524.72978-6-jacopo@jmondi.org>","date":"2022-01-10T16:55:24","name":"[libcamera-devel,5/5] android: camera_device: Print the correct number of completed streams","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f372720061e2d761352348779023b364428dbae9","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/15270/mbox/","series":[{"id":2887,"url":"https://patchwork.libcamera.org/api/series/2887/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2887","date":"2022-01-10T16:55:19","name":"android: Plumb the YUV processor in","version":1,"mbox":"https://patchwork.libcamera.org/series/2887/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15270/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15270/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B348C325C\n\tfor ;\n\tMon, 10 Jan 2022 16:54:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40CF560942;\n\tMon, 10 Jan 2022 17:54:36 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::221])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB4D4604F8\n\tfor ;\n\tMon, 10 Jan 2022 17:54:33 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 0064E240007;\n\tMon, 10 Jan 2022 16:54:32 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 10 Jan 2022 17:55:24 +0100","Message-Id":"<20220110165524.72978-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220110165524.72978-1-jacopo@jmondi.org>","References":"<20220110165524.72978-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 5/5] android: camera_device: Print the\n\tcorrect number of completed streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When a request completes, a debug message is generated to help\nidentify the request and the number of streams if contains.\n\nThe printed number of streams is however the number of output buffers\nrequested by the camera framework, not the number of streams generated\nby libcamera. In facts, some output buffers are generated by\npost-processing, and not directly from the camera.\n\nAs the debug message prints the libcamera identifier for the Request, it\nis more logical to print the number of streams generated by the camera\ninstead of the total number of streams.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 4e44bcfa0852..88cb4f943757 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1196,7 +1196,7 @@ void CameraDevice::requestComplete(Request *request)\n \tnotifyShutter(descriptor->frameNumber_, sensorTimestamp);\n \n \tLOG(HAL, Debug) << \"Request \" << request->cookie() << \" completed with \"\n-\t\t\t<< descriptor->buffers_.size() << \" streams\";\n+\t\t\t<< descriptor->request_->buffers().size() << \" streams\";\n \n \t/*\n \t * Generate the metadata associated with the captured buffers.\n","prefixes":["libcamera-devel","5/5"]}