{"id":1527,"url":"https://patchwork.libcamera.org/api/patches/1527/?format=json","web_url":"https://patchwork.libcamera.org/patch/1527/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190628170039.29659-1-niklas.soderlund@ragnatech.se>","date":"2019-06-28T17:00:39","name":"[libcamera-devel,v2] libcamera: v4l2_device: Fix variable-sized object initialization","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"867c3063e73570c0608ab0967cfe113b0fc3cf1b","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1527/mbox/","series":[{"id":380,"url":"https://patchwork.libcamera.org/api/series/380/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=380","date":"2019-06-28T17:00:39","name":"[libcamera-devel,v2] libcamera: v4l2_device: Fix variable-sized object initialization","version":2,"mbox":"https://patchwork.libcamera.org/series/380/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1527/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1527/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D59C861D17\n\tfor ;\n\tFri, 28 Jun 2019 19:00:46 +0200 (CEST)","from bismarck.berto.se (unknown [145.14.112.32])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 3d9be8eb-99c6-11e9-8601-0050569116f7;\n\tFri, 28 Jun 2019 19:00:35 +0200 (CEST)"],"X-Halon-ID":"3d9be8eb-99c6-11e9-8601-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 28 Jun 2019 19:00:39 +0200","Message-Id":"<20190628170039.29659-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2] libcamera: v4l2_device: Fix\n\tvariable-sized object initialization","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 28 Jun 2019 17:00:47 -0000"},"content":"Compiling with clang renders errors as a variable-sized arrays are not\nallowed to be initialized. Solve this by using memset() for v4l2Ctrls\nwhich is the only one of the two arrays that needs to be zeroed.\n\n ../../src/libcamera/v4l2_device.cpp:155:37: error: variable-sized object may not be initialized\n const V4L2ControlInfo *controlInfo[count] = {};\n ^~~~~\n ../../src/libcamera/v4l2_device.cpp:156:36: error: variable-sized object may not be initialized\n\t struct v4l2_ext_control v4l2Ctrls[count] = {};\n\t\t\t\t\t ^~~~~\n ../../src/libcamera/v4l2_device.cpp:227:37: error: variable-sized object may not be initialized\n\t const V4L2ControlInfo *controlInfo[count] = {};\n\t\t\t\t\t ^~~~~\n ../../src/libcamera/v4l2_device.cpp:228:36: error: variable-sized object may not be initialized\n\t struct v4l2_ext_control v4l2Ctrls[count] = {};\n\t\t\t\t\t ^~~~~\nFixes: eb068f4e67eedacd (\"libcamera: v4l2_device: Implement get and set controls\")\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/v4l2_device.cpp | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex f1821a7ba162e709..e6395341443ce70a 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -152,8 +152,10 @@ int V4L2Device::getControls(V4L2ControlList *ctrls)\n \tif (count == 0)\n \t\treturn 0;\n \n-\tconst V4L2ControlInfo *controlInfo[count] = {};\n-\tstruct v4l2_ext_control v4l2Ctrls[count] = {};\n+\tconst V4L2ControlInfo *controlInfo[count];\n+\tstruct v4l2_ext_control v4l2Ctrls[count];\n+\tmemset(v4l2Ctrls, 0, count * sizeof(v4l2Ctrls[0]));\n+\n \tfor (unsigned int i = 0; i < count; ++i) {\n \t\tconst V4L2Control *ctrl = ctrls->getByIndex(i);\n \t\tconst V4L2ControlInfo *info = getControlInfo(ctrl->id());\n@@ -224,8 +226,9 @@ int V4L2Device::setControls(V4L2ControlList *ctrls)\n \tif (count == 0)\n \t\treturn 0;\n \n-\tconst V4L2ControlInfo *controlInfo[count] = {};\n-\tstruct v4l2_ext_control v4l2Ctrls[count] = {};\n+\tconst V4L2ControlInfo *controlInfo[count];\n+\tstruct v4l2_ext_control v4l2Ctrls[count];\n+\tmemset(v4l2Ctrls, 0, count * sizeof(v4l2Ctrls[0]));\n \n \tfor (unsigned int i = 0; i < count; ++i) {\n \t\tconst V4L2Control *ctrl = ctrls->getByIndex(i);\n","prefixes":["libcamera-devel","v2"]}