[{"id":21997,"web_url":"https://patchwork.libcamera.org/comment/21997/","msgid":"","date":"2022-01-10T16:07:30","subject":"Re: [libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark\n\tthe Embedded Data stream as external","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for sending this patch!\n\nOn Mon, 10 Jan 2022 at 15:42, Naushir Patuck wrote:\n>\n> Remove the code that marks the Embedded Data stream as external with the Unicam\n> Image (RAW) stream. This was needed for legacy reasons when matching image and\n> embedded buffers, but is not needed any more.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \nTested-by: David Plowman \n\nThanks!\nDavid\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ---------\n> 1 file changed, 9 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 168bbcef819c..a0cd501c8250 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -896,15 +896,6 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> << format.toString();\n> return ret;\n> }\n> -\n> - /*\n> - * If a RAW/Bayer stream has been requested by the application,\n> - * we must set both Unicam streams as external, even though the\n> - * application may only request RAW frames. This is because we\n> - * match timestamps on both streams to synchronise buffers.\n> - */\n> - if (rawStream)\n> - data->unicam_[Unicam::Embedded].setExternal(true);\n> }\n>\n> /*\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACA51BF415\n\tfor ;\n\tMon, 10 Jan 2022 16:07:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE7E660921;\n\tMon, 10 Jan 2022 17:07:42 +0100 (CET)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A01A06021A\n\tfor ;\n\tMon, 10 Jan 2022 17:07:41 +0100 (CET)","by mail-wr1-x42d.google.com with SMTP id v6so27625984wra.8\n\tfor ;\n\tMon, 10 Jan 2022 08:07:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cgv2UL9R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=XWZECuC7OeRno6yvsi/3iAoAQXW7wmdchxz34uM3Ja0=;\n\tb=cgv2UL9Ret+xAu+zISmkwRik0EOb86C7zOxXc5Th3bbO1vFSvODshGgMHnJHIfzD5J\n\t+pSZv7CsHZXeV80ffNSUP5IP2B06yef92OWtDWmrvM2XWZQOX0tBKZmS793k/mjlVffI\n\tCRcBNbvBzNM//eP7pY1AqCymQ3VacOv6XLrzM8DiNYZsMKfgYvw4di/KS2YNpGFwLHVj\n\t0AnswllTLDBvpLMp5XGtT3sfRQpLqSd8QJLAPArza9XmmXfeQuukbOFCMCp9l5yIp51x\n\t7fVZGEe8WoMIZmdkPhlYPd3SJF3QOGdRaKisdZNu9JuFNvAl9dJ7y4sdpRDR2TGxyPpo\n\tLwxw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=XWZECuC7OeRno6yvsi/3iAoAQXW7wmdchxz34uM3Ja0=;\n\tb=jNwkGrKPgvVcPpuu0SgZC4k/kaNq95hkhjrPFhXgHi25svVWBgJPVxjR7HUA3fXWwJ\n\tJmrjzxzK+C2T/og2Ka3OHYKbBtIK7GtI6sANUwLQ81wqZdMzS/JompNq6V570HHIiMI4\n\tDb0ioh6/d8Nw9wbbIak8um+KfrG+uUrXRLBts9JdpsVgNWRozANLCd/tZD8uizKataHN\n\t3NKhUBL+ClS2X6JpmOMGsdI5QDy9WvapgPRclTI/PxmH4xHSNQ4BeaYEcddNFYWd4Q/n\n\tROMQ+dzW2ABpezFz+BX+jqj11fyjbJdAH2URQVR1vgKfqIqdteR8VbUdFB5ezahV1p5K\n\tIIUg==","X-Gm-Message-State":"AOAM533POlLomat/Ha8EsFIr9PEJrQ9+R6JsGeGhUoVxYeslLE5KSHo2\n\t89QAlX8tzsOkYsHl6YkiPQP2fShA8GwXtEe1ZopkbCcNIHEzuQ==","X-Google-Smtp-Source":"ABdhPJzI+Iitf1SBIpRjlH3rLdMhBfsoYt4Ym67CH6D+Taxbw6GvBury9M7tZm0Ijqn+YATOwmdCxHVp0flL5bIDeNs=","X-Received":"by 2002:a05:6000:16c7:: with SMTP id\n\th7mr248425wrf.317.1641830861188; \n\tMon, 10 Jan 2022 08:07:41 -0800 (PST)","MIME-Version":"1.0","References":"<20220110154226.1004602-1-naush@raspberrypi.com>","In-Reply-To":"<20220110154226.1004602-1-naush@raspberrypi.com>","From":"David Plowman ","Date":"Mon, 10 Jan 2022 16:07:30 +0000","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark\n\tthe Embedded Data stream as external","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22062,"web_url":"https://patchwork.libcamera.org/comment/22062/","msgid":"","date":"2022-01-24T10:10:22","subject":"Re: [libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark\n\tthe Embedded Data stream as external","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\nGentle ping for feedback on this change please :)\n\nThanks,\nNaush\n\nOn Mon, 10 Jan 2022 at 15:42, Naushir Patuck wrote:\n\n> Remove the code that marks the Embedded Data stream as external with the\n> Unicam\n> Image (RAW) stream. This was needed for legacy reasons when matching image\n> and\n> embedded buffers, but is not needed any more.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ---------\n> 1 file changed, 9 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 168bbcef819c..a0cd501c8250 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -896,15 +896,6 @@ int PipelineHandlerRPi::configure(Camera *camera,\n> CameraConfiguration *config)\n> << format.toString();\n> return ret;\n> }\n> -\n> - /*\n> - * If a RAW/Bayer stream has been requested by the\n> application,\n> - * we must set both Unicam streams as external, even\n> though the\n> - * application may only request RAW frames. This is\n> because we\n> - * match timestamps on both streams to synchronise buffers.\n> - */\n> - if (rawStream)\n> - data->unicam_[Unicam::Embedded].setExternal(true);\n> }\n>\n> /*\n> --\n> 2.25.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27B60BDCBF\n\tfor ;\n\tMon, 24 Jan 2022 10:10:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 568DF609A7;\n\tMon, 24 Jan 2022 11:10:42 +0100 (CET)","from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com\n\t[IPv6:2a00:1450:4864:20::22f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B811D60215\n\tfor ;\n\tMon, 24 Jan 2022 11:10:39 +0100 (CET)","by mail-lj1-x22f.google.com with SMTP id z7so7520758ljj.4\n\tfor ;\n\tMon, 24 Jan 2022 02:10:39 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"EnPHYg/j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=DcZY+yn4gZcvdOl+qEwZSeU55B5RY2sSjVxRJhrQb4Y=;\n\tb=EnPHYg/jNFH/dUXpo6ODfn1+pbjPuxG0q1HcvkFyGRhivzGJjZSnLxP/xQTH4e1QUE\n\tb0+wnM0yOug+dj3DzuH+1DLhk7kjbP/9fnO1yGK4gG1rU2Xyjahm8e+s/uEV/q5eHnfB\n\txNoKbNoRP4shujUbc1SKPe2C8kXs+0tIw+N8ytDyuELslfT4RLrDquibQb4v1V5GR6Wu\n\tH3E8oU18jY1JZuulr0cKbRljVFM3i55yA+o092uAx/XUb/fjmpFyatpZYZo/dv4JtXv6\n\tzyHoO8TLxXu+y1oUkaiY9dgP+ptDXf3QUv3U7lq2dwmZTNHvUwI4cJvP6anad7+BVUGe\n\t6E6Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=DcZY+yn4gZcvdOl+qEwZSeU55B5RY2sSjVxRJhrQb4Y=;\n\tb=bmW7i31a3OKQg1hfm0C+TH6lbDuAhuoZ16H8Qtafx1wrQ9/lWlXsPN87xCt7fK5NUu\n\tIiU5Cmfk2pCSuFh2sy9wOtjLFlU+xgPE0jYI5ijjRFC3Ebu5Lzf1qDkbwtpSoSSUQSwm\n\tyhn8QwiI8gtDivfLGhrhZd9WCGbdn3hEqtgs9Jj9grQzmOEFStnvAc41+JXtFXsQZ0DR\n\tKbeaiTwMXjszBad2vYjc8rTEj3QNIUTmp6MvP4bN3k18maFxGSjL1gdhvi29MoxP00cE\n\tjVT7b1IN3P/tOiOcihiqtwLml1hGI1BHOO1QJw6V2bqomuzDqdEowAkB0Owi7lEgnb/+\n\tgBoA==","X-Gm-Message-State":"AOAM532coiT5YLuBbsexGlze4d7a000TiDjG/1+ZCX1YGXtJDnY938Bh\n\tUax1frdnrviE2WgnGatPySYKdzYJOyUdHBVixFzQXFVC3g0=","X-Google-Smtp-Source":"ABdhPJwZXwffLGkfXbI8/f3iXXnCfLHOg1gHshhLh3uCksY4exj3JlRqKyDcHtsa6tS6nCJkTs+JJhzSMvQ75pBUO7A=","X-Received":"by 2002:a2e:a233:: with SMTP id i19mr5638166ljm.16.1643019038527;\n\tMon, 24 Jan 2022 02:10:38 -0800 (PST)","MIME-Version":"1.0","References":"<20220110154226.1004602-1-naush@raspberrypi.com>","In-Reply-To":"<20220110154226.1004602-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Mon, 24 Jan 2022 10:10:22 +0000","Message-ID":"","To":"libcamera devel ","Content-Type":"multipart/alternative; boundary=\"00000000000026a67905d6512e09\"","Subject":"Re: [libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark\n\tthe Embedded Data stream as external","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22077,"web_url":"https://patchwork.libcamera.org/comment/22077/","msgid":"<164367324695.115113.6591691777197363033@Monstersaurus>","date":"2022-01-31T23:54:06","subject":"Re: [libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark\n\tthe Embedded Data stream as external","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nQuoting Naushir Patuck (2022-01-10 15:42:26)\n> Remove the code that marks the Embedded Data stream as external with the Unicam\n> Image (RAW) stream. This was needed for legacy reasons when matching image and\n> embedded buffers, but is not needed any more.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ---------\n> 1 file changed, 9 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 168bbcef819c..a0cd501c8250 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -896,15 +896,6 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> << format.toString();\n> return ret;\n> }\n> -\n> - /*\n> - * If a RAW/Bayer stream has been requested by the application,\n> - * we must set both Unicam streams as external, even though the\n> - * application may only request RAW frames. This is because we\n> - * match timestamps on both streams to synchronise buffers.\n> - */\n> - if (rawStream)\n> - data->unicam_[Unicam::Embedded].setExternal(true);\n\nFor such a small patch there's a lot of digging to get my head around\nthis, but I believe it's fine, and I trust David's testing so...\n\nReviewed-by: Kieran Bingham \n\n> }\n> \n> /*\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCD8FBF415\n\tfor ;\n\tMon, 31 Jan 2022 23:54:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4731A609AC;\n\tTue, 1 Feb 2022 00:54:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9025604F1\n\tfor ;\n\tTue, 1 Feb 2022 00:54:09 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8704C9DE;\n\tTue, 1 Feb 2022 00:54:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q+QwfAFJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1643673249;\n\tbh=wtKgTgyngljT2OkKeyLLE60V0seJSFyokCpH3e06T0U=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=q+QwfAFJx2wkHE5nfT60rFs8sISwb3hKQKmjtfYXh4582w1BMRzp/lu54QL+gtbLo\n\tZEQzhNbuTNhXjd+7Xo4l54WdTAj31WLMJ+rK5NE5s49L1++OFzZKMYBVfWiiF/A6AS\n\t0171gimdZtPSfx+p3SolEn+jOw1LxG0dttqozbX8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220110154226.1004602-1-naush@raspberrypi.com>","References":"<20220110154226.1004602-1-naush@raspberrypi.com>","From":"Kieran Bingham ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 31 Jan 2022 23:54:06 +0000","Message-ID":"<164367324695.115113.6591691777197363033@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark\n\tthe Embedded Data stream as external","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]