[{"id":21947,"web_url":"https://patchwork.libcamera.org/comment/21947/","msgid":"","date":"2022-01-04T23:33:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: pkg-config: Do not\n\thardcode version","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jan 04, 2022 at 11:26:57PM +0000, Kieran Bingham wrote:\n> The pkg-config version should not be hardcoded, and it should match the\n> version of the library, ideally with point releases where possible.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> With this patch, the pkg-config libcamera.pc will report\n> Version: 0.0.0\n> As defined by our meson project instead of \n> Version: 1.0\n> \n> src/libcamera/base/meson.build | 1 -\n> src/libcamera/meson.build | 1 -\n> 2 files changed, 2 deletions(-)\n> \n> diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\n> index 0ae3b0aab7e2..7030ad1f5927 100644\n> --- a/src/libcamera/base/meson.build\n> +++ b/src/libcamera/base/meson.build\n> @@ -65,7 +65,6 @@ libcamera_base = declare_dependency(sources : [\n> \n> pkg_mod = import('pkgconfig')\n> pkg_mod.generate(libcamera_base_lib,\n> - version : '1.0',\n> description : 'Camera support base utility library',\n> subdirs : 'libcamera')\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 7ae909d47fe5..26912ca17819 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -162,7 +162,6 @@ libcamera_private = declare_dependency(sources : [\n> pkg_mod = import('pkgconfig')\n> pkg_mod.generate(libcamera,\n> libraries : libcamera_base_lib,\n> - version : '1.0',\n> description : 'Complex Camera Support Library',\n> subdirs : 'libcamera')\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12AAABF415\n\tfor ;\n\tTue, 4 Jan 2022 23:33:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81AD3604F5;\n\tWed, 5 Jan 2022 00:33:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEE996021A\n\tfor ;\n\tWed, 5 Jan 2022 00:33:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 352FF501;\n\tWed, 5 Jan 2022 00:33:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XQOnN4h9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641339209;\n\tbh=lQJFCOATJ2Ni7M27GIrA1dc2o1JB4Pm6ruH/xVHHYjw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XQOnN4h9sfR2lcaBdrwHAwVJrDUhky39WOGNpTNSiBKmX4WN5qCv2ixJtcbjCit1d\n\tTiH58VkwSITLCsltEh3TLlj4moHiUCwnDtRE7HrlJgxbTQ6S1rBSIs0ERqXL1Kr6CH\n\t6rlpyTHjxvo68JghZyOuBjwnJJ6OwH6n5gSL33PQ=","Date":"Wed, 5 Jan 2022 01:33:24 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20220104232657.1350703-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220104232657.1350703-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pkg-config: Do not\n\thardcode version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21961,"web_url":"https://patchwork.libcamera.org/comment/21961/","msgid":"<20220106102513.2uu67gfn33shbmpf@uno.localdomain>","date":"2022-01-06T10:25:13","subject":"Re: [libcamera-devel] [PATCH] libcamera: pkg-config: Do not\n\thardcode version","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Tue, Jan 04, 2022 at 11:26:57PM +0000, Kieran Bingham wrote:\n> The pkg-config version should not be hardcoded, and it should match the\n> version of the library, ideally with point releases where possible.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n>\n> With this patch, the pkg-config libcamera.pc will report\n> Version: 0.0.0\n> As defined by our meson project instead of\n> Version: 1.0\n>\n> src/libcamera/base/meson.build | 1 -\n> src/libcamera/meson.build | 1 -\n> 2 files changed, 2 deletions(-)\n>\n> diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\n> index 0ae3b0aab7e2..7030ad1f5927 100644\n> --- a/src/libcamera/base/meson.build\n> +++ b/src/libcamera/base/meson.build\n> @@ -65,7 +65,6 @@ libcamera_base = declare_dependency(sources : [\n>\n> pkg_mod = import('pkgconfig')\n> pkg_mod.generate(libcamera_base_lib,\n> - version : '1.0',\n> description : 'Camera support base utility library',\n> subdirs : 'libcamera')\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 7ae909d47fe5..26912ca17819 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -162,7 +162,6 @@ libcamera_private = declare_dependency(sources : [\n> pkg_mod = import('pkgconfig')\n> pkg_mod.generate(libcamera,\n> libraries : libcamera_base_lib,\n> - version : '1.0',\n> description : 'Complex Camera Support Library',\n> subdirs : 'libcamera')\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B04ADBE080\n\tfor ;\n\tThu, 6 Jan 2022 10:24:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B60E6091E;\n\tThu, 6 Jan 2022 11:24:18 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1594F604F5\n\tfor ;\n\tThu, 6 Jan 2022 11:24:16 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 635C320004;\n\tThu, 6 Jan 2022 10:24:15 +0000 (UTC)"],"Date":"Thu, 6 Jan 2022 11:25:13 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20220106102513.2uu67gfn33shbmpf@uno.localdomain>","References":"<20220104232657.1350703-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220104232657.1350703-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pkg-config: Do not\n\thardcode version","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]