[{"id":22208,"web_url":"https://patchwork.libcamera.org/comment/22208/","msgid":"<164612707147.2188904.4217514631023194152@Monstersaurus>","date":"2022-03-01T09:31:11","subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_request: Lifetime\n\tof a Camera3RequestDescriptor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2022-01-04 06:52:01)\n> This commit provides a sketch regarding Camera3RequestDescriptor\n> which aids tracking each capture reuqest placed by the android\n> framework to libcamera HAL.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Laurent Pinchart \n\nI like this. We could probably squeeze it down a bit but I don't think\nit matters.\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_request.cpp | 88 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 88 insertions(+)\n> \n> diff --git a/src/android/camera_request.cpp b/src/android/camera_request.cpp\n> index 027b46d3..fceaa1f7 100644\n> --- a/src/android/camera_request.cpp\n> +++ b/src/android/camera_request.cpp\n> @@ -18,6 +18,94 @@ using namespace libcamera;\n> *\n> * A utility class that groups information about a capture request to be later\n> * reused at request complete time to notify the framework.\n> + *\n> + *******************************************************************************\n> + * Lifetime of a Camera3RequestDescriptor tracking a capture request placed by\n> + * Android Framework\n> + *******************************************************************************\n> + *\n> + *\n> + * Android Framework\n> + * │\n> + * │ ┌──────────────────────────────────┐\n> + * │ │camera3_capture_request_t │\n> + * │ │ │\n> + * │ │Requested output streams │\n> + * │ │ stream1 stream2 stream3 ... │\n> + * │ └──────────────────────────────────┘\n> + * ▼\n> + * ┌─────────────────────────────────────────────────────────────┐\n> + * │ libcamera HAL │\n> + * ├─────────────────────────────────────────────────────────────┤\n> + * │ CameraDevice │\n> + * │ │\n> + * │ processCaptureRequest(camera3_capture_request_t request) │\n> + * │ │\n> + * │ - Create Camera3RequestDescriptor tracking this request │\n> + * │ - Streams requiring post-processing are stored in the │\n> + * │ pendingStreamsToProcess map │\n> + * │ - Add this Camera3RequestDescriptor to descriptors' queue │\n> + * │ CameraDevice::descriptors_ │\n> + * │ │ ┌─────────────────────────┐\n> + * │ - Queue the capture request to libcamera core ────────────┤►│libcamera core │\n> + * │ │ ├─────────────────────────┤\n> + * │ │ │- Capture from Camera │\n> + * │ │ │ │\n> + * │ │ │- Emit │\n> + * │ │ │ Camera::requestComplete│\n> + * │ requestCompleted(Request *request) ◄───────────────────────┼─┼──── │\n> + * │ │ │ │\n> + * │ - Check request completion status │ └─────────────────────────┘\n> + * │ │\n> + * │ - if (pendingStreamsToProcess > 0) │\n> + * │ Queue all entries from pendingStreamsToProcess │\n> + * │ else │ │\n> + * │ completeDescriptor() │ └──────────────────────┐\n> + * │ │ │\n> + * │ ┌──────────────────────────┴───┬──────────────────┐ │\n> + * │ │ │ │ │\n> + * │ ┌──────────▼────────────┐ ┌───────────▼─────────┐ ▼ │\n> + * │ │CameraStream1 │ │CameraStream2 │ .... │\n> + * │ ├┬───┬───┬──────────────┤ ├┬───┬───┬────────────┤ │\n> + * │ ││ │ │ │ ││ │ │ │ │\n> + * │ │▼───▼───▼──────────────┤ │▼───▼───▼────────────┤ │\n> + * │ │PostProcessorWorker │ │PostProcessorWorker │ │\n> + * │ │ │ │ │ │\n> + * │ │ +------------------+ │ │ +------------------+│ │\n> + * │ │ | PostProcessor | │ │ | PostProcessor |│ │\n> + * │ │ | process() | │ │ | process() |│ │\n> + * │ │ | | │ │ | |│ │\n> + * │ │ | Emit | │ │ | Emit |│ │\n> + * │ │ | processComplete | │ │ | processComplete |│ │\n> + * │ │ | | │ │ | |│ │\n> + * │ │ +--------------│---+ │ │ +--------------│---+│ │\n> + * │ │ │ │ │ │ │ │\n> + * │ │ │ │ │ │ │ │\n> + * │ └────────────────┼──────┘ └────────────────┼────┘ │\n> + * │ │ │ │\n> + * │ │ │ │\n> + * │ │ │ │\n> + * │ ▼ ▼ │\n> + * │ +---------------------------------------+ +--------------+ │\n> + * │ | CameraDevice | | | │\n> + * │ | | | | │\n> + * │ | streamProcessingComplete() | | | │\n> + * │ | | | | │\n> + * │ | - Check and set buffer status | | .... | │\n> + * │ | - Remove post+processing entry | | | │\n> + * │ | from pendingStreamsToProcess | | | │\n> + * │ | | | | │\n> + * │ | - if (pendingStreamsToProcess.empty())| | | │\n> + * │ | completeDescriptor | | | │\n> + * │ | | | | │\n> + * │ +---------------------------------------+ +--------------+ │\n> + * │ │\n> + * └────────────────────────────────────────────────────────────────────────────────────┘\n> + *\n> + * +-------------+\n> + * | | - PostProcessorWorker's thread\n> + * | |\n> + * +-------------+\n> */\n> \n> Camera3RequestDescriptor::Camera3RequestDescriptor(\n> -- \n> 2.31.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A22DBE08A\n\tfor ;\n\tTue, 1 Mar 2022 09:31:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E70CE61166;\n\tTue, 1 Mar 2022 10:31:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2329B6047A\n\tfor ;\n\tTue, 1 Mar 2022 10:31:14 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A97A2478;\n\tTue, 1 Mar 2022 10:31:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hicnaXZF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646127073;\n\tbh=CN0nIib4DOphTcHYF3RhPukr82DFdphhNtLTUm0Bur8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=hicnaXZFfWmPubKWp5cWvZRTGXHbq4Ze11htD3QLFUIqL9fQZcHZciHnOGxLWTwK9\n\tkyPt6EP4mGn9onQ8lSbva41oT18blXddhX29Db9Yz/BGfwWqATrN/lMV4PNkzv4bAv\n\tFsVnSLFKgqnLOmpzjBdSHaYpXngPJnxZv1BPe8y8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220104065201.25744-3-umang.jain@ideasonboard.com>","References":"<20220104065201.25744-1-umang.jain@ideasonboard.com>\n\t<20220104065201.25744-3-umang.jain@ideasonboard.com>","From":"Kieran Bingham ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 01 Mar 2022 09:31:11 +0000","Message-ID":"<164612707147.2188904.4217514631023194152@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_request: Lifetime\n\tof a Camera3RequestDescriptor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]