[{"id":21924,"web_url":"https://patchwork.libcamera.org/comment/21924/","msgid":"<9283e935-7262-4575-dc2f-3e23a5a9bd79@ideasonboard.com>","date":"2022-01-03T02:54:58","subject":"Re: [libcamera-devel] [PATCH] utils: update-kernel-headers: Update\n\tpath to intel-ipu3.h","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch\n\nOn 12/30/21 9:36 PM, Laurent Pinchart wrote:\n> The intel-ipu3.h header has moved in the v5.14 kernel. Update the kernel\n> headers update script accordingly.\n>\n> While at it, add a missing directory separator to fix a failure when the\n> path to the kernel tree doesn't end with a /.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> utils/update-kernel-headers.sh | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index 3c3f34c77ad7..a006452e6836 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -66,8 +66,8 @@ done\n> \n> # The IPU3 header is a special case, as it's stored in staging. Handle it\n> # manually.\n> -(cd \"${install_dir}\" ; \"${kernel_dir}scripts/headers_install.sh\" \\\n> -\t\"${kernel_dir}/drivers/staging/media/ipu3/include/intel-ipu3.h\" \\\n> +(cd \"${install_dir}\" ; \"${kernel_dir}/scripts/headers_install.sh\" \\\n> +\t\"${kernel_dir}/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h\" \\\n> \t\"${header_dir}/intel-ipu3.h\")\n> \n> # Update the README file\n>\n> base-commit: 030e6f389e2d0fa3f10a47634f3609378ccaf70e\n> prerequisite-patch-id: 2c7bab8c8f15090cf10a19aaed62e33de1264351\n> prerequisite-patch-id: 10478d16a049f895236c9b7bafcbe6d3a9b69ef9\n> prerequisite-patch-id: f6f3784841cc8648c6b6cfdd12b7903751856f75\n> prerequisite-patch-id: 41c39d0df627b7c1856cc8bc4d099f408983d6cd\n> prerequisite-patch-id: 80397d3462f248e4ca0e9f3bcb2d793178b03142\n> prerequisite-patch-id: 490c8f45203ef4d2281bddf2b36855ed99e1b2a4\n> prerequisite-patch-id: 06537d8dd2471934bca5772ddb6556a85a32ee9c\n> prerequisite-patch-id: e1c7842e5c488f6d3790a9c45b69974d8624dce4\n> prerequisite-patch-id: 55a68f42975a115ab642766965a5e6c8f2c07026\n> prerequisite-patch-id: 8601bcfa3c7da8d9984ac08e182610b5b52cbba9\n> prerequisite-patch-id: 8bb54baf7b5a46c0d14606c2f1020e943633954e\n> prerequisite-patch-id: f9b1926bdaa91bb4879b8e28f6849df8d6a9ae64\n> prerequisite-patch-id: 2c928f3693350ad60bff02897240e379ab8fab1a\n> prerequisite-patch-id: 651a51e9b14eb8ea497db106f3f9bf0be5a395fe","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67FCABE080\n\tfor ;\n\tMon, 3 Jan 2022 02:55:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1738E60868;\n\tMon, 3 Jan 2022 03:55:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AAC9260219\n\tfor ;\n\tMon, 3 Jan 2022 03:55:04 +0100 (CET)","from [IPv6:2401:4900:1f3e:193e:9a73:f356:8c6a:a1aa] (unknown\n\t[IPv6:2401:4900:1f3e:193e:9a73:f356:8c6a:a1aa])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFADFCC;\n\tMon, 3 Jan 2022 03:55:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"npZx4ed5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641178504;\n\tbh=KSK0ChsKyFQxI1ReNLoOjaB0fLhWqv8rj5Pb24pXnjI=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=npZx4ed58OzKJxJchptR3ytsSIFk4SXouzYyFOKZFYEu7mzRmUcPFa8wZQxmwzrk/\n\tqFNqEnsE8d6sRbz1n/Tn5vM1gxQqSdFtRP0NJTMoAk7eR5SSC89d4wybYlGON/qMQB\n\tI84cxWIJkcJA9fJmmwIP6qHmogwi5A2VDYxtbIX0=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211230160611.22273-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<9283e935-7262-4575-dc2f-3e23a5a9bd79@ideasonboard.com>","Date":"Mon, 3 Jan 2022 08:24:58 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211230160611.22273-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] utils: update-kernel-headers: Update\n\tpath to intel-ipu3.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21925,"web_url":"https://patchwork.libcamera.org/comment/21925/","msgid":"<164121635285.3986460.10498227459395524514@Monstersaurus>","date":"2022-01-03T13:25:52","subject":"Re: [libcamera-devel] [PATCH] utils: update-kernel-headers: Update\n\tpath to intel-ipu3.h","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-12-30 16:06:11)\n> The intel-ipu3.h header has moved in the v5.14 kernel. Update the kernel\n> headers update script accordingly.\n> \n> While at it, add a missing directory separator to fix a failure when the\n> path to the kernel tree doesn't end with a /.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/update-kernel-headers.sh | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index 3c3f34c77ad7..a006452e6836 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -66,8 +66,8 @@ done\n> \n> # The IPU3 header is a special case, as it's stored in staging. Handle it\n> # manually.\n> -(cd \"${install_dir}\" ; \"${kernel_dir}scripts/headers_install.sh\" \\\n> - \"${kernel_dir}/drivers/staging/media/ipu3/include/intel-ipu3.h\" \\\n> +(cd \"${install_dir}\" ; \"${kernel_dir}/scripts/headers_install.sh\" \\\n> + \"${kernel_dir}/drivers/staging/media/ipu3/include/uapi/intel-ipu3.h\" \\\n> \"${header_dir}/intel-ipu3.h\")\n> \n> # Update the README file\n> \n> base-commit: 030e6f389e2d0fa3f10a47634f3609378ccaf70e\n> prerequisite-patch-id: 2c7bab8c8f15090cf10a19aaed62e33de1264351\n> prerequisite-patch-id: 10478d16a049f895236c9b7bafcbe6d3a9b69ef9\n> prerequisite-patch-id: f6f3784841cc8648c6b6cfdd12b7903751856f75\n> prerequisite-patch-id: 41c39d0df627b7c1856cc8bc4d099f408983d6cd\n> prerequisite-patch-id: 80397d3462f248e4ca0e9f3bcb2d793178b03142\n> prerequisite-patch-id: 490c8f45203ef4d2281bddf2b36855ed99e1b2a4\n> prerequisite-patch-id: 06537d8dd2471934bca5772ddb6556a85a32ee9c\n> prerequisite-patch-id: e1c7842e5c488f6d3790a9c45b69974d8624dce4\n> prerequisite-patch-id: 55a68f42975a115ab642766965a5e6c8f2c07026\n> prerequisite-patch-id: 8601bcfa3c7da8d9984ac08e182610b5b52cbba9\n> prerequisite-patch-id: 8bb54baf7b5a46c0d14606c2f1020e943633954e\n> prerequisite-patch-id: f9b1926bdaa91bb4879b8e28f6849df8d6a9ae64\n> prerequisite-patch-id: 2c928f3693350ad60bff02897240e379ab8fab1a\n> prerequisite-patch-id: 651a51e9b14eb8ea497db106f3f9bf0be5a395fe\n\nDoes it really require all those prerequisites ;-)\n\nBut the file is indeed there at the new location:\n\nReviewed-by: Kieran Bingham \n\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DDA7BF415\n\tfor ;\n\tMon, 3 Jan 2022 13:25:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B6DD604F6;\n\tMon, 3 Jan 2022 14:25:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24BCD604F4\n\tfor ;\n\tMon, 3 Jan 2022 14:25:55 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA123CC;\n\tMon, 3 Jan 2022 14:25:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"geld67Yn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641216354;\n\tbh=N925D0EwQcqGZAhyhh5GJ1Lq+aa3FPiylpzHvht9oyQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=geld67YnT7eET9/lD3q+Qvy/n/HhOwZboIo753AN1lxx2Dkp7HQbz3eSwbCGNuhlX\n\t9erJbbDS74RE8RlRLy6qHqSgwobmlEyal76jbJ1WbCt+qr6qVlUUoJfYylj9JAHB5N\n\tvj4dJbjuGEqHMGRBxijd2QitXE1/dMJM1baCJUF4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211230160611.22273-1-laurent.pinchart@ideasonboard.com>","References":"<20211230160611.22273-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 03 Jan 2022 13:25:52 +0000","Message-ID":"<164121635285.3986460.10498227459395524514@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] utils: update-kernel-headers: Update\n\tpath to intel-ipu3.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]