[{"id":22000,"web_url":"https://patchwork.libcamera.org/comment/22000/","msgid":"<164183291074.10801.1638481476847649353@Monstersaurus>","date":"2022-01-10T16:41:50","subject":"Re: [libcamera-devel] [PATCH v1 3/5] v4l2: v4l2_camera_proxy: Drop\n\ttrace message from freeBuffers()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-12-28 21:59:49)\n> The freeBuffers() function is only called from vidioc_reqbufs(), which\n> already logs a trace message. Remove the duplicate.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index c1375777c185..80e6624bc9b7 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -445,8 +445,6 @@ int V4L2CameraProxy::vidioc_s_input(V4L2CameraFile *file, int *arg)\n> \n> void V4L2CameraProxy::freeBuffers()\n> {\n> - LOG(V4L2Compat, Debug) << \"Freeing libcamera bufs\";\n> -\n> vcam_->freeBuffers();\n> buffers_.clear();\n> bufferCount_ = 0;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79870BE080\n\tfor ;\n\tMon, 10 Jan 2022 16:41:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37C9260921;\n\tMon, 10 Jan 2022 17:41:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B06A6021A\n\tfor ;\n\tMon, 10 Jan 2022 17:41:53 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 39B19A50;\n\tMon, 10 Jan 2022 17:41:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZU5Ae0Vc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641832913;\n\tbh=z7hHUeJGDnL+38mMAQHEL1+zkElTqpIXSUC4nLIeDS0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ZU5Ae0VcW6slpO8UlmTrQc6YQvAjg3q8RiGYXRqN80PuEYU2FW0fd2dyltcs+3308\n\tmWnisv1FqLkHqJvDRdiNVJNhp68+pulfSTJLpCwQLKf1P7ktJukm2Ojin56wwt0PDQ\n\t9y4pYpeZFeEsBpt0g8Wj1sviPALJrdwYnpB5wLMw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211228215951.32396-4-laurent.pinchart@ideasonboard.com>","References":"<20211228215951.32396-1-laurent.pinchart@ideasonboard.com>\n\t<20211228215951.32396-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 10 Jan 2022 16:41:50 +0000","Message-ID":"<164183291074.10801.1638481476847649353@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 3/5] v4l2: v4l2_camera_proxy: Drop\n\ttrace message from freeBuffers()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22030,"web_url":"https://patchwork.libcamera.org/comment/22030/","msgid":"<20220114104140.GE4255@pyrite.rasen.tech>","date":"2022-01-14T10:41:40","subject":"Re: [libcamera-devel] [PATCH v1 3/5] v4l2: v4l2_camera_proxy: Drop\n\ttrace message from freeBuffers()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Dec 28, 2021 at 11:59:49PM +0200, Laurent Pinchart wrote:\n> The freeBuffers() function is only called from vidioc_reqbufs(), which\n> already logs a trace message. Remove the duplicate.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index c1375777c185..80e6624bc9b7 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -445,8 +445,6 @@ int V4L2CameraProxy::vidioc_s_input(V4L2CameraFile *file, int *arg)\n> \n> void V4L2CameraProxy::freeBuffers()\n> {\n> -\tLOG(V4L2Compat, Debug) << \"Freeing libcamera bufs\";\n> -\n> \tvcam_->freeBuffers();\n> \tbuffers_.clear();\n> \tbufferCount_ = 0;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 846D1BF415\n\tfor ;\n\tFri, 14 Jan 2022 10:41:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39DBB604F8;\n\tFri, 14 Jan 2022 11:41:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36B606017D\n\tfor ;\n\tFri, 14 Jan 2022 11:41:48 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFEF6A2A;\n\tFri, 14 Jan 2022 11:41:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GkzUhZ8z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1642156908;\n\tbh=ou15OD2KexpixibQ6py+eSKdBRhqOgdPWlWtkvuH5w8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GkzUhZ8z1CeelRTeSXOGzE+LDk1isRdRqqqLjG3w7opnr32QNrRhKJgkp/Eq769SO\n\tlqShnfv/mXCTafNk8ldXuNRQr0Fh5xOooAc/Pu1Ulg4kZBwDRYhsbWJN74S4NG9Aqd\n\tcUxbFZjChW8D1BJa8yy2KCLkS5G6+lZ/BM5qkfzM=","Date":"Fri, 14 Jan 2022 19:41:40 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20220114104140.GE4255@pyrite.rasen.tech>","References":"<20211228215951.32396-1-laurent.pinchart@ideasonboard.com>\n\t<20211228215951.32396-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211228215951.32396-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 3/5] v4l2: v4l2_camera_proxy: Drop\n\ttrace message from freeBuffers()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]