[{"id":21999,"web_url":"https://patchwork.libcamera.org/comment/21999/","msgid":"<164183288750.10801.13242060567663686648@Monstersaurus>","date":"2022-01-10T16:41:27","subject":"Re: [libcamera-devel] [PATCH v1 1/5] v4l2: v4l2_compat_manager:\n\tPrint path and fd in openat()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-12-28 21:59:47)\n> The V4L2 compat layer prints debug messages that mention the file\n> descriptor of the video device, but no message that links the device\n> path to the file descriptor. Fix it by adding a debug message in\n> openat().\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/v4l2/v4l2_compat_manager.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\n> index 690a191fe2bf..c64cdb862489 100644\n> --- a/src/v4l2/v4l2_compat_manager.cpp\n> +++ b/src/v4l2/v4l2_compat_manager.cpp\n> @@ -158,6 +158,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod\n> V4L2CameraProxy *proxy = proxies_[ret].get();\n> files_.emplace(efd, std::make_shared(efd, oflag & O_NONBLOCK, proxy));\n> \n> + LOG(V4L2Compat, Debug) << \"Opened \" << path << \" -> fd \" << efd;\n> return efd;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21411BE080\n\tfor ;\n\tMon, 10 Jan 2022 16:41:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0385604F8;\n\tMon, 10 Jan 2022 17:41:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DABB06021A\n\tfor ;\n\tMon, 10 Jan 2022 17:41:30 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6405AA50;\n\tMon, 10 Jan 2022 17:41:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q78FoEBq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641832890;\n\tbh=ae49YeteQvJ6kwpY9xR++XhN8WV04Tp7dkvUi+gqtSQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Q78FoEBqaQgW3IaSx9VBG5cir0NCbbJemdMD31p7fyReDNbKfj/NlATfRqlzVsUlI\n\ttTFOHgqQ9UmovRZkKN8I3pSQgbGLiWyra92BY849f3rexzyEyf/ElMSEA6ZPm1KTG0\n\tOaxhc0MO+wplU7QpqhdexGYdP4SeKpA5qomMh6ms=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211228215951.32396-2-laurent.pinchart@ideasonboard.com>","References":"<20211228215951.32396-1-laurent.pinchart@ideasonboard.com>\n\t<20211228215951.32396-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 10 Jan 2022 16:41:27 +0000","Message-ID":"<164183288750.10801.13242060567663686648@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1 1/5] v4l2: v4l2_compat_manager:\n\tPrint path and fd in openat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22028,"web_url":"https://patchwork.libcamera.org/comment/22028/","msgid":"<20220114094250.GC4255@pyrite.rasen.tech>","date":"2022-01-14T09:42:50","subject":"Re: [libcamera-devel] [PATCH v1 1/5] v4l2: v4l2_compat_manager:\n\tPrint path and fd in openat()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Dec 28, 2021 at 11:59:47PM +0200, Laurent Pinchart wrote:\n> The V4L2 compat layer prints debug messages that mention the file\n> descriptor of the video device, but no message that links the device\n> path to the file descriptor. Fix it by adding a debug message in\n> openat().\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/v4l2/v4l2_compat_manager.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\n> index 690a191fe2bf..c64cdb862489 100644\n> --- a/src/v4l2/v4l2_compat_manager.cpp\n> +++ b/src/v4l2/v4l2_compat_manager.cpp\n> @@ -158,6 +158,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod\n> \tV4L2CameraProxy *proxy = proxies_[ret].get();\n> \tfiles_.emplace(efd, std::make_shared(efd, oflag & O_NONBLOCK, proxy));\n> \n> +\tLOG(V4L2Compat, Debug) << \"Opened \" << path << \" -> fd \" << efd;\n> \treturn efd;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2378BE086\n\tfor ;\n\tFri, 14 Jan 2022 09:43:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D67D8604F8;\n\tFri, 14 Jan 2022 10:43:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B2536017D\n\tfor ;\n\tFri, 14 Jan 2022 10:42:59 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B16BCA2A;\n\tFri, 14 Jan 2022 10:42:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z3HXURiy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1642153378;\n\tbh=dao+EAixzdmW0/JZRmZaSOOXBj8N2ZwlNcue7l+F1rc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Z3HXURiyTwIA9ZzO/qQZVta+wdYiuW9g/ddWas5DtFO9+mEbEykjODJkhpAVaxuCv\n\thMuWZqVPRwdsBKUYPLPSvZ0hto1N8rt+5cirD6zXGPu0/BaUUd8Sgq+2XlNoyJEI+V\n\tur9nfWK4ij4+BrjCSzP6dQa5C06WhNqla3jly6sE=","Date":"Fri, 14 Jan 2022 18:42:50 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20220114094250.GC4255@pyrite.rasen.tech>","References":"<20211228215951.32396-1-laurent.pinchart@ideasonboard.com>\n\t<20211228215951.32396-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211228215951.32396-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/5] v4l2: v4l2_compat_manager:\n\tPrint path and fd in openat()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]