[{"id":21880,"web_url":"https://patchwork.libcamera.org/comment/21880/","msgid":"<20211227083112.g4o4nuoiltj5p7nh@uno.localdomain>","date":"2021-12-27T08:31:12","subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello Johann,\n\nOn Mon, Dec 27, 2021 at 01:33:43PM +0900, Johann Koenig via libcamera-devel wrote:\n> Date: Mon, 27 Dec 2021 13:33:43 +0900\n> From: Johann Koenig \n> To: libcamera-devel@lists.libcamera.org\n> X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> Subject: [PATCH] readme: Convert tabs to spaces\n\nWeird, this shouldn't be here. If I do apply the patch these line show\nin the commit history\n\n$ git show\ncommit 833806e65611da1bbffae9aaa807d5b9dc5183f5 (HEAD)\nAuthor: Johann Koenig \nDate: Mon Dec 27 13:33:43 2021 +0900\n\n readme: Convert tabs to spaces\n\n To: libcamera-devel@lists.libcamera.org\n X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n Subject: [PATCH] readme: Convert tabs to spaces\n\n The initial commit (a146cdb) used tabs for all the dependencies. The\n first time a line was edited (2de7843/30f9624) it did not keep the\n tab. This makes them all consistent.\n\n Signed-off-by: johannkoenig@google.com\n\n\nI wonder how did it happened since it seems you've used git send-email\nand most probably generated the patch with git format-patch.\n\nAs a suggestion: we usually try to refer to commit using the\ncanonical 12-digits format. In example:\n\nThe initial commit a146cdbf20cb (\"readme: Provide build requirements\")\nused tabs for all the dependencies. The first time a line was edited\nin commit 2de78434ca71 (\"meson: Bump required version to 0.47\") tabs\nwere not kept. This makes them all consistent.\n\n>\n> The initial commit (a146cdb) used tabs for all the dependencies. The\n> first time a line was edited (2de7843/30f9624) it did not keep the\n> tab. This makes them all consistent.\n\nThis makes me wonder if we shouldn't have gone for all tabs then ?\nAnyway, consistency is what matters, so whatever is fine\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: johannkoenig@google.com\n> ---\n> README.rst | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/README.rst b/README.rst\n> index c48b4dba..05f0e6f2 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -44,7 +44,7 @@ The following Debian/Ubuntu packages are required for building libcamera.\n> Other distributions may have differing package names:\n>\n> A C++ toolchain: [required]\n> -\tEither {g++, clang}\n> + Either {g++, clang}\n>\n> Meson Build system: [required]\n> meson (>= 0.55) ninja-build pkg-config\n> @@ -78,19 +78,19 @@ for the Raspberry Pi IPA: [optional]\n> 'pipelines' option to avoid this dependency.\n>\n> for device hotplug enumeration: [optional]\n> -\tlibudev-dev\n> + libudev-dev\n>\n> for documentation: [optional]\n> -\tpython3-sphinx doxygen graphviz texlive-latex-extra\n> + python3-sphinx doxygen graphviz texlive-latex-extra\n>\n> for gstreamer: [optional]\n> -\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> + libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n>\n> for cam: [optional]\n> libevent-dev\n>\n> for qcam: [optional]\n> -\tqtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> + qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n>\n> for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n> --\n> 2.34.1.448.ga2b2bfdf31-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16F9BBF415\n\tfor ;\n\tMon, 27 Dec 2021 08:30:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D04C60912;\n\tMon, 27 Dec 2021 09:30:18 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA5B8605A8\n\tfor ;\n\tMon, 27 Dec 2021 09:30:16 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 10C72240008;\n\tMon, 27 Dec 2021 08:30:15 +0000 (UTC)"],"Date":"Mon, 27 Dec 2021 09:31:12 +0100","From":"Jacopo Mondi ","To":"Johann Koenig ","Message-ID":"<20211227083112.g4o4nuoiltj5p7nh@uno.localdomain>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21881,"web_url":"https://patchwork.libcamera.org/comment/21881/","msgid":"","date":"2021-12-27T08:55:01","subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Dec 27, 2021 at 09:31:12AM +0100, Jacopo Mondi wrote:\n> Hello Johann,\n> \n> On Mon, Dec 27, 2021 at 01:33:43PM +0900, Johann Koenig via libcamera-devel wrote:\n> > Date: Mon, 27 Dec 2021 13:33:43 +0900\n> > From: Johann Koenig \n> > To: libcamera-devel@lists.libcamera.org\n> > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > Subject: [PATCH] readme: Convert tabs to spaces\n> \n> Weird, this shouldn't be here. If I do apply the patch these line show\n> in the commit history\n> \n> $ git show\n> commit 833806e65611da1bbffae9aaa807d5b9dc5183f5 (HEAD)\n> Author: Johann Koenig \n> Date: Mon Dec 27 13:33:43 2021 +0900\n> \n> readme: Convert tabs to spaces\n> \n> To: libcamera-devel@lists.libcamera.org\n> X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> Subject: [PATCH] readme: Convert tabs to spaces\n> \n> The initial commit (a146cdb) used tabs for all the dependencies. The\n> first time a line was edited (2de7843/30f9624) it did not keep the\n> tab. This makes them all consistent.\n> \n> Signed-off-by: johannkoenig@google.com\n> \n> \n> I wonder how did it happened since it seems you've used git send-email\n> and most probably generated the patch with git format-patch.\n\nWelcome to DMARC. The google.com domain uses a strict DMARC policy that\nrequires recipients to ignore e-mails that fail DKIM and SPF tests. This\nbreaks mailing lists, so mailman has to wrap the original message in an\nRFC822 payload. It looks like `git am` has trouble coping. I don't\nrecall seeing this problem before, so I wonder if it could be a\nregression in git, but I may simply not have applied affected patches\nfrom e-mail.\n\nNote that the chromium.org domain isn't affected.\n\n> As a suggestion: we usually try to refer to commit using the\n> canonical 12-digits format. In example:\n> \n> The initial commit a146cdbf20cb (\"readme: Provide build requirements\")\n> used tabs for all the dependencies. The first time a line was edited\n> in commit 2de78434ca71 (\"meson: Bump required version to 0.47\") tabs\n> were not kept. This makes them all consistent.\n> \n> > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > first time a line was edited (2de7843/30f9624) it did not keep the\n> > tab. This makes them all consistent.\n> \n> This makes me wonder if we shouldn't have gone for all tabs then ?\n> Anyway, consistency is what matters, so whatever is fine\n\nhttps://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#whitespace\n\n\"Spaces are recommended for indentation, but tabs may also be used. Tabs\nwill be converted to spaces. Tab stops are at every 8th column\n(processing systems may make this value configurable).\"\n\nSpaces sound good then.\n\n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> > Signed-off-by: johannkoenig@google.com\n> > ---\n> > README.rst | 10 +++++-----\n> > 1 file changed, 5 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/README.rst b/README.rst\n> > index c48b4dba..05f0e6f2 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -44,7 +44,7 @@ The following Debian/Ubuntu packages are required for building libcamera.\n> > Other distributions may have differing package names:\n> >\n> > A C++ toolchain: [required]\n> > -\tEither {g++, clang}\n> > + Either {g++, clang}\n> >\n> > Meson Build system: [required]\n> > meson (>= 0.55) ninja-build pkg-config\n> > @@ -78,19 +78,19 @@ for the Raspberry Pi IPA: [optional]\n> > 'pipelines' option to avoid this dependency.\n> >\n> > for device hotplug enumeration: [optional]\n> > -\tlibudev-dev\n> > + libudev-dev\n> >\n> > for documentation: [optional]\n> > -\tpython3-sphinx doxygen graphviz texlive-latex-extra\n> > + python3-sphinx doxygen graphviz texlive-latex-extra\n> >\n> > for gstreamer: [optional]\n> > -\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > + libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> >\n> > for cam: [optional]\n> > libevent-dev\n> >\n> > for qcam: [optional]\n> > -\tqtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > + qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> >\n> > for tracing with lttng: [optional]\n> > liblttng-ust-dev python3-jinja2 lttng-tools","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8EAFBE080\n\tfor ;\n\tMon, 27 Dec 2021 08:55:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36B646090D;\n\tMon, 27 Dec 2021 09:55:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EA53605A8\n\tfor ;\n\tMon, 27 Dec 2021 09:55:05 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E80068EB;\n\tMon, 27 Dec 2021 09:55:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Twpf0Pre\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640595304;\n\tbh=NEdDEPF9Ed8J1aGgyH3XFf9ok6KYhemAaM53+26i4hk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Twpf0PreWIPUbfgJ59Yg0xSolt3+l2tgq8GcQdAKW737qNISDPhP+F4y3bQQdWDzX\n\tlJi0jm5vwKvHuv0pGQJNj0GaYiEia8lsTxS20TJKE9IqT/HzM+6DSxronXl7Kf7jpb\n\tppzNZogEUXla+5XdWlQcZI1S6lpfMEo4VZQ7cuzo=","Date":"Mon, 27 Dec 2021 10:55:01 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"\n\t<20211227083112.g4o4nuoiltj5p7nh@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211227083112.g4o4nuoiltj5p7nh@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21883,"web_url":"https://patchwork.libcamera.org/comment/21883/","msgid":"","date":"2021-12-27T08:56:40","subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Dec 27, 2021 at 10:55:02AM +0200, Laurent Pinchart wrote:\n> On Mon, Dec 27, 2021 at 09:31:12AM +0100, Jacopo Mondi wrote:\n> > On Mon, Dec 27, 2021 at 01:33:43PM +0900, Johann Koenig via libcamera-devel wrote:\n> > > Date: Mon, 27 Dec 2021 13:33:43 +0900\n> > > From: Johann Koenig \n> > > To: libcamera-devel@lists.libcamera.org\n> > > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > > Subject: [PATCH] readme: Convert tabs to spaces\n> > \n> > Weird, this shouldn't be here. If I do apply the patch these line show\n> > in the commit history\n> > \n> > $ git show\n> > commit 833806e65611da1bbffae9aaa807d5b9dc5183f5 (HEAD)\n> > Author: Johann Koenig \n> > Date: Mon Dec 27 13:33:43 2021 +0900\n> > \n> > readme: Convert tabs to spaces\n> > \n> > To: libcamera-devel@lists.libcamera.org\n> > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > Subject: [PATCH] readme: Convert tabs to spaces\n> > \n> > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > first time a line was edited (2de7843/30f9624) it did not keep the\n> > tab. This makes them all consistent.\n> > \n> > Signed-off-by: johannkoenig@google.com\n> > \n> > \n> > I wonder how did it happened since it seems you've used git send-email\n> > and most probably generated the patch with git format-patch.\n> \n> Welcome to DMARC. The google.com domain uses a strict DMARC policy that\n> requires recipients to ignore e-mails that fail DKIM and SPF tests. This\n> breaks mailing lists, so mailman has to wrap the original message in an\n> RFC822 payload. It looks like `git am` has trouble coping. I don't\n> recall seeing this problem before, so I wonder if it could be a\n> regression in git, but I may simply not have applied affected patches\n> from e-mail.\n> \n> Note that the chromium.org domain isn't affected.\n> \n> > As a suggestion: we usually try to refer to commit using the\n> > canonical 12-digits format. In example:\n> > \n> > The initial commit a146cdbf20cb (\"readme: Provide build requirements\")\n> > used tabs for all the dependencies. The first time a line was edited\n> > in commit 2de78434ca71 (\"meson: Bump required version to 0.47\") tabs\n> > were not kept. This makes them all consistent.\n> > \n> > > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > > first time a line was edited (2de7843/30f9624) it did not keep the\n> > > tab. This makes them all consistent.\n> > \n> > This makes me wonder if we shouldn't have gone for all tabs then ?\n> > Anyway, consistency is what matters, so whatever is fine\n> \n> https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#whitespace\n> \n> \"Spaces are recommended for indentation, but tabs may also be used. Tabs\n> will be converted to spaces. Tab stops are at every 8th column\n> (processing systems may make this value configurable).\"\n> \n> Spaces sound good then.\n> \n> > Reviewed-by: Jacopo Mondi \n> \n> Reviewed-by: Laurent Pinchart \n\nNo need to resend by the way, I'll update the commit message when\napplying.\n\n> > > Signed-off-by: johannkoenig@google.com\n> > > ---\n> > > README.rst | 10 +++++-----\n> > > 1 file changed, 5 insertions(+), 5 deletions(-)\n> > >\n> > > diff --git a/README.rst b/README.rst\n> > > index c48b4dba..05f0e6f2 100644\n> > > --- a/README.rst\n> > > +++ b/README.rst\n> > > @@ -44,7 +44,7 @@ The following Debian/Ubuntu packages are required for building libcamera.\n> > > Other distributions may have differing package names:\n> > >\n> > > A C++ toolchain: [required]\n> > > -\tEither {g++, clang}\n> > > + Either {g++, clang}\n> > >\n> > > Meson Build system: [required]\n> > > meson (>= 0.55) ninja-build pkg-config\n> > > @@ -78,19 +78,19 @@ for the Raspberry Pi IPA: [optional]\n> > > 'pipelines' option to avoid this dependency.\n> > >\n> > > for device hotplug enumeration: [optional]\n> > > -\tlibudev-dev\n> > > + libudev-dev\n> > >\n> > > for documentation: [optional]\n> > > -\tpython3-sphinx doxygen graphviz texlive-latex-extra\n> > > + python3-sphinx doxygen graphviz texlive-latex-extra\n> > >\n> > > for gstreamer: [optional]\n> > > -\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > > + libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > >\n> > > for cam: [optional]\n> > > libevent-dev\n> > >\n> > > for qcam: [optional]\n> > > -\tqtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > > + qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > >\n> > > for tracing with lttng: [optional]\n> > > liblttng-ust-dev python3-jinja2 lttng-tools","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0840CBE080\n\tfor ;\n\tMon, 27 Dec 2021 08:56:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B23716090D;\n\tMon, 27 Dec 2021 09:56:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 212FC605A8\n\tfor ;\n\tMon, 27 Dec 2021 09:56:43 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A84118EB;\n\tMon, 27 Dec 2021 09:56:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"unLnNpCe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640595402;\n\tbh=FV271LRKsiJoVXqMMy/lIc9l6Nlyyu05V9GbjkJeS6M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=unLnNpCeoLZmYA9c7fsB0uuREU5CzmwTVkn+NXNgjrYU0i72O5ErETLsYtg30CyjY\n\tTmASAzsBd966y5GCcbD/Vj5fMzJgu93Pyonf0/jo8bYqVZL7tE0ENgOQDvyXpdjoxx\n\tpjePUUbC09rCFFRjf3ZfuKjWwjHln+Uh/BwH4DZA=","Date":"Mon, 27 Dec 2021 10:56:40 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"\n\t<20211227083112.g4o4nuoiltj5p7nh@uno.localdomain>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21889,"web_url":"https://patchwork.libcamera.org/comment/21889/","msgid":"","date":"2021-12-27T20:18:14","subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Dec 27, 2021 at 10:56:41AM +0200, Laurent Pinchart wrote:\n> On Mon, Dec 27, 2021 at 10:55:02AM +0200, Laurent Pinchart wrote:\n> > On Mon, Dec 27, 2021 at 09:31:12AM +0100, Jacopo Mondi wrote:\n> > > On Mon, Dec 27, 2021 at 01:33:43PM +0900, Johann Koenig via libcamera-devel wrote:\n> > > > Date: Mon, 27 Dec 2021 13:33:43 +0900\n> > > > From: Johann Koenig \n> > > > To: libcamera-devel@lists.libcamera.org\n> > > > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > > > Subject: [PATCH] readme: Convert tabs to spaces\n> > > \n> > > Weird, this shouldn't be here. If I do apply the patch these line show\n> > > in the commit history\n> > > \n> > > $ git show\n> > > commit 833806e65611da1bbffae9aaa807d5b9dc5183f5 (HEAD)\n> > > Author: Johann Koenig \n> > > Date: Mon Dec 27 13:33:43 2021 +0900\n> > > \n> > > readme: Convert tabs to spaces\n> > > \n> > > To: libcamera-devel@lists.libcamera.org\n> > > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > > Subject: [PATCH] readme: Convert tabs to spaces\n> > > \n> > > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > > first time a line was edited (2de7843/30f9624) it did not keep the\n> > > tab. This makes them all consistent.\n> > > \n> > > Signed-off-by: johannkoenig@google.com\n\nAnother comment, this should be\n\nSigned-off-by: Johann Koenig \n\ngit config --global user.name \"Johann Koenig\"\n\nwill help for future patches.\n\nI'll also fix it when pushing the patch.\n\n> > > I wonder how did it happened since it seems you've used git send-email\n> > > and most probably generated the patch with git format-patch.\n> > \n> > Welcome to DMARC. The google.com domain uses a strict DMARC policy that\n> > requires recipients to ignore e-mails that fail DKIM and SPF tests. This\n> > breaks mailing lists, so mailman has to wrap the original message in an\n> > RFC822 payload. It looks like `git am` has trouble coping. I don't\n> > recall seeing this problem before, so I wonder if it could be a\n> > regression in git, but I may simply not have applied affected patches\n> > from e-mail.\n> > \n> > Note that the chromium.org domain isn't affected.\n> > \n> > > As a suggestion: we usually try to refer to commit using the\n> > > canonical 12-digits format. In example:\n> > > \n> > > The initial commit a146cdbf20cb (\"readme: Provide build requirements\")\n> > > used tabs for all the dependencies. The first time a line was edited\n> > > in commit 2de78434ca71 (\"meson: Bump required version to 0.47\") tabs\n> > > were not kept. This makes them all consistent.\n> > > \n> > > > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > > > first time a line was edited (2de7843/30f9624) it did not keep the\n> > > > tab. This makes them all consistent.\n> > > \n> > > This makes me wonder if we shouldn't have gone for all tabs then ?\n> > > Anyway, consistency is what matters, so whatever is fine\n> > \n> > https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#whitespace\n> > \n> > \"Spaces are recommended for indentation, but tabs may also be used. Tabs\n> > will be converted to spaces. Tab stops are at every 8th column\n> > (processing systems may make this value configurable).\"\n> > \n> > Spaces sound good then.\n> > \n> > > Reviewed-by: Jacopo Mondi \n> > \n> > Reviewed-by: Laurent Pinchart \n> \n> No need to resend by the way, I'll update the commit message when\n> applying.\n> \n> > > > Signed-off-by: johannkoenig@google.com\n> > > > ---\n> > > > README.rst | 10 +++++-----\n> > > > 1 file changed, 5 insertions(+), 5 deletions(-)\n> > > >\n> > > > diff --git a/README.rst b/README.rst\n> > > > index c48b4dba..05f0e6f2 100644\n> > > > --- a/README.rst\n> > > > +++ b/README.rst\n> > > > @@ -44,7 +44,7 @@ The following Debian/Ubuntu packages are required for building libcamera.\n> > > > Other distributions may have differing package names:\n> > > >\n> > > > A C++ toolchain: [required]\n> > > > -\tEither {g++, clang}\n> > > > + Either {g++, clang}\n> > > >\n> > > > Meson Build system: [required]\n> > > > meson (>= 0.55) ninja-build pkg-config\n> > > > @@ -78,19 +78,19 @@ for the Raspberry Pi IPA: [optional]\n> > > > 'pipelines' option to avoid this dependency.\n> > > >\n> > > > for device hotplug enumeration: [optional]\n> > > > -\tlibudev-dev\n> > > > + libudev-dev\n> > > >\n> > > > for documentation: [optional]\n> > > > -\tpython3-sphinx doxygen graphviz texlive-latex-extra\n> > > > + python3-sphinx doxygen graphviz texlive-latex-extra\n> > > >\n> > > > for gstreamer: [optional]\n> > > > -\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > > > + libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > > >\n> > > > for cam: [optional]\n> > > > libevent-dev\n> > > >\n> > > > for qcam: [optional]\n> > > > -\tqtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > > > + qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > > >\n> > > > for tracing with lttng: [optional]\n> > > > liblttng-ust-dev python3-jinja2 lttng-tools","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E892BE080\n\tfor ;\n\tMon, 27 Dec 2021 20:18:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 607086090D;\n\tMon, 27 Dec 2021 21:18:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9574F60115\n\tfor ;\n\tMon, 27 Dec 2021 21:18:17 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0485971;\n\tMon, 27 Dec 2021 21:18:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"itKRXWgE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640636297;\n\tbh=RbN0gq5ew2M2Gw/7lxj7yNX0xVhsf2Kk93nzH35jrm8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=itKRXWgEGnMNYNqdlhQUzaPgVyqTYqlV+xR0d4Ry98sMhzV2bMNesMrwm5zKQkIZT\n\tXAf61IGdv3VnBCEEQg3dDgZuJbUpjNv7CT+3bp80JpwPd+VDAQLiAV8dZ+ENO/5KIe\n\tVxpwJyAAJ+DifOKW6niQI3u6gs21j8atRuYQSbwE=","Date":"Mon, 27 Dec 2021 22:18:14 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"\n\t<20211227083112.g4o4nuoiltj5p7nh@uno.localdomain>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21890,"web_url":"https://patchwork.libcamera.org/comment/21890/","msgid":"","date":"2021-12-28T02:51:40","subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Apologies for the mess! I'm trying to figure out the submission process\nso I wanted to send an easy patch to test.\n\nOn Mon, Dec 27, 2021 at 10:18:14PM +0200, Laurent Pinchart wrote:\n> On Mon, Dec 27, 2021 at 10:56:41AM +0200, Laurent Pinchart wrote:\n> > On Mon, Dec 27, 2021 at 10:55:02AM +0200, Laurent Pinchart wrote:\n> > > On Mon, Dec 27, 2021 at 09:31:12AM +0100, Jacopo Mondi wrote:\n> > > > On Mon, Dec 27, 2021 at 01:33:43PM +0900, Johann Koenig via libcamera-devel wrote:\n> > > > > Date: Mon, 27 Dec 2021 13:33:43 +0900\n> > > > > From: Johann Koenig \n> > > > > To: libcamera-devel@lists.libcamera.org\n> > > > > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > > > > Subject: [PATCH] readme: Convert tabs to spaces\n> > > > \n> > > > Weird, this shouldn't be here. If I do apply the patch these line show\n> > > > in the commit history\n> > > > \n> > > > $ git show\n> > > > commit 833806e65611da1bbffae9aaa807d5b9dc5183f5 (HEAD)\n> > > > Author: Johann Koenig \n> > > > Date: Mon Dec 27 13:33:43 2021 +0900\n> > > > \n> > > > readme: Convert tabs to spaces\n> > > > \n> > > > To: libcamera-devel@lists.libcamera.org\n> > > > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > > > Subject: [PATCH] readme: Convert tabs to spaces\n> > > > \n> > > > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > > > first time a line was edited (2de7843/30f9624) it did not keep the\n> > > > tab. This makes them all consistent.\n> > > > \n> > > > Signed-off-by: johannkoenig@google.com\n> \n> Another comment, this should be\n> \n> Signed-off-by: Johann Koenig \n> \n> git config --global user.name \"Johann Koenig\"\n> \n> will help for future patches.\n> \n> I'll also fix it when pushing the patch.\n\nThanks! I had manually written that. Just enabled\n.git/hooks/prepare-commit-msg to automate it.\n\n> > > > I wonder how did it happened since it seems you've used git send-email\n> > > > and most probably generated the patch with git format-patch.\n\nEven simpler: git send-email HEAD~1.\n\n> > > Welcome to DMARC. The google.com domain uses a strict DMARC policy that\n> > > requires recipients to ignore e-mails that fail DKIM and SPF tests. This\n> > > breaks mailing lists, so mailman has to wrap the original message in an\n> > > RFC822 payload. It looks like `git am` has trouble coping. I don't\n> > > recall seeing this problem before, so I wonder if it could be a\n> > > regression in git, but I may simply not have applied affected patches\n> > > from e-mail.\n> > > \n> > > Note that the chromium.org domain isn't affected.\n\nThanks for the explanation. I'll look into it a little further and if I\ndon't see a way to fix it I can switch to @chromium.org.\n\n> > > > As a suggestion: we usually try to refer to commit using the\n> > > > canonical 12-digits format. In example:\n> > > > \n> > > > The initial commit a146cdbf20cb (\"readme: Provide build requirements\")\n> > > > used tabs for all the dependencies. The first time a line was edited\n> > > > in commit 2de78434ca71 (\"meson: Bump required version to 0.47\") tabs\n> > > > were not kept. This makes them all consistent.\n\nThanks! Will keep that in mind for the next time.\n\n> > > > > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > > > > first time a line was edited (2de7843/30f9624) it did not keep the\n> > > > > tab. This makes them all consistent.\n> > > > \n> > > > This makes me wonder if we shouldn't have gone for all tabs then ?\n> > > > Anyway, consistency is what matters, so whatever is fine\n> > > \n> > > https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#whitespace\n> > > \n> > > \"Spaces are recommended for indentation, but tabs may also be used. Tabs\n> > > will be converted to spaces. Tab stops are at every 8th column\n> > > (processing systems may make this value configurable).\"\n> > > \n> > > Spaces sound good then.\n\nI only noticed this because my editor is set to highlight tabs in red.\nI'm happy to use tabs if they are preferred or predominant.\n\n> > > > Reviewed-by: Jacopo Mondi \n> > > \n> > > Reviewed-by: Laurent Pinchart \n> > \n> > No need to resend by the way, I'll update the commit message when\n> > applying.\n\nThanks!\n\n> > > > > Signed-off-by: johannkoenig@google.com\n> > > > > ---\n> > > > > README.rst | 10 +++++-----\n> > > > > 1 file changed, 5 insertions(+), 5 deletions(-)\n> > > > >\n> > > > > diff --git a/README.rst b/README.rst\n> > > > > index c48b4dba..05f0e6f2 100644\n> > > > > --- a/README.rst\n> > > > > +++ b/README.rst\n> > > > > @@ -44,7 +44,7 @@ The following Debian/Ubuntu packages are required for building libcamera.\n> > > > > Other distributions may have differing package names:\n> > > > >\n> > > > > A C++ toolchain: [required]\n> > > > > -\tEither {g++, clang}\n> > > > > + Either {g++, clang}\n> > > > >\n> > > > > Meson Build system: [required]\n> > > > > meson (>= 0.55) ninja-build pkg-config\n> > > > > @@ -78,19 +78,19 @@ for the Raspberry Pi IPA: [optional]\n> > > > > 'pipelines' option to avoid this dependency.\n> > > > >\n> > > > > for device hotplug enumeration: [optional]\n> > > > > -\tlibudev-dev\n> > > > > + libudev-dev\n> > > > >\n> > > > > for documentation: [optional]\n> > > > > -\tpython3-sphinx doxygen graphviz texlive-latex-extra\n> > > > > + python3-sphinx doxygen graphviz texlive-latex-extra\n> > > > >\n> > > > > for gstreamer: [optional]\n> > > > > -\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > > > > + libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > > > >\n> > > > > for cam: [optional]\n> > > > > libevent-dev\n> > > > >\n> > > > > for qcam: [optional]\n> > > > > -\tqtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > > > > + qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > > > >\n> > > > > for tracing with lttng: [optional]\n> > > > > liblttng-ust-dev python3-jinja2 lttng-tools\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5014EBE080\n\tfor ;\n\tTue, 28 Dec 2021 02:51:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4111A608EB;\n\tTue, 28 Dec 2021 03:51:54 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1640659914;\n\tbh=wWtUbiemRUG6UiSWlleL7UBaSZsds0Z/piJmfa2bTYU=;\n\th=Date:To:References:In-Reply-To:List-Id:List-Post:From:Cc:\n\tList-Subscribe:List-Unsubscribe:List-Archive:Reply-To:List-Help:\n\tSubject:From;\n\tb=XoyYF9PS6w2VRYKfRegvbupBf39X64NmcBZxwEJ3UpRmvDMi3+XWyB3PbE+UOPuZT\n\tzfv8GG/AJA5t//pwdt59X6eqvYRyEuCekE5ZC7Dp4kBi47lmFeYPhLi40CSNbSCCMW\n\tjWtzYjonBfiVc2pDZHn10/Ypz3myEC6ZdVBQcqcr93ntxMKK8dq4PJF6CYuJCqg4PT\n\tJto1+mg/cE84Kt4ZmIW5guqZlMYS3gYutxk9zoxB2Vj2KnXn4v5oKs3G8/wNYM1cGv\n\tC1P4cufA0fOFoURlt4Wm2pQxpEWneJDJvZFIxQqTkEcNJlbWyYwbU9um/+D0vix6CE\n\tTLn14jmClSZ/w==","Date":"Tue, 28 Dec 2021 11:51:40 +0900","To":"Laurent Pinchart ","References":"\n\t<20211227083112.g4o4nuoiltj5p7nh@uno.localdomain>\n\t\n\t\n\t","In-Reply-To":"","MIME-Version":"1.0","Message-ID":"","List-Id":"","List-Post":"","From":"Johann Koenig via libcamera-devel ","Precedence":"list","Cc":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","X-BeenThere":"libcamera-devel@lists.libcamera.org","List-Subscribe":",\n\t","List-Unsubscribe":",\n\t","List-Archive":"","Reply-To":"Johann Koenig ","List-Help":"","Subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","Content-Type":"message/rfc822","Content-Disposition":"inline","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21891,"web_url":"https://patchwork.libcamera.org/comment/21891/","msgid":"","date":"2021-12-28T08:00:28","subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Johann,\n\nOn Tue, Dec 28, 2021 at 11:51:40AM +0900, Johann Koenig wrote:\n> Apologies for the mess! I'm trying to figure out the submission process\n> so I wanted to send an easy patch to test.\n\nNo need to apologize :-)\n\n> On Mon, Dec 27, 2021 at 10:18:14PM +0200, Laurent Pinchart wrote:\n> > On Mon, Dec 27, 2021 at 10:56:41AM +0200, Laurent Pinchart wrote:\n> > > On Mon, Dec 27, 2021 at 10:55:02AM +0200, Laurent Pinchart wrote:\n> > > > On Mon, Dec 27, 2021 at 09:31:12AM +0100, Jacopo Mondi wrote:\n> > > > > On Mon, Dec 27, 2021 at 01:33:43PM +0900, Johann Koenig via libcamera-devel wrote:\n> > > > > > Date: Mon, 27 Dec 2021 13:33:43 +0900\n> > > > > > From: Johann Koenig \n> > > > > > To: libcamera-devel@lists.libcamera.org\n> > > > > > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > > > > > Subject: [PATCH] readme: Convert tabs to spaces\n> > > > > \n> > > > > Weird, this shouldn't be here. If I do apply the patch these line show\n> > > > > in the commit history\n> > > > > \n> > > > > $ git show\n> > > > > commit 833806e65611da1bbffae9aaa807d5b9dc5183f5 (HEAD)\n> > > > > Author: Johann Koenig \n> > > > > Date: Mon Dec 27 13:33:43 2021 +0900\n> > > > > \n> > > > > readme: Convert tabs to spaces\n> > > > > \n> > > > > To: libcamera-devel@lists.libcamera.org\n> > > > > X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog\n> > > > > Subject: [PATCH] readme: Convert tabs to spaces\n> > > > > \n> > > > > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > > > > first time a line was edited (2de7843/30f9624) it did not keep the\n> > > > > tab. This makes them all consistent.\n> > > > > \n> > > > > Signed-off-by: johannkoenig@google.com\n> > \n> > Another comment, this should be\n> > \n> > Signed-off-by: Johann Koenig \n> > \n> > git config --global user.name \"Johann Koenig\"\n> > \n> > will help for future patches.\n> > \n> > I'll also fix it when pushing the patch.\n> \n> Thanks! I had manually written that. Just enabled\n> .git/hooks/prepare-commit-msg to automate it.\n\nYou can also just use `git commit -s`.\n\n> > > > > I wonder how did it happened since it seems you've used git send-email\n> > > > > and most probably generated the patch with git format-patch.\n> \n> Even simpler: git send-email HEAD~1.\n> \n> > > > Welcome to DMARC. The google.com domain uses a strict DMARC policy that\n> > > > requires recipients to ignore e-mails that fail DKIM and SPF tests. This\n> > > > breaks mailing lists, so mailman has to wrap the original message in an\n> > > > RFC822 payload. It looks like `git am` has trouble coping. I don't\n> > > > recall seeing this problem before, so I wonder if it could be a\n> > > > regression in git, but I may simply not have applied affected patches\n> > > > from e-mail.\n> > > > \n> > > > Note that the chromium.org domain isn't affected.\n> \n> Thanks for the explanation. I'll look into it a little further and if I\n> don't see a way to fix it I can switch to @chromium.org.\n\nI don't think there's a solution with @google.com. It's not a huge deal\nthough, but it reminds me I need to update my patch apply scripts to\nsupport this properly (or fix `git am`).\n\n> > > > > As a suggestion: we usually try to refer to commit using the\n> > > > > canonical 12-digits format. In example:\n> > > > > \n> > > > > The initial commit a146cdbf20cb (\"readme: Provide build requirements\")\n> > > > > used tabs for all the dependencies. The first time a line was edited\n> > > > > in commit 2de78434ca71 (\"meson: Bump required version to 0.47\") tabs\n> > > > > were not kept. This makes them all consistent.\n> \n> Thanks! Will keep that in mind for the next time.\n> \n> > > > > > The initial commit (a146cdb) used tabs for all the dependencies. The\n> > > > > > first time a line was edited (2de7843/30f9624) it did not keep the\n> > > > > > tab. This makes them all consistent.\n> > > > > \n> > > > > This makes me wonder if we shouldn't have gone for all tabs then ?\n> > > > > Anyway, consistency is what matters, so whatever is fine\n> > > > \n> > > > https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#whitespace\n> > > > \n> > > > \"Spaces are recommended for indentation, but tabs may also be used. Tabs\n> > > > will be converted to spaces. Tab stops are at every 8th column\n> > > > (processing systems may make this value configurable).\"\n> > > > \n> > > > Spaces sound good then.\n> \n> I only noticed this because my editor is set to highlight tabs in red.\n> I'm happy to use tabs if they are preferred or predominant.\n> \n> > > > > Reviewed-by: Jacopo Mondi \n> > > > \n> > > > Reviewed-by: Laurent Pinchart \n> > > \n> > > No need to resend by the way, I'll update the commit message when\n> > > applying.\n> \n> Thanks!\n> \n> > > > > > Signed-off-by: johannkoenig@google.com\n> > > > > > ---\n> > > > > > README.rst | 10 +++++-----\n> > > > > > 1 file changed, 5 insertions(+), 5 deletions(-)\n> > > > > >\n> > > > > > diff --git a/README.rst b/README.rst\n> > > > > > index c48b4dba..05f0e6f2 100644\n> > > > > > --- a/README.rst\n> > > > > > +++ b/README.rst\n> > > > > > @@ -44,7 +44,7 @@ The following Debian/Ubuntu packages are required for building libcamera.\n> > > > > > Other distributions may have differing package names:\n> > > > > >\n> > > > > > A C++ toolchain: [required]\n> > > > > > -\tEither {g++, clang}\n> > > > > > + Either {g++, clang}\n> > > > > >\n> > > > > > Meson Build system: [required]\n> > > > > > meson (>= 0.55) ninja-build pkg-config\n> > > > > > @@ -78,19 +78,19 @@ for the Raspberry Pi IPA: [optional]\n> > > > > > 'pipelines' option to avoid this dependency.\n> > > > > >\n> > > > > > for device hotplug enumeration: [optional]\n> > > > > > -\tlibudev-dev\n> > > > > > + libudev-dev\n> > > > > >\n> > > > > > for documentation: [optional]\n> > > > > > -\tpython3-sphinx doxygen graphviz texlive-latex-extra\n> > > > > > + python3-sphinx doxygen graphviz texlive-latex-extra\n> > > > > >\n> > > > > > for gstreamer: [optional]\n> > > > > > -\tlibgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > > > > > + libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev\n> > > > > >\n> > > > > > for cam: [optional]\n> > > > > > libevent-dev\n> > > > > >\n> > > > > > for qcam: [optional]\n> > > > > > -\tqtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > > > > > + qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev\n> > > > > >\n> > > > > > for tracing with lttng: [optional]\n> > > > > > liblttng-ust-dev python3-jinja2 lttng-tools","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C542BF415\n\tfor ;\n\tTue, 28 Dec 2021 08:00:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55332608EB;\n\tTue, 28 Dec 2021 09:00:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D2D1604F8\n\tfor ;\n\tTue, 28 Dec 2021 09:00:32 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AC413E7;\n\tTue, 28 Dec 2021 09:00:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZX4IV1d/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640678431;\n\tbh=zijN9Eng3aPoXowd7HRbgKBUfW6VDjTMEwRim6UTdNM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZX4IV1d/A41bDKav9zdMRxRldjsV2sJ0TZclN4Jqir2nwauskaZ8dm3wAjIZwdN1i\n\tDPWaskcd8ipqlEHtcnuhmqPa+K4d+RJbnI6RaQNWtl+PfRNdPhwrjMhzJYiv1JGL7S\n\tKHp+uxYIJCajtJNHwnfFeMM1rC1sJiw3h4qnfFEI=","Date":"Tue, 28 Dec 2021 10:00:28 +0200","From":"Laurent Pinchart ","To":"Johann Koenig ","Message-ID":"","References":"\n\t<20211227083112.g4o4nuoiltj5p7nh@uno.localdomain>\n\t\n\t\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] readme: Convert tabs to spaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]