[{"id":21857,"web_url":"https://patchwork.libcamera.org/comment/21857/","msgid":"","date":"2021-12-21T17:04:12","subject":"Re: [libcamera-devel] [PATCH v3] meson: reduce required version to\n\t0.53","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Dec 21, 2021 at 04:47:31PM +0000, Kieran Bingham wrote:\n> From: Christian Rauch \n> \n> Building the libcamera Android layer currently makes use of features\n> from meson 0.55. The core libcamera framework in the default configuration\n> without android enabled uses the 'summary' feature available in 0.53, and\n> is the lowest supportable meson version if the Android HAL is excluded.\n> \n> Ubuntu 20.04 LTS currently provides meson 0.53 and represents an\n> acceptable minimum version to support. Platforms utilising the Android\n> component will have full control over their build environment and can\n> ensure that they provide a more recent version of meson.\n> \n> Reduce the supported meson version for the project to 0.53 to facilitate\n> building on more distributions without having to manually update the\n> meson package.\n\nI'd add\n\nmeson will output a warning that features not available in 0.53 are used\nif the Android HAL is enabled. This is considered as an acceptable\nmiddleground to improve the experience on the latest Ubuntu LTS, until\n22.04 LTS is released and provides a newer meson version.\n\n> Signed-off-by: Christian Rauch \n> [Kieran: Add comment about the android meson requirements]\n> Signed-off-by: Kieran Bingham \n> ---\n> meson.build | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson.build b/meson.build\n> index a20cc29e3749..b8f2f254dcbb 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,7 +1,8 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> project('libcamera', 'c', 'cpp',\n> - meson_version : '>= 0.55',\n> + # Use of the Android component requires meson 0.55\n\nLikewise,\n\n # Use of the Android component requires meson 0.55, but Ubuntu 20.04 LTS\n # ships meson 0.53. Improve the Ubuntu experience at the expense of Android\n # as the former is a much more common use case than the latter at this\n # point. This should be fixed after Ubuntu releases 22.04 LTS.\n\nReviewed-by: Laurent Pinchart \n\n> + meson_version : '>= 0.53',\n> version : '0.0.0',\n> default_options : [\n> 'werror=true',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3761BF415\n\tfor ;\n\tTue, 21 Dec 2021 17:04:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 077CB608F9;\n\tTue, 21 Dec 2021 18:04:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 575F3605A8\n\tfor ;\n\tTue, 21 Dec 2021 18:04:16 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BECCA881;\n\tTue, 21 Dec 2021 18:04:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eMM3uzE4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640106256;\n\tbh=aWpAye33XQGBMXm9NfJjsOcXeAYJn8XjWaNUS5cEp6c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eMM3uzE41Htj+WpcVP8rb/0urJuOpvi7gEzxol/VXM/8pF8HfHoy8b3yMgaDK97rV\n\tqd3Bcxw7Vgi7tlSV10tm8lkm9fmSLdxqX9PXL7I+xs6/wyI9WltbxLwBfvG7HG7F3n\n\tuTvJwjqT2igj5P1wAowt9ti9xo2Ht1h7okifDvVo=","Date":"Tue, 21 Dec 2021 19:04:12 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211221164731.4113889-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211221164731.4113889-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3] meson: reduce required version to\n\t0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21858,"web_url":"https://patchwork.libcamera.org/comment/21858/","msgid":"<164010729163.2512616.10886727926892753661@Monstersaurus>","date":"2021-12-21T17:21:31","subject":"Re: [libcamera-devel] [PATCH v3] meson: reduce required version to\n\t0.53","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-12-21 17:04:12)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Dec 21, 2021 at 04:47:31PM +0000, Kieran Bingham wrote:\n> > From: Christian Rauch \n> > \n> > Building the libcamera Android layer currently makes use of features\n> > from meson 0.55. The core libcamera framework in the default configuration\n> > without android enabled uses the 'summary' feature available in 0.53, and\n> > is the lowest supportable meson version if the Android HAL is excluded.\n> > \n> > Ubuntu 20.04 LTS currently provides meson 0.53 and represents an\n> > acceptable minimum version to support. Platforms utilising the Android\n> > component will have full control over their build environment and can\n> > ensure that they provide a more recent version of meson.\n> > \n> > Reduce the supported meson version for the project to 0.53 to facilitate\n> > building on more distributions without having to manually update the\n> > meson package.\n> \n> I'd add\n> \n> meson will output a warning that features not available in 0.53 are used\n> if the Android HAL is enabled. This is considered as an acceptable\n> middleground to improve the experience on the latest Ubuntu LTS, until\n> 22.04 LTS is released and provides a newer meson version.\n> \n> > Signed-off-by: Christian Rauch \n> > [Kieran: Add comment about the android meson requirements]\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > meson.build | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index a20cc29e3749..b8f2f254dcbb 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -1,7 +1,8 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> > \n> > project('libcamera', 'c', 'cpp',\n> > - meson_version : '>= 0.55',\n> > + # Use of the Android component requires meson 0.55\n> \n> Likewise,\n> \n> # Use of the Android component requires meson 0.55, but Ubuntu 20.04 LTS\n> # ships meson 0.53. Improve the Ubuntu experience at the expense of Android\n> # as the former is a much more common use case than the latter at this\n> # point. This should be fixed after Ubuntu releases 22.04 LTS.\n> \n> Reviewed-by: Laurent Pinchart \n\nSure, I can add all that while applying.\n\nI wondered if we shouldn't make this all about Ubuntu, but Debian stable\nhas meson 0.56, so it probably is just Ubuntu being behind everyone\nelse.\n\n> > + meson_version : '>= 0.53',\n> > version : '0.0.0',\n> > default_options : [\n> > 'werror=true',\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13B30BE080\n\tfor ;\n\tTue, 21 Dec 2021 17:21:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20DE160900;\n\tTue, 21 Dec 2021 18:21:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A4DB605A8\n\tfor ;\n\tTue, 21 Dec 2021 18:21:34 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8E93881;\n\tTue, 21 Dec 2021 18:21:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f9kB2RE7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640107293;\n\tbh=2a5Lgk9TNEDeLsPWVv7xaFZiKU2SRYrAvIFR8c7+hbQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=f9kB2RE7lJRgOj2GbONxXKZM6CxmcG1Fgc6qjNYJxOUC8Mb77cAOJ/JO9vSz7kF05\n\tD4dlopU5vUa44yCwmuUkUjERCR6Xi/UGBsP/PlGzARapgJWb+fYCN9zKEMRyWgiJ/x\n\tTRjGW3tAmlQHJnVkwy333SM1stGDHpO+2KhtSvW8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211221164731.4113889-1-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","To":"Laurent Pinchart ","Date":"Tue, 21 Dec 2021 17:21:31 +0000","Message-ID":"<164010729163.2512616.10886727926892753661@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3] meson: reduce required version to\n\t0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]