{"id":15204,"url":"https://patchwork.libcamera.org/api/patches/15204/?format=json","web_url":"https://patchwork.libcamera.org/patch/15204/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211221053304.2704780-2-paul.elder@ideasonboard.com>","date":"2021-12-21T05:33:03","name":"[libcamera-devel,1/2] controls: Add HotPixelMode","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"0fc80c28d01dda8e3c48e0af88a65b2ad125b07b","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15204/mbox/","series":[{"id":2857,"url":"https://patchwork.libcamera.org/api/series/2857/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2857","date":"2021-12-21T05:33:03","name":"android: Hot pixel correction","version":1,"mbox":"https://patchwork.libcamera.org/series/2857/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15204/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15204/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 846A3BE080\n\tfor ;\n\tTue, 21 Dec 2021 05:33:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A104060901;\n\tTue, 21 Dec 2021 06:33:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30CF0608EB\n\tfor ;\n\tTue, 21 Dec 2021 06:33:13 +0100 (CET)","from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62401FD2;\n\tTue, 21 Dec 2021 06:33:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WgZUsAjz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640064792;\n\tbh=Gj3hqLPq6Vs1gN+PjmFsLy+0u9LQ00ZI2D5o3wqKPu0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WgZUsAjzUieTxRG+O90mGCCUimNMtatzuFvKEs0wwr2XTpgbeHY6LJhnpFc5IvuLS\n\ta5JpZnWqsutRBHjop2+7Bl4l+yT5ofqHdclDVVSwypBlk3zafpB68KhoQvS3SDxUcV\n\tr9ZPkmlasBoZAyZ2jRdOioy+1Lcfj0r0sPcKb6hI=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Dec 2021 23:33:03 -0600","Message-Id":"<20211221053304.2704780-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20211221053304.2704780-1-paul.elder@ideasonboard.com>","References":"<20211221053304.2704780-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] controls: Add HotPixelMode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a control for setting and reporting the operating mode for hot pixel\ncorrection.\n\nSigned-off-by: Paul Elder \n---\n src/libcamera/control_ids.yaml | 28 ++++++++++++++++++++++++++++\n 1 file changed, 28 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 411200a8..44f785e2 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -925,6 +925,34 @@ controls:\n value: 3\n description: The AWB algorithm is locked.\n \n+ - HotPixelMode:\n+ type: int32_t\n+ draft: true\n+ description: |\n+ Control to set and report the operation mode for hot pixel correction.\n+\n+ Hot pixel correction interpolates out, or otherwise removes, pixels\n+ that do not accurately measure the incoming light (i.e. pixels that are\n+ stuck at an arbitrary value or are oversensitive).\n+\n+ \\todo Return the hot pixel map.\n+ enum:\n+ - name: HotPixelModeOff\n+ value: 0\n+ description: |\n+ No hot pixel correction is applied. The frame rate must not be\n+ reduced relative to sensor raw output.\n+ - name: HotPixelModeFast\n+ value: 1\n+ description: |\n+ Hot pixel correction is applied, without reducing frame rate\n+ relative to sensor raw output.\n+ - name: HotPixelModeHighQuality\n+ value: 2\n+ description: |\n+ Hot pixel correction is applied, at a cost of possibly reduced\n+ frame rate relative to sensor raw output.\n+\n - SensorRollingShutterSkew:\n type: int64_t\n draft: true\n","prefixes":["libcamera-devel","1/2"]}