{"id":1520,"url":"https://patchwork.libcamera.org/api/patches/1520/?format=json","web_url":"https://patchwork.libcamera.org/patch/1520/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190625170917.17818-2-laurent.pinchart@ideasonboard.com>","date":"2019-06-25T17:09:17","name":"[libcamera-devel,2/2] utils: checkstyle.py: Add meson.build checker","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8b1f8999dbc0f3f9a663f4ef514d3d17f0ec0ee2","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1520/mbox/","series":[{"id":375,"url":"https://patchwork.libcamera.org/api/series/375/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=375","date":"2019-06-25T17:09:16","name":"[libcamera-devel,1/2] utils: checkstyle.py: Refactor formatters and checkers support","version":1,"mbox":"https://patchwork.libcamera.org/series/375/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1520/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1520/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 784EC60103\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jun 2019 19:09:40 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2334C578\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jun 2019 19:09:40 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1561482580;\n\tbh=hwfx+z+6B9pAZabSL+5vTQQT/RIRaERL+vlReBMYCWY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=lXwEWqCZMSg9hq6YTJFEGwzA9CTwcQQcxwO5UvtwnDIc4GNmIbAfXrhnm3Xf8EXK6\n\t6HDUGcKQgI8caPfrnC9yq7EClKxvAkv2g8QKNi7amgBEDCDT1vILNSiu8myocraJf4\n\tzRHLW6/ajko57PoTSSdzhw3XzlcA4oAjf/Rjh3vA=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 25 Jun 2019 20:09:17 +0300","Message-Id":"<20190625170917.17818-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190625170917.17818-1-laurent.pinchart@ideasonboard.com>","References":"<20190625170917.17818-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] utils: checkstyle.py: Add meson.build\n\tchecker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 25 Jun 2019 17:09:40 -0000"},"content":"Add a meson.build checker that warns when tabs are used.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/checkstyle.py | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 5c8bde6e1f46..bc631d405007 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -260,6 +260,22 @@ class LogCategoryChecker(StyleChecker):\n         return issues\n \n \n+class MesonChecker(StyleChecker):\n+    patterns = ('meson.build',)\n+\n+    def __init__(self, content):\n+        super().__init__()\n+        self.__content = content\n+\n+    def check(self, line_numbers):\n+        issues = []\n+        for line_number in line_numbers:\n+            line = self.__content[line_number-1]\n+            if line.find('\\t') != -1:\n+                issues.append(StyleIssue(line_number, line, 'meson.build should use spaces for indentation'))\n+        return issues\n+\n+\n # ------------------------------------------------------------------------------\n # Formatters\n #\n","prefixes":["libcamera-devel","2/2"]}