{"id":15197,"url":"https://patchwork.libcamera.org/api/patches/15197/?format=json","web_url":"https://patchwork.libcamera.org/patch/15197/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211221052117.2665228-4-paul.elder@ideasonboard.com>","date":"2021-12-21T05:21:16","name":"[libcamera-devel,3/3] android: capabilities: Add static black levels","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"d5f3c0f11aa3697b7886dbfeb6df7120e1ea6553","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15197/mbox/","series":[{"id":2854,"url":"https://patchwork.libcamera.org/api/series/2854/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2854","date":"2021-12-21T05:21:13","name":"android: Plumb static black levels","version":1,"mbox":"https://patchwork.libcamera.org/series/2854/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15197/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15197/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 136D2BE080\n\tfor ;\n\tTue, 21 Dec 2021 05:21:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1F4A608ED;\n\tTue, 21 Dec 2021 06:21:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2FD4608A2\n\tfor ;\n\tTue, 21 Dec 2021 06:21:39 +0100 (CET)","from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D98D101E;\n\tTue, 21 Dec 2021 06:21:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dlgn4tlV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640064099;\n\tbh=uBFR11xKqXOmJgRca5o3ENHlVxF4uUpFvAtKkooXDh0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Dlgn4tlVVJgTl3uB/FzcsqT+mkd5wPsviHNZl/m7hYvVr1oLcmJ9IGvhbzSHtgK7l\n\tT6bbPcsxfjKZgFlOLKvalO29UKP0gpcni2egoDdFb3tkNo7gsjFzS92D7vcSuZ9WMy\n\tQy4e1SFPmict//QJRpfYCJpv2qdVDrfWN5p5NdrA=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Dec 2021 23:21:16 -0600","Message-Id":"<20211221052117.2665228-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20211221052117.2665228-1-paul.elder@ideasonboard.com>","References":"<20211221052117.2665228-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/3] android: capabilities: Add static\n\tblack levels","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Plumb SENSOR_BLACK_LEVEL_PATTERN into the static metadata. Get the\ninformation from the sensor database.\n\nNote that nothing is added to the capability detector, as black level\npattern will always be added to the static metadata. Add a comment to\ndocument it.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=48\nSigned-off-by: Paul Elder \n---\n src/android/camera_capabilities.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex bc62a928..c716f4bf 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1342,6 +1342,16 @@ int CameraCapabilities::initializeStaticMetadata()\n \t\t\t\t whiteLevel);\n \tavailableCharacteristicsKeys_.insert(ANDROID_SENSOR_INFO_WHITE_LEVEL);\n \n+\t/* This is required for FULL. */\n+\tstd::vector blackLevels = { 0, 0, 0, 0 };\n+\tif (properties.contains(properties::SensorFixedBlackLevels)) {\n+\t\tconst Span &vals =\n+\t\t\tproperties.get(properties::SensorFixedBlackLevels);\n+\t\tblackLevels = std::vector(vals.begin(), vals.end());\n+\t}\n+\tstaticMetadata_->addEntry(ANDROID_SENSOR_BLACK_LEVEL_PATTERN, blackLevels);\n+\tavailableCharacteristicsKeys_.insert(ANDROID_SENSOR_BLACK_LEVEL_PATTERN);\n+\n \t/* Statistics static metadata. */\n \tuint8_t faceDetectMode = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\n \tstaticMetadata_->addEntry(ANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n","prefixes":["libcamera-devel","3/3"]}