[{"id":21851,"web_url":"https://patchwork.libcamera.org/comment/21851/","msgid":"<164008826596.2512616.3871503729090683829@Monstersaurus>","date":"2021-12-21T12:04:25","subject":"Re: [libcamera-devel] [PATCH v1] android: Hardcode lens focus range\n\tin result metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2021-12-21 04:53:40)\n> Hardcode the lens focus range in result metadata. As our lens focus\n> distance calibration is hardcoded to uncalibrated, and our minimum focus\n> distance is zero, we hardcode the lens focus range to [0, 0].\n> \n> Signed-off-by: Paul Elder \n\nGiven we don't yet have a libcamera control to return something else,\nthis is probably ok - but we should make sure we remember to get this\nupdated when the controls go in.\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_device.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 6c2ea61f..8861447d 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1650,6 +1650,9 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> testPatternMode);\n> }\n> \n> + std::vector focusRange = { 0.0f, 0.0f };\n> + resultMetadata->addEntry(ANDROID_LENS_FOCUS_RANGE, focusRange);\n> +\n> /*\n> * Return the result metadata pack even is not valid: get() will return\n> * nullptr.\n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59F8BBE080\n\tfor ;\n\tTue, 21 Dec 2021 12:04:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13CBC608A2;\n\tTue, 21 Dec 2021 13:04:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2280E60115\n\tfor ;\n\tTue, 21 Dec 2021 13:04:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C205B881;\n\tTue, 21 Dec 2021 13:04:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jRfbutq4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640088268;\n\tbh=0oeelJd4yblGRZdMOu7Ya+EfjmS7uzFh6AFm5g902yg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=jRfbutq4OJKsFG5UpPWOrk8HtrJX+JSBmWbPa0FknFuCRNA30hmma2pQpG3biQkwX\n\ta10V2nwsHbze1KuHGdp05fruM9a7vtZlVmJWbWKwkGjdbkSLa1bWSS5YJ1PdPLluQH\n\tskz6LNYaXVjmuGUriHO0Ft9XryoPG3IGVUanG8YU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211221045340.2571544-1-paul.elder@ideasonboard.com>","References":"<20211221045340.2571544-1-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 21 Dec 2021 12:04:25 +0000","Message-ID":"<164008826596.2512616.3871503729090683829@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1] android: Hardcode lens focus range\n\tin result metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21852,"web_url":"https://patchwork.libcamera.org/comment/21852/","msgid":"","date":"2021-12-21T12:12:19","subject":"Re: [libcamera-devel] [PATCH v1] android: Hardcode lens focus range\n\tin result metadata","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Paul\n\nOn Tue, 21 Dec 2021 at 12:04, Kieran Bingham\n wrote:\n>\n> Quoting Paul Elder (2021-12-21 04:53:40)\n> > Hardcode the lens focus range in result metadata. As our lens focus\n> > distance calibration is hardcoded to uncalibrated, and our minimum focus\n> > distance is zero, we hardcode the lens focus range to [0, 0].\n\nJust a little question on this - I thought 0 was supposed to mean\n\"infinite\" and close focus distances should get larger numbers. So is\n[0, 0] the right thing? Sorry if I've misunderstood!\n\nThanks\nDavid\n\n> >\n> > Signed-off-by: Paul Elder \n>\n> Given we don't yet have a libcamera control to return something else,\n> this is probably ok - but we should make sure we remember to get this\n> updated when the controls go in.\n>\n>\n> Reviewed-by: Kieran Bingham \n>\n> > ---\n> > src/android/camera_device.cpp | 3 +++\n> > 1 file changed, 3 insertions(+)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 6c2ea61f..8861447d 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1650,6 +1650,9 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> > testPatternMode);\n> > }\n> >\n> > + std::vector focusRange = { 0.0f, 0.0f };\n> > + resultMetadata->addEntry(ANDROID_LENS_FOCUS_RANGE, focusRange);\n> > +\n> > /*\n> > * Return the result metadata pack even is not valid: get() will return\n> > * nullptr.\n> > --\n> > 2.27.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9D32BF415\n\tfor ;\n\tTue, 21 Dec 2021 12:12:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 340DA608A2;\n\tTue, 21 Dec 2021 13:12:32 +0100 (CET)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D67E360115\n\tfor ;\n\tTue, 21 Dec 2021 13:12:30 +0100 (CET)","by mail-wr1-x435.google.com with SMTP id i22so26461612wrb.13\n\tfor ;\n\tTue, 21 Dec 2021 04:12:30 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"qQRxRNve\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=M0b0WUVKHFh6IkBMzD1mgZMJ0+rlaqhHsdBvpfM254Q=;\n\tb=qQRxRNvelSQORd57D6MTtjR0OcQh7h010naC70Cj3wDqszOWh0g7V+TfCnSGVOW45e\n\teno0ahRsOngCZjh8J7iyUHbTqgvsgR1RhBmLcfq1bJ1ePvWhuM89wLFvTfvI5fwKyKBe\n\ti3iVyX9CtybHOm/Pcfpqew0gWlnoY/p5RkcJDEjA9ZuozyQPxq2AXfhC7Ao0xyhutXdS\n\tvlVJ8Ga4+OZAKcM+ocLqAw/k5IDPTI02JA2b5liCetG19x3qYOfLiDbwbNg7ekTqGQcX\n\tAFkaa/VshnC/P0dGqdxFk3NwE+x05rZlfjMpwhjUP+phN9Chte5naEdYhvu+cQYTbaws\n\t4FRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=M0b0WUVKHFh6IkBMzD1mgZMJ0+rlaqhHsdBvpfM254Q=;\n\tb=pN3acSLArWTuLa64IYs21WRAJVwNyi05rbJ8i75ME7kMrmJNyMloTfmRC6ptHVZ7DE\n\tFzcN4mAGzZCOuNrSC675uq/5vOFK26dzeCtywqNJZN8vho0wKNJEcQQDhUVlA4phJ651\n\tIbqkd/p/uQqos4WVSiycS7NH0mSpWrNphx6flkCWI/UaK/Ecg5ylX7hNlwsSoHF01ooC\n\tEzIoQ4ifka3ufODY8kFJPOPpEQJ6U8TZlKQvU+C+Xs1hvRMcN0DmvFm/1+yopHRB/bcM\n\tsxfGzN2dpZdJEsqmjnWm2OwRevjB9RVQ3ky08fQuJOj1BS3ZGb9OYnx86CSq1GtHPrLx\n\toCbg==","X-Gm-Message-State":"AOAM531Rag9S4ezFtMt8rQ2a4yUGlxe7pyyppp2+EXMZGbcrbcMA4g0X\n\tGLibv5Yl+9XUSSVFeRGkqGgDfIy39sOUwXw9v5tzyzbSTto=","X-Google-Smtp-Source":"ABdhPJw0dvnwTKRMgQBOlKT+/7QzaC2jVbhDhP3GYvTNagu6EBGNQ1G/JFK8alLq5gpl0LtCXvCFmjEKgN80caTtY90=","X-Received":"by 2002:adf:ea0d:: with SMTP id\n\tq13mr2317111wrm.597.1640088750523; \n\tTue, 21 Dec 2021 04:12:30 -0800 (PST)","MIME-Version":"1.0","References":"<20211221045340.2571544-1-paul.elder@ideasonboard.com>\n\t<164008826596.2512616.3871503729090683829@Monstersaurus>","In-Reply-To":"<164008826596.2512616.3871503729090683829@Monstersaurus>","From":"David Plowman ","Date":"Tue, 21 Dec 2021 12:12:19 +0000","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v1] android: Hardcode lens focus range\n\tin result metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21855,"web_url":"https://patchwork.libcamera.org/comment/21855/","msgid":"","date":"2021-12-21T16:40:47","subject":"Re: [libcamera-devel] [PATCH v1] android: Hardcode lens focus range\n\tin result metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Tue, Dec 21, 2021 at 12:12:19PM +0000, David Plowman wrote:\n> On Tue, 21 Dec 2021 at 12:04, Kieran Bingham wrote:\n> > Quoting Paul Elder (2021-12-21 04:53:40)\n> > > Hardcode the lens focus range in result metadata. As our lens focus\n> > > distance calibration is hardcoded to uncalibrated, and our minimum focus\n> > > distance is zero, we hardcode the lens focus range to [0, 0].\n> \n> Just a little question on this - I thought 0 was supposed to mean\n> \"infinite\" and close focus distances should get larger numbers. So is\n> [0, 0] the right thing? Sorry if I've misunderstood!\n\nYou're right, 0 means infinity, so the commit message should probably be\nreworded.\n\n> > > Signed-off-by: Paul Elder \n> >\n> > Given we don't yet have a libcamera control to return something else,\n> > this is probably ok - but we should make sure we remember to get this\n> > updated when the controls go in.\n> >\n> > Reviewed-by: Kieran Bingham \n> >\n> > > ---\n> > > src/android/camera_device.cpp | 3 +++\n> > > 1 file changed, 3 insertions(+)\n> > >\n> > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > > index 6c2ea61f..8861447d 100644\n> > > --- a/src/android/camera_device.cpp\n> > > +++ b/src/android/camera_device.cpp\n> > > @@ -1650,6 +1650,9 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> > > testPatternMode);\n> > > }\n> > >\n> > > + std::vector focusRange = { 0.0f, 0.0f };\n> > > + resultMetadata->addEntry(ANDROID_LENS_FOCUS_RANGE, focusRange);\n> > > +\n> > > /*\n> > > * Return the result metadata pack even is not valid: get() will return\n> > > * nullptr.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74DD9BE080\n\tfor ;\n\tTue, 21 Dec 2021 16:40:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4AE0608A2;\n\tTue, 21 Dec 2021 17:40:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B54160115\n\tfor ;\n\tTue, 21 Dec 2021 17:40:51 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBCF5881;\n\tTue, 21 Dec 2021 17:40:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CO0dofCH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640104851;\n\tbh=UfMP+XUGnfwsHdVpmozwqa3V6PpJaASkVFu/iUUz+vo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CO0dofCH6VYlafOXksJ+NfrN6ounj2oumI8g6bFRCHpIp25EjPt5CgGcHIVvMtpgw\n\tlZk6hh0Lpc2zYIqgDwSk62G493b6HIozPE0BWrHarGSF8TaZnIJ5TS56kGBmOl78YK\n\tS0SE+Fjew4fV8V/9vds9otzX0f2t2dB6R6sKGLtw=","Date":"Tue, 21 Dec 2021 18:40:47 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20211221045340.2571544-1-paul.elder@ideasonboard.com>\n\t<164008826596.2512616.3871503729090683829@Monstersaurus>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v1] android: Hardcode lens focus range\n\tin result metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]