[{"id":21840,"web_url":"https://patchwork.libcamera.org/comment/21840/","msgid":"<20211221085427.oat3jvaqic3o6tyw@uno.localdomain>","date":"2021-12-21T08:54:27","subject":"Re: [libcamera-devel] [PATCH v2 5/6] android: Increase result\n\tmetadata size","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul\n\nOn Mon, Dec 20, 2021 at 05:26:28PM -0600, Paul Elder wrote:\n> Increase the initial size of the result metadata, as we will be adding\n> more entries in the near future.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f28fdd6a..83825736 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1313,7 +1313,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> \t * Total bytes for JPEG metadata: 82\n> \t */\n> \tstd::unique_ptr resultMetadata =\n> -\t\tstd::make_unique(44, 166);\n> +\t\tstd::make_unique(88, 166);\n\nI wonder if the size should be bumped too. But it seems you only get\ncomplaints about the number of entries ?\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \tif (!resultMetadata->isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate result metadata\";\n> \t\treturn nullptr;\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90F5ABE080\n\tfor ;\n\tTue, 21 Dec 2021 08:53:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52F67608EB;\n\tTue, 21 Dec 2021 09:53:35 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DBAC60113\n\tfor ;\n\tTue, 21 Dec 2021 09:53:33 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2BD92240005;\n\tTue, 21 Dec 2021 08:53:32 +0000 (UTC)"],"Date":"Tue, 21 Dec 2021 09:54:27 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20211221085427.oat3jvaqic3o6tyw@uno.localdomain>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>\n\t<20211220232629.1485890-6-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211220232629.1485890-6-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] android: Increase result\n\tmetadata size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21934,"web_url":"https://patchwork.libcamera.org/comment/21934/","msgid":"<88c57571-897f-9bc3-a92f-c0cedcbe435d@ideasonboard.com>","date":"2022-01-04T03:25:46","subject":"Re: [libcamera-devel] [PATCH v2 5/6] android: Increase result\n\tmetadata size","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul,\n\nOn 12/21/21 4:56 AM, Paul Elder wrote:\n> Increase the initial size of the result metadata, as we will be adding\n> more entries in the near future.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f28fdd6a..83825736 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1313,7 +1313,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> \t * Total bytes for JPEG metadata: 82\n> \t */\n> \tstd::unique_ptr resultMetadata =\n> -\t\tstd::make_unique(44, 166);\n> +\t\tstd::make_unique(88, 166);\n\n\nI know the CameraMetadata only takes a hint of #number of entries and \n#bytes and it can re-allocate on the fly, but bumping up the entries \nwithout the #bytes (as Jacopo pointed), seems a bit spurious. Would it \nbe helpful to recording a specific reason behind this in the commit \nmessage? I am sure someone looking at the `git log` at this patch in \nfuture, would get confused and would potentially treat it as  a bug.\n\n\n> \tif (!resultMetadata->isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate result metadata\";\n> \t\treturn nullptr;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C04ABE080\n\tfor ;\n\tTue, 4 Jan 2022 03:25:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 921FD60921;\n\tTue, 4 Jan 2022 04:25:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCCAD604F8\n\tfor ;\n\tTue, 4 Jan 2022 04:25:50 +0100 (CET)","from [IPv6:2401:4900:1f3e:193e:9a73:f356:8c6a:a1aa] (unknown\n\t[IPv6:2401:4900:1f3e:193e:9a73:f356:8c6a:a1aa])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DC821501;\n\tTue, 4 Jan 2022 04:25:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o9QPoXvu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1641266750;\n\tbh=1/uyx16f7FQfyb9upHLPQGMM9kGFug+mc/uWTS8GcpU=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=o9QPoXvuInfp1Zgd0wvYmGrOXpE94MfnAEr+4o2D746uo7vpwnuo8fn73qDEdCV7t\n\tH4ggfDrXl3SK1YeUdmR+HwolZ+jz9ZRcjmyU/e+PvGwmAL+Zm8nEgFJQYBXHLdaZ/J\n\tv1qmLaVVvD38VCGSSaZPy99LXWvQpSf7RP/4jeu0=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>\n\t<20211220232629.1485890-6-paul.elder@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<88c57571-897f-9bc3-a92f-c0cedcbe435d@ideasonboard.com>","Date":"Tue, 4 Jan 2022 08:55:46 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211220232629.1485890-6-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] android: Increase result\n\tmetadata size","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]