[{"id":21844,"web_url":"https://patchwork.libcamera.org/comment/21844/","msgid":"<20211221104243.cddch6xmyambbrtp@uno.localdomain>","date":"2021-12-21T10:42:43","subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Mon, Dec 20, 2021 at 05:26:27PM -0600, Paul Elder wrote:\n> The type of elements of the capability vector that is set in the static\n> metadata must be uint8_t. The enum will not suffice, as it is int32_t.\n> Fix this.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> ---\n> src/android/camera_capabilities.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 6d383486..ea2aaf58 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1389,7 +1389,8 @@ int CameraCapabilities::initializeStaticMetadata()\n>\n> \t/* Check capabilities */\n> \tcapabilities_ = computeCapabilities();\n> -\tstd::vector\n> +\t/* This *must* uint8_t. */\n> +\tstd::vector\n> \t\tcapsVec(capabilities_.begin(), capabilities_.end());\n\nandroid.request.availableCapabilities is indeed documented as [byte x n]\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n>\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54B37BF415\n\tfor ;\n\tTue, 21 Dec 2021 10:41:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A5CC608A2;\n\tTue, 21 Dec 2021 11:41:51 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70A5E60113\n\tfor ;\n\tTue, 21 Dec 2021 11:41:49 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id E737CE000D;\n\tTue, 21 Dec 2021 10:41:48 +0000 (UTC)"],"Date":"Tue, 21 Dec 2021 11:42:43 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20211221104243.cddch6xmyambbrtp@uno.localdomain>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>\n\t<20211220232629.1485890-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211220232629.1485890-5-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21849,"web_url":"https://patchwork.libcamera.org/comment/21849/","msgid":"<164008771892.2512616.12707718552399926815@Monstersaurus>","date":"2021-12-21T11:55:18","subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2021-12-21 10:42:43)\n> Hi Paul,\n> \n> On Mon, Dec 20, 2021 at 05:26:27PM -0600, Paul Elder wrote:\n> > The type of elements of the capability vector that is set in the static\n> > metadata must be uint8_t. The enum will not suffice, as it is int32_t.\n> > Fix this.\n> >\n> > Signed-off-by: Paul Elder \n> > Reviewed-by: Kieran Bingham \n> > ---\n> > src/android/camera_capabilities.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > index 6d383486..ea2aaf58 100644\n> > --- a/src/android/camera_capabilities.cpp\n> > +++ b/src/android/camera_capabilities.cpp\n> > @@ -1389,7 +1389,8 @@ int CameraCapabilities::initializeStaticMetadata()\n> >\n> > /* Check capabilities */\n> > capabilities_ = computeCapabilities();\n> > - std::vector\n> > + /* This *must* uint8_t. */\n\nStill missing the 'be' that I highlighted in a previous version though\n;-)\n\n--\nKieran\n\n\n> > + std::vector\n> > capsVec(capabilities_.begin(), capabilities_.end());\n> \n> android.request.availableCapabilities is indeed documented as [byte x n]\n> \n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> > staticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n> >\n> > --\n> > 2.27.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2905BF415\n\tfor ;\n\tTue, 21 Dec 2021 11:55:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41E7A608A2;\n\tTue, 21 Dec 2021 12:55:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C08D860115\n\tfor ;\n\tTue, 21 Dec 2021 12:55:21 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43431881;\n\tTue, 21 Dec 2021 12:55:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eFbsGnK5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640087721;\n\tbh=8HYuf7FwYR7q7rAl82Q4gMBj5u6HcIMjRB3DjyDe3uc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=eFbsGnK5YHk6D3kqSzprNrYadH5/qo1agC6263oVLQYf6GZ3XR7jFeZrJ8CXShVd7\n\t10f5hI1uA2+yF/6qGyAnKDUulLAEHnLJtqkOErj4j2uo5DUL76rNOAmiOANcO7i4/9\n\tzjOEUyJvsl2YxD/4d3WMqOKwHnXoplkLt8BeIPKY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211221104243.cddch6xmyambbrtp@uno.localdomain>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>\n\t<20211220232629.1485890-5-paul.elder@ideasonboard.com>\n\t<20211221104243.cddch6xmyambbrtp@uno.localdomain>","From":"Kieran Bingham ","To":"Jacopo Mondi ,\n\tPaul Elder ","Date":"Tue, 21 Dec 2021 11:55:18 +0000","Message-ID":"<164008771892.2512616.12707718552399926815@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21853,"web_url":"https://patchwork.libcamera.org/comment/21853/","msgid":"<20211221124609.gmcz5eldr4gxxxu7@uno.localdomain>","date":"2021-12-21T12:46:09","subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi again\n\nOn Tue, Dec 21, 2021 at 11:55:18AM +0000, Kieran Bingham wrote:\n> Quoting Jacopo Mondi (2021-12-21 10:42:43)\n> > Hi Paul,\n> >\n> > On Mon, Dec 20, 2021 at 05:26:27PM -0600, Paul Elder wrote:\n> > > The type of elements of the capability vector that is set in the static\n> > > metadata must be uint8_t. The enum will not suffice, as it is int32_t.\n> > > Fix this.\n> > >\n> > > Signed-off-by: Paul Elder \n> > > Reviewed-by: Kieran Bingham \n> > > ---\n> > > src/android/camera_capabilities.cpp | 3 ++-\n> > > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > > index 6d383486..ea2aaf58 100644\n> > > --- a/src/android/camera_capabilities.cpp\n> > > +++ b/src/android/camera_capabilities.cpp\n> > > @@ -1389,7 +1389,8 @@ int CameraCapabilities::initializeStaticMetadata()\n> > >\n> > > /* Check capabilities */\n> > > capabilities_ = computeCapabilities();\n> > > - std::vector\n> > > + /* This *must* uint8_t. */\n>\n> Still missing the 'be' that I highlighted in a previous version though\n> ;-)\n\nDo we need the comment at all ?\n\n>\n> --\n> Kieran\n>\n>\n> > > + std::vector\n> > > capsVec(capabilities_.begin(), capabilities_.end());\n> >\n> > android.request.availableCapabilities is indeed documented as [byte x n]\n> >\n> > Reviewed-by: Jacopo Mondi \n> >\n> > Thanks\n> > j\n> >\n> > > staticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n> > >\n> > > --\n> > > 2.27.0\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4B51BE080\n\tfor ;\n\tTue, 21 Dec 2021 12:45:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3467608E8;\n\tTue, 21 Dec 2021 13:45:16 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB44560115\n\tfor ;\n\tTue, 21 Dec 2021 13:45:15 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 00711240006;\n\tTue, 21 Dec 2021 12:45:14 +0000 (UTC)"],"Date":"Tue, 21 Dec 2021 13:46:09 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20211221124609.gmcz5eldr4gxxxu7@uno.localdomain>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>\n\t<20211220232629.1485890-5-paul.elder@ideasonboard.com>\n\t<20211221104243.cddch6xmyambbrtp@uno.localdomain>\n\t<164008771892.2512616.12707718552399926815@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164008771892.2512616.12707718552399926815@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21854,"web_url":"https://patchwork.libcamera.org/comment/21854/","msgid":"<20211221161719.GH2742@pyrite.rasen.tech>","date":"2021-12-21T16:17:19","subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hello,\n\nOn Tue, Dec 21, 2021 at 01:46:09PM +0100, Jacopo Mondi wrote:\n> Hi again\n> \n> On Tue, Dec 21, 2021 at 11:55:18AM +0000, Kieran Bingham wrote:\n> > Quoting Jacopo Mondi (2021-12-21 10:42:43)\n> > > Hi Paul,\n> > >\n> > > On Mon, Dec 20, 2021 at 05:26:27PM -0600, Paul Elder wrote:\n> > > > The type of elements of the capability vector that is set in the static\n> > > > metadata must be uint8_t. The enum will not suffice, as it is int32_t.\n> > > > Fix this.\n> > > >\n> > > > Signed-off-by: Paul Elder \n> > > > Reviewed-by: Kieran Bingham \n> > > > ---\n> > > > src/android/camera_capabilities.cpp | 3 ++-\n> > > > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > > >\n> > > > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > > > index 6d383486..ea2aaf58 100644\n> > > > --- a/src/android/camera_capabilities.cpp\n> > > > +++ b/src/android/camera_capabilities.cpp\n> > > > @@ -1389,7 +1389,8 @@ int CameraCapabilities::initializeStaticMetadata()\n> > > >\n> > > > /* Check capabilities */\n> > > > capabilities_ = computeCapabilities();\n> > > > - std::vector\n> > > > + /* This *must* uint8_t. */\n> >\n> > Still missing the 'be' that I highlighted in a previous version though\n> > ;-)\n\nOh, that's what you were highlighting; I missed it :/\n\n> \n> Do we need the comment at all ?\n\nimo yes, otherwise I'd rather use the enum type because it's more\nspecific.\n\n\nPaul\n\n> \n> >\n> > --\n> > Kieran\n> >\n> >\n> > > > + std::vector\n> > > > capsVec(capabilities_.begin(), capabilities_.end());\n> > >\n> > > android.request.availableCapabilities is indeed documented as [byte x n]\n> > >\n> > > Reviewed-by: Jacopo Mondi \n> > >\n> > > Thanks\n> > > j\n> > >\n> > > > staticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n> > > >\n> > > > --\n> > > > 2.27.0\n> > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CB27BF415\n\tfor ;\n\tTue, 21 Dec 2021 16:17:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9B5D60222;\n\tTue, 21 Dec 2021 17:17:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C74360115\n\tfor ;\n\tTue, 21 Dec 2021 17:17:26 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0D0E881;\n\tTue, 21 Dec 2021 17:17:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l5pismTY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640103445;\n\tbh=npyEs+QrfQPOTz7IIyGd7h7KKpU86MhjWEYHNKjDmV4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l5pismTY/IQZ8tMqgRp+AfVpmNRqR2RUdOBDjsYfYOiAFrnHmEY0ElS6JmBNtHxV8\n\twGXxKg297KHTaG7gWKCWD3/mCa5bZroeiHTAMArYbdAEKMBEG2r47Q4UyJdNB8sT6B\n\txnBZm3VajUp7TxhOZBaRzjbQC+F/TntoHdbGkPT4=","Date":"Tue, 21 Dec 2021 10:17:19 -0600","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20211221161719.GH2742@pyrite.rasen.tech>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>\n\t<20211220232629.1485890-5-paul.elder@ideasonboard.com>\n\t<20211221104243.cddch6xmyambbrtp@uno.localdomain>\n\t<164008771892.2512616.12707718552399926815@Monstersaurus>\n\t<20211221124609.gmcz5eldr4gxxxu7@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211221124609.gmcz5eldr4gxxxu7@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21868,"web_url":"https://patchwork.libcamera.org/comment/21868/","msgid":"<164016883298.2512616.4001193468018127614@Monstersaurus>","date":"2021-12-22T10:27:12","subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting paul.elder@ideasonboard.com (2021-12-21 16:17:19)\n> Hello,\n> \n> On Tue, Dec 21, 2021 at 01:46:09PM +0100, Jacopo Mondi wrote:\n> > Hi again\n> > \n> > On Tue, Dec 21, 2021 at 11:55:18AM +0000, Kieran Bingham wrote:\n> > > Quoting Jacopo Mondi (2021-12-21 10:42:43)\n> > > > Hi Paul,\n> > > >\n> > > > On Mon, Dec 20, 2021 at 05:26:27PM -0600, Paul Elder wrote:\n> > > > > The type of elements of the capability vector that is set in the static\n> > > > > metadata must be uint8_t. The enum will not suffice, as it is int32_t.\n> > > > > Fix this.\n> > > > >\n> > > > > Signed-off-by: Paul Elder \n> > > > > Reviewed-by: Kieran Bingham \n> > > > > ---\n> > > > > src/android/camera_capabilities.cpp | 3 ++-\n> > > > > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > > > >\n> > > > > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > > > > index 6d383486..ea2aaf58 100644\n> > > > > --- a/src/android/camera_capabilities.cpp\n> > > > > +++ b/src/android/camera_capabilities.cpp\n> > > > > @@ -1389,7 +1389,8 @@ int CameraCapabilities::initializeStaticMetadata()\n> > > > >\n> > > > > /* Check capabilities */\n> > > > > capabilities_ = computeCapabilities();\n> > > > > - std::vector\n> > > > > + /* This *must* uint8_t. */\n> > >\n> > > Still missing the 'be' that I highlighted in a previous version though\n> > > ;-)\n> \n> Oh, that's what you were highlighting; I missed it :/\n> \n> > \n> > Do we need the comment at all ?\n> \n> imo yes, otherwise I'd rather use the enum type because it's more\n> specific.\n> \n> \n> Paul\n> \n> > \n> > >\n> > > --\n> > > Kieran\n> > >\n> > >\n> > > > > + std::vector\n> > > > > capsVec(capabilities_.begin(), capabilities_.end());\n\nIt's minor, and quite late but:\n\nWould that be suitable on one line now ?\n--\nKieran\n\n\n> > > >\n> > > > android.request.availableCapabilities is indeed documented as [byte x n]\n> > > >\n> > > > Reviewed-by: Jacopo Mondi \n> > > >\n> > > > Thanks\n> > > > j\n> > > >\n> > > > > staticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n> > > > >\n> > > > > --\n> > > > > 2.27.0\n> > > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2326BE080\n\tfor ;\n\tWed, 22 Dec 2021 10:27:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BD0A608E9;\n\tWed, 22 Dec 2021 11:27:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92E4D6021F\n\tfor ;\n\tWed, 22 Dec 2021 11:27:15 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AEFE894;\n\tWed, 22 Dec 2021 11:27:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WZHC4+1a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640168835;\n\tbh=CGuf1GDV37DbzfEsuH4a3kq0wzplC7uO1qlDCQqMrPQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=WZHC4+1akn1KwM3cAYHS4Frb+3yoP4trfdMesh5k4NPDULoR89safLfNpP6868sz4\n\tfc+kEoADf1aXausOWf197ZlEDUDYr2Y7Qlhf1si1DghPikmOGT9OUEMkHXmRXQg0OS\n\tHg61Sgd7LUHqTQfYI0RQUnnGO5gX5YI1d03aMj4s=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211221161719.GH2742@pyrite.rasen.tech>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>\n\t<20211220232629.1485890-5-paul.elder@ideasonboard.com>\n\t<20211221104243.cddch6xmyambbrtp@uno.localdomain>\n\t<164008771892.2512616.12707718552399926815@Monstersaurus>\n\t<20211221124609.gmcz5eldr4gxxxu7@uno.localdomain>\n\t<20211221161719.GH2742@pyrite.rasen.tech>","From":"Kieran Bingham ","To":"Jacopo Mondi , paul.elder@ideasonboard.com","Date":"Wed, 22 Dec 2021 10:27:12 +0000","Message-ID":"<164016883298.2512616.4001193468018127614@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] android: camera_capabilities:\n\tFix the type of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]