{"id":15175,"url":"https://patchwork.libcamera.org/api/patches/15175/?format=json","web_url":"https://patchwork.libcamera.org/patch/15175/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211220232629.1485890-5-paul.elder@ideasonboard.com>","date":"2021-12-20T23:26:27","name":"[libcamera-devel,v2,4/6] android: camera_capabilities: Fix the type of the capability vector","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"572bc67a0b733147c2045a0f94aedcf225314a1e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15175/mbox/","series":[{"id":2848,"url":"https://patchwork.libcamera.org/api/series/2848/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2848","date":"2021-12-20T23:26:23","name":"android: Miscellaneous fixes","version":2,"mbox":"https://patchwork.libcamera.org/series/2848/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15175/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15175/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BE19C3258\n\tfor ;\n\tMon, 20 Dec 2021 23:26:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D128F60868;\n\tTue, 21 Dec 2021 00:26:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEC64608E8\n\tfor ;\n\tTue, 21 Dec 2021 00:26:48 +0100 (CET)","from pyrite.mediacom.info (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A864D881;\n\tTue, 21 Dec 2021 00:26:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dfZDLG0L\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640042808;\n\tbh=iKjn8F9UvwcJvxXbq7jwKuFTXg0el1XgzXjdOKTgIm0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dfZDLG0LVnmYk0zcaTwkDzprri2/byT+h16HUTU4O+Qzm59gmZzb8CnpO+EcDdKg8\n\tegoogupWSezaH82J4bgjSkdHCo6TUi7xEyj5Kqo1obfU//JBUH/E62CwRrZyzYft5Q\n\th6uVaFHpZ5vNF6FLrQ0+e3zlksE2sAzEGLVeW4P0=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Dec 2021 17:26:27 -0600","Message-Id":"<20211220232629.1485890-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 4/6] android: camera_capabilities: Fix\n\tthe type of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The type of elements of the capability vector that is set in the static\nmetadata must be uint8_t. The enum will not suffice, as it is int32_t.\nFix this.\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \n---\n src/android/camera_capabilities.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 6d383486..ea2aaf58 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1389,7 +1389,8 @@ int CameraCapabilities::initializeStaticMetadata()\n \n \t/* Check capabilities */\n \tcapabilities_ = computeCapabilities();\n-\tstd::vector\n+\t/* This *must* uint8_t. */\n+\tstd::vector\n \t\tcapsVec(capabilities_.begin(), capabilities_.end());\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n \n","prefixes":["libcamera-devel","v2","4/6"]}