[{"id":21838,"web_url":"https://patchwork.libcamera.org/comment/21838/","msgid":"<20211221084810.joio7f4ewecsdpjw@uno.localdomain>","date":"2021-12-21T08:48:10","subject":"Re: [libcamera-devel] [PATCH v2 2/6] android: camera_capabilities:\n\tSet read sensor settings capability","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Mon, Dec 20, 2021 at 05:26:25PM -0600, Paul Elder wrote:\n> A libcamera camera that supports the manual sensor capability also\n> satisfies all the requirements for the read sensor settings capability.\n> Set it.\n>\n\nI'll copy the definition of READ_SENSOR_SETTINGS below for reference\n\nREAD_SENSOR_SETTINGS (v3.2) [optional] The camera device supports\naccurately reporting the sensor settings for many of the sensor\ncontrols while the built-in 3A algorithm is running. This allows\nreporting of sensor settings even when these settings cannot be\nmanually changed. The values reported for the following controls are\nguaranteed to be available in the CaptureResult, including when 3A is\nenabled:\n\nExposure control android.sensor.exposureTime Sensitivity control\nandroid.sensor.sensitivity Lens controls (if the lens is adjustable)\nandroid.lens.focusDistance android.lens.aperture This capability is a\nsubset of the MANUAL_SENSOR control capability, and will always be\nincluded if the MANUAL_SENSOR capability is available.\n\n\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> ---\n> src/android/camera_capabilities.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 6ae2cd4d..6d383486 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -339,8 +339,11 @@ CameraCapabilities::computeCapabilities()\n>\n> \tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE);\n>\n> -\tif (validateManualSensorCapability())\n> +\tif (validateManualSensorCapability()) {\n> \t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n> +\t\t/* The libcamera requirements cover this */\n> +\t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_READ_SENSOR_SETTINGS);\n\nSo yes, it seems READ_SENSOR_SETTING < MANUAL_SENSOR.\nIf you want a comment, I would rather say that instead of mentioning\nthe 'libcamera requirements'.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\t}\n>\n> \tif (validateManualPostProcessingCapability())\n> \t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING);\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF8ECBF415\n\tfor ;\n\tTue, 21 Dec 2021 08:47:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3463C60901;\n\tTue, 21 Dec 2021 09:47:19 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4653D60113\n\tfor ;\n\tTue, 21 Dec 2021 09:47:17 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C1480C0009;\n\tTue, 21 Dec 2021 08:47:16 +0000 (UTC)"],"Date":"Tue, 21 Dec 2021 09:48:10 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20211221084810.joio7f4ewecsdpjw@uno.localdomain>","References":"<20211220232629.1485890-1-paul.elder@ideasonboard.com>\n\t<20211220232629.1485890-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211220232629.1485890-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] android: camera_capabilities:\n\tSet read sensor settings capability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]