[{"id":21825,"web_url":"https://patchwork.libcamera.org/comment/21825/","msgid":"","date":"2021-12-20T07:37:20","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for your work.\n\nOn Sun, 19 Dec 2021 at 23:27, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> From: Naushir Patuck \n>\n> Some sensors (namely the Sony IMX296, whose support will be added\n> shortly) require different conversion formulas between exposure time and\n> exposure lines. Make the Exposure() and ExposureLines() functions\n> virtual to allow this.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nSigned-off-by: Naushir Patuck @raspberrypi.com>\nReviewed-by: Naushir Patuck @raspberrypi.com>\n\n\n> ---\n> src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper.hpp\n> b/src/ipa/raspberrypi/cam_helper.hpp\n> index a776153fcb84..300f8f8a2d3b 100644\n> --- a/src/ipa/raspberrypi/cam_helper.hpp\n> +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> @@ -76,8 +76,8 @@ public:\n> virtual void Prepare(libcamera::Span buffer,\n> Metadata &metadata);\n> virtual void Process(StatisticsPtr &stats, Metadata &metadata);\n> - uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> - libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> + virtual uint32_t ExposureLines(libcamera::utils::Duration\n> exposure) const;\n> + virtual libcamera::utils::Duration Exposure(uint32_t\n> exposure_lines) const;\n> virtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,\n> libcamera::utils::Duration\n> minFrameDuration,\n> libcamera::utils::Duration\n> maxFrameDuration) const;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26571BF415\n\tfor ;\n\tMon, 20 Dec 2021 07:37:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2318605A8;\n\tMon, 20 Dec 2021 08:37:39 +0100 (CET)","from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com\n\t[IPv6:2a00:1450:4864:20::12b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF5E960115\n\tfor ;\n\tMon, 20 Dec 2021 08:37:37 +0100 (CET)","by mail-lf1-x12b.google.com with SMTP id u13so12357887lff.12\n\tfor ;\n\tSun, 19 Dec 2021 23:37:37 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"DuX8M1Kx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=k+Cwzil2EQ8i3jAoiZxyTNKCUWQbwDKZyfcnlou41Nk=;\n\tb=DuX8M1KxaIHndFt2676Vg2CglbntY3XZx1LnZiiWhTR0pBaOoCA4Lqi6Uhlc47t3eS\n\tOOtLMNO4CXoS44cMeTg/HqHWv/7/s288TLvSKj9E5Z8Y2seWNdPy1FqzctPja5R4xxap\n\tjNuLEKpTMQB1ZSwZBtZ8DJzzwW5wkdL4d9v3X3q1MSbSZ6MxzMec5wzVgjU87kEV9cSt\n\t4xesDpBEzDK1dVBJFSP9pGmh0j582axxTP3qZLCv602RK6bWWSOfhh7YG++GgGEPXzPY\n\te2GJvIDFo7fHsC6kbTGwG+2ujqE26+VQWQCjoFdqZGIxQmfbU802u1yd0tVaCiO6Ng/F\n\t8WDg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=k+Cwzil2EQ8i3jAoiZxyTNKCUWQbwDKZyfcnlou41Nk=;\n\tb=NJBkCM7z50LID5e84VJ8zwMr6K24aW/DWKDauwwJ4q/Gx9XmS6vs4boblZrBhfGGib\n\tPvKwQOuZickuj+uvV8DlOwiDxqG0lLfcOO8zRYPySXw++LfJkxt1bCtXdVor3qZK2fvA\n\tZL+e94zs/0eQloqEoB0hc+oB788DJaFtcu+nRD8or6S3vmgtJpZAM1JuJLQ2G4HR3aK1\n\tvc4V5FRv2MtApdpsKnvvYhXNGk1LCsa3dUM08XYSqLntfkQC+hpYIenlMEn60DSbRUtz\n\twwDtlSYRKYb7QFDB6//7hzA+/U3rE3jkVZbLrMY1K7svVNC8ELGCZ7uOpKCq97D3n+Rh\n\tnziw==","X-Gm-Message-State":"AOAM532AgzlEz4AfzMnM+/GXLodCbX+yxPY5sajT+LvUcnjg6csXB9wR\n\tLVcZkINxvmqzrI+WyN9fYthg+d7dByQwxPi2B0baEf5hgl5kDg==","X-Google-Smtp-Source":"ABdhPJzK8UiB+mKgt8u3oryhx5IiYzthynH6czbZrLKy1zg7RbL3txFIA0ezVxF8AYzz/uRXF1quxgFJ2YUTQKaiUow=","X-Received":"by 2002:a05:6512:1111:: with SMTP id\n\tl17mr4467518lfg.161.1639985857232; \n\tSun, 19 Dec 2021 23:37:37 -0800 (PST)","MIME-Version":"1.0","References":"<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>\n\t<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>","From":"Naushir Patuck ","Date":"Mon, 20 Dec 2021 07:37:20 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000750fe405d38ef6f0\"","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22313,"web_url":"https://patchwork.libcamera.org/comment/22313/","msgid":"<164751648117.856468.16774123449696659858@Monstersaurus>","date":"2022-03-17T11:28:01","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Quoting Laurent Pinchart (2021-12-19 23:27:12)\n> From: Naushir Patuck \n> \n> Some sensors (namely the Sony IMX296, whose support will be added\n> shortly) require different conversion formulas between exposure time and\n> exposure lines. Make the Exposure() and ExposureLines() functions\n> virtual to allow this.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> index a776153fcb84..300f8f8a2d3b 100644\n> --- a/src/ipa/raspberrypi/cam_helper.hpp\n> +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> @@ -76,8 +76,8 @@ public:\n> virtual void Prepare(libcamera::Span buffer,\n> Metadata &metadata);\n> virtual void Process(StatisticsPtr &stats, Metadata &metadata);\n> - uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> - libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> + virtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> + virtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> virtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,\n> libcamera::utils::Duration minFrameDuration,\n> libcamera::utils::Duration maxFrameDuration) const;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7828BDE17\n\tfor ;\n\tThu, 17 Mar 2022 11:28:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D9ED604DC;\n\tThu, 17 Mar 2022 12:28:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC8B2601F8\n\tfor ;\n\tThu, 17 Mar 2022 12:28:03 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DC15493;\n\tThu, 17 Mar 2022 12:28:03 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647516485;\n\tbh=OFkn5U2kM0UICd9v8j0ZkptoaBdFkzH0bSyZ4pyA0DM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pskmXcq9RXo9WzHGOdb8MviykV+lYQGyoWgVnvMmVImWXnp0ESh/owXec1+JYBMom\n\twTAPUthzGctKNMvt6C/r7g7KiN3zZBNi9NCH0N/40PHv1vmbi9D0zvlz6NQ24OgaWG\n\thhR/smnzthOZpqYt3d+jFdOqekAhhfOq+B5WChuWdsLfT5jh5jqkNHLU9IZxSsuO2t\n\tCrzrS7MrMxjssBiri5riV25DunJJG39Yrd6iiNAeaz/zjfB1YxtOvSzDZMF5cBt9NP\n\tAmMsvfkvurUDody0nBX8UYIiR0ohTL2izm0TjkgR6m/8Gzwoe4L2/kkVpuBzLXIvnl\n\tT0BIGL1CX9jcQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647516483;\n\tbh=OFkn5U2kM0UICd9v8j0ZkptoaBdFkzH0bSyZ4pyA0DM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Cv8Udku05E/P71ccOuYK0+3X3FmTnfMbHkN5LNomtPepto8SR1MPZAYBHu5k4a0A0\n\t2q00fQyuw/LQ0q5T60/G9wEqhFY+aR7p3+V41O/Umexm1aUEWlCwMzT3lxhXw+xMez\n\tMV3KMTXBOkdlhp74EK5ThCM2bjGcDhfbxpPcnQD0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Cv8Udku0\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>","References":"<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>\n\t<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 17 Mar 2022 11:28:01 +0000","Message-ID":"<164751648117.856468.16774123449696659858@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22369,"web_url":"https://patchwork.libcamera.org/comment/22369/","msgid":"","date":"2022-03-22T23:25:05","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Mar 17, 2022 at 11:28:01AM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2021-12-19 23:27:12)\n> > From: Naushir Patuck \n> > \n> > Some sensors (namely the Sony IMX296, whose support will be added\n> > shortly) require different conversion formulas between exposure time and\n> > exposure lines. Make the Exposure() and ExposureLines() functions\n> > virtual to allow this.\n> \n> Reviewed-by: Kieran Bingham \n\nNaush, could I get your SoB line for this patch ?\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> > index a776153fcb84..300f8f8a2d3b 100644\n> > --- a/src/ipa/raspberrypi/cam_helper.hpp\n> > +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> > @@ -76,8 +76,8 @@ public:\n> > virtual void Prepare(libcamera::Span buffer,\n> > Metadata &metadata);\n> > virtual void Process(StatisticsPtr &stats, Metadata &metadata);\n> > - uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> > - libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> > + virtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> > + virtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> > virtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,\n> > libcamera::utils::Duration minFrameDuration,\n> > libcamera::utils::Duration maxFrameDuration) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B393BD80A\n\tfor ;\n\tTue, 22 Mar 2022 23:25:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA229604C7;\n\tWed, 23 Mar 2022 00:25:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6F1C604C6\n\tfor ;\n\tWed, 23 Mar 2022 00:25:23 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 41F419DE;\n\tWed, 23 Mar 2022 00:25:23 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647991524;\n\tbh=YSs0VeZ7+H/HR346mv7Pad25kJBbhlVBQZZZaD9HS0Q=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fxiElUdeg9r/2R4FeONhwTgS6Rwn8GlN3+XvyY3gG2SLYCTNej67o16KNupYdR7gM\n\tWzOPAi5d+klcr/JNUqXkw6w99cj7ilvDwPm/mKzfxJC243ZXuHlOkAE6zIQ2RJWX6A\n\tcqrxgXm4KVxxOsPX57IiNXjgKItTSYqdNHSCINPj1D8ekdF8yBvJ586hiRjHjjZllN\n\tfEuI39uR2uPg7mFjw/Qm9O/25JomuT05bC9nqLVsU1VjxniwQ1W3xb2gH73FfGgoXN\n\tKIOGJrnjTq4Q/aaPU0JZ9I+6Ppsx2OukW01Oe8ZopIZBD+dJHEvSjBv78a6OxLl6Zf\n\t9JESzVhHbnReA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647991523;\n\tbh=YSs0VeZ7+H/HR346mv7Pad25kJBbhlVBQZZZaD9HS0Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uFehMofE5tTHspMigsTbhb3vKDyeyKdipl5YPhKpI7niF7JL74ClWXC2viwC2KKY8\n\tdCCRJDwYCoUsboohKGdf0tuff37mbZ58rtJBE5Dhb+suGDp4WKasLHSrwRc7ZosY9e\n\t0bCnPWiHhFrRyqUBS4X2N8ZDMGnVpcy7Cz/5KDe4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uFehMofE\"; dkim-atps=neutral","Date":"Wed, 23 Mar 2022 01:25:05 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>\n\t<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>\n\t<164751648117.856468.16774123449696659858@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164751648117.856468.16774123449696659858@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22371,"web_url":"https://patchwork.libcamera.org/comment/22371/","msgid":"<164799218381.506124.6895018801640410453@Monstersaurus>","date":"2022-03-22T23:36:23","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-03-22 23:25:05)\n> On Thu, Mar 17, 2022 at 11:28:01AM +0000, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart (2021-12-19 23:27:12)\n> > > From: Naushir Patuck \n> > > \n> > > Some sensors (namely the Sony IMX296, whose support will be added\n> > > shortly) require different conversion formulas between exposure time and\n> > > exposure lines. Make the Exposure() and ExposureLines() functions\n> > > virtual to allow this.\n> > \n> > Reviewed-by: Kieran Bingham \n> \n> Naush, could I get your SoB line for this patch ?\n\nYou have it already in\n \n--\nKB\n\n> \n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> > > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > > \n> > > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> > > index a776153fcb84..300f8f8a2d3b 100644\n> > > --- a/src/ipa/raspberrypi/cam_helper.hpp\n> > > +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> > > @@ -76,8 +76,8 @@ public:\n> > > virtual void Prepare(libcamera::Span buffer,\n> > > Metadata &metadata);\n> > > virtual void Process(StatisticsPtr &stats, Metadata &metadata);\n> > > - uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> > > - libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> > > + virtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> > > + virtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> > > virtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,\n> > > libcamera::utils::Duration minFrameDuration,\n> > > libcamera::utils::Duration maxFrameDuration) const;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D91BBBD80A\n\tfor ;\n\tTue, 22 Mar 2022 23:36:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56AC8604E6;\n\tWed, 23 Mar 2022 00:36:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86486604C6\n\tfor ;\n\tWed, 23 Mar 2022 00:36:26 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E51B9DE;\n\tWed, 23 Mar 2022 00:36:26 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647992187;\n\tbh=GOLk6WUEu28Z51eXRf2KehF/SkjKHAuDRNZXAtZjydM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=28KmHL7lJFFQfNfrqHsTHAS1/N7MnMbZMKGbgs1NfZcxyvoOz0fa8Re8BolWUrdgK\n\taY4rM8sIzuBi0AxC87Gs+nZ9GrAMJP+1B4w6RXgT7qdczf5nbWOGkSYdidrWeNiUVj\n\tznOjAVOybCvy/BdAT/W/IHJJxlYHtxMPdYUo4MTqby42Y3r6cwoja9vaXHhO2WLYnp\n\tWJPnm7MgONLCp5QOyzA89aTyY2BPgc2gio4dkYo7yTnDJivXrsliV00Zxfojx4PPQD\n\tMN2z+3dlAhBEK4hQPQBVTp3MBQ0Evqy9ntuB4bUaMbjW+sjvMQ9PJmBmtiukfb5eEa\n\tehM0oQUWMLjmg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647992186;\n\tbh=GOLk6WUEu28Z51eXRf2KehF/SkjKHAuDRNZXAtZjydM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=gOZ/TAuftcuyFrCaOPJbkz6POkTSUeIZqwXiJ6oENY7Nxj+hz2cfUl0kai2Z055SU\n\tBhegDnuLqjvLU5IqR6/YOBccC0/SQBJ3XrS0Dv6B14g4DO//UIDdjd88mnfiZZI0Dt\n\thNqAS7j7hsNPI67kex/PE9k3lQj6/LaC2qsrnk4Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gOZ/TAuf\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>\n\t<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>\n\t<164751648117.856468.16774123449696659858@Monstersaurus>\n\t","To":"Laurent Pinchart ,\n\tNaushir Patuck ","Date":"Tue, 22 Mar 2022 23:36:23 +0000","Message-ID":"<164799218381.506124.6895018801640410453@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22372,"web_url":"https://patchwork.libcamera.org/comment/22372/","msgid":"","date":"2022-03-22T23:45:30","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Mar 22, 2022 at 11:36:23PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2022-03-22 23:25:05)\n> > On Thu, Mar 17, 2022 at 11:28:01AM +0000, Kieran Bingham wrote:\n> > > Quoting Laurent Pinchart (2021-12-19 23:27:12)\n> > > > From: Naushir Patuck \n> > > > \n> > > > Some sensors (namely the Sony IMX296, whose support will be added\n> > > > shortly) require different conversion formulas between exposure time and\n> > > > exposure lines. Make the Exposure() and ExposureLines() functions\n> > > > virtual to allow this.\n> > > \n> > > Reviewed-by: Kieran Bingham \n> > \n> > Naush, could I get your SoB line for this patch ?\n> \n> You have it already in\n> \n\nOops, sorry for the noise.\n\n> > > > Signed-off-by: Laurent Pinchart \n> > > > ---\n> > > > src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> > > > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > > > \n> > > > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp\n> > > > index a776153fcb84..300f8f8a2d3b 100644\n> > > > --- a/src/ipa/raspberrypi/cam_helper.hpp\n> > > > +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> > > > @@ -76,8 +76,8 @@ public:\n> > > > virtual void Prepare(libcamera::Span buffer,\n> > > > Metadata &metadata);\n> > > > virtual void Process(StatisticsPtr &stats, Metadata &metadata);\n> > > > - uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> > > > - libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> > > > + virtual uint32_t ExposureLines(libcamera::utils::Duration exposure) const;\n> > > > + virtual libcamera::utils::Duration Exposure(uint32_t exposure_lines) const;\n> > > > virtual uint32_t GetVBlanking(libcamera::utils::Duration &exposure,\n> > > > libcamera::utils::Duration minFrameDuration,\n> > > > libcamera::utils::Duration maxFrameDuration) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CAB5BD80A\n\tfor ;\n\tTue, 22 Mar 2022 23:45:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE551604DB;\n\tWed, 23 Mar 2022 00:45:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC192604C6\n\tfor ;\n\tWed, 23 Mar 2022 00:45:48 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 244B49DE;\n\tWed, 23 Mar 2022 00:45:48 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647992749;\n\tbh=oRW6FOFM5c1lyW6Tk3CXX5uQV5j/2pXASaya7mjXANg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZohJ9cl+ChgatrfY3VCg5tiXiKsvdmfax2krza0jFDTnHlR4QGPDzwCa7UKeJw4Ek\n\t5jSrJwkcyQ3/6YdoDs4nGa39+9vHpPZIbKT4gqzzziqkwxVXFJ0Zhlss3fQMuCzCjB\n\tQiKwspjHNf/ed8ZnX21XhopCK+HP/VxPLb8sMk/NpU0yKkrnoQWdR986z6Ag3DvYfI\n\tJ7aNii1SRZMXEmV0cWWKviAB1fd7TcrIBneCgGPSk6kOH6bsMJpE3PANzMDOa0IQ/E\n\t38yu4c96X35Ipwz3y9bE3R3pnBITnzy0s77rhUJqG1MFlbO8d7SLSl63WNE5LD6a1b\n\ttkobadXExQARw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647992748;\n\tbh=oRW6FOFM5c1lyW6Tk3CXX5uQV5j/2pXASaya7mjXANg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ekKkEg0z3R/66fXVYAg8Ep73u7RFsjA73fGd41EAViY+nuX1gSvIkIqGFn+6geltq\n\tKbzhN2CoWOt5p/d/D9Ms8CVmONe899oTmi9yo+haMwTn2yCI+jlq+8Do1PRZeAExOI\n\tApkNuWpeMiGcqmI4QbfF7BRwECDXcMrOb1yNAsV4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ekKkEg0z\"; dkim-atps=neutral","Date":"Wed, 23 Mar 2022 01:45:30 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>\n\t<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>\n\t<164751648117.856468.16774123449696659858@Monstersaurus>\n\t\n\t<164799218381.506124.6895018801640410453@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164799218381.506124.6895018801640410453@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22390,"web_url":"https://patchwork.libcamera.org/comment/22390/","msgid":"","date":"2022-03-23T09:53:32","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Tue, 22 Mar 2022 at 23:45, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> On Tue, Mar 22, 2022 at 11:36:23PM +0000, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart (2022-03-22 23:25:05)\n> > > On Thu, Mar 17, 2022 at 11:28:01AM +0000, Kieran Bingham wrote:\n> > > > Quoting Laurent Pinchart (2021-12-19 23:27:12)\n> > > > > From: Naushir Patuck \n> > > > >\n> > > > > Some sensors (namely the Sony IMX296, whose support will be added\n> > > > > shortly) require different conversion formulas between exposure\n> time and\n> > > > > exposure lines. Make the Exposure() and ExposureLines() functions\n> > > > > virtual to allow this.\n> > > >\n> > > > Reviewed-by: Kieran Bingham \n> > >\n> > > Naush, could I get your SoB line for this patch ?\n> >\n> > You have it already in\n> > \n>\n> Oops, sorry for the noise.\n>\n\nJust to confirm :)\n\nSigned-off-by: Naushir Patuck \n\n\n>\n> > > > > Signed-off-by: Laurent Pinchart >\n> > > > > ---\n> > > > > src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > > > >\n> > > > > diff --git a/src/ipa/raspberrypi/cam_helper.hpp\n> b/src/ipa/raspberrypi/cam_helper.hpp\n> > > > > index a776153fcb84..300f8f8a2d3b 100644\n> > > > > --- a/src/ipa/raspberrypi/cam_helper.hpp\n> > > > > +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> > > > > @@ -76,8 +76,8 @@ public:\n> > > > > virtual void Prepare(libcamera::Span buffer,\n> > > > > Metadata &metadata);\n> > > > > virtual void Process(StatisticsPtr &stats, Metadata\n> &metadata);\n> > > > > - uint32_t ExposureLines(libcamera::utils::Duration\n> exposure) const;\n> > > > > - libcamera::utils::Duration Exposure(uint32_t\n> exposure_lines) const;\n> > > > > + virtual uint32_t ExposureLines(libcamera::utils::Duration\n> exposure) const;\n> > > > > + virtual libcamera::utils::Duration Exposure(uint32_t\n> exposure_lines) const;\n> > > > > virtual uint32_t GetVBlanking(libcamera::utils::Duration\n> &exposure,\n> > > > > libcamera::utils::Duration\n> minFrameDuration,\n> > > > > libcamera::utils::Duration\n> maxFrameDuration) const;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E9E6C0F1B\n\tfor ;\n\tWed, 23 Mar 2022 09:53:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36318604DC;\n\tWed, 23 Mar 2022 10:53:51 +0100 (CET)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8C00601F8\n\tfor ;\n\tWed, 23 Mar 2022 10:53:49 +0100 (CET)","by mail-lf1-x12e.google.com with SMTP id w27so1769277lfa.5\n\tfor ;\n\tWed, 23 Mar 2022 02:53:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648029231;\n\tbh=2SbW9zNK3KPhCmCwbKPwVHCFfy7TD2ANEtAi9e5Ci9k=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JwNa+rhNUJaOvoksIsantbFWVKDvn8CJkS7uyJtzhfqMcxyrRCK4e+5ZyHwgP3Fbu\n\txR6RpEX8MQILFV9dHPhLrYiny46dVPt51w608sxm/1wRRnklY/KWdrgRAkEkA+zWmF\n\t/V0l7fsr8miNW4maIJob5FpPmSVSuktPPyTkQ8GejARPS+IKkyKWFsa6mCpfbDv8mn\n\tOY+kF/FNC2dHVKj9bYYtLSrY5ssY/FxHzknthwEbe2p8092cFUqnhiHjUDUS3BBv2a\n\tXmDym2erFstDEFTCwK361h8kv6v0mmmRbnqqphXaLlFi3KOKJjKOhZP0HvR2zKp4+g\n\tE5FOgZ1jhv1Gw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=TJBm9Virtxm6UXDqB1EIxbRlccDq8gB1v62fj3j30pg=;\n\tb=pXe94BSEjulQA1SsJVskb9YoTYXra1S9mJPO7TkDb31/hZOWXiox864O3pskBpitNh\n\tPYLF3eqlv/yYA/YOhs+OqN9lk9E4jOjf4o5Px++vxqtamfCs0w/AtqqblT/gSZhZM3dF\n\t2uR7vrH8DXP+YvSIMIqBOED+OLLbGI+UJGlzy+HlAls7t/75V3inwMx7cuGCMEql3ZUF\n\t1tvKOZu8W6NUhNC5xXuTYEnB9ByMvQu1I3WlU2n86tsokWvQp47Wl30+XmUIyn7kJtl+\n\t/ew5i1sst7NGVidnyrjMvNj/NKWV1cQyVTJEwWapH3+OYYjrAihLJ/884Y3/a1TGmO4R\n\tqcCw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"pXe94BSE\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=TJBm9Virtxm6UXDqB1EIxbRlccDq8gB1v62fj3j30pg=;\n\tb=6vNwZX5z4+swNv7/9v+0CCe54FVJ8FBnKCwj9zYwcafIq3sHNY2pLU8+pssfyCuZ4Y\n\t7H/u/jksAto1BGn45EM4Sv/lXq0NseY4tOL7VUtyLB7VV06tGGJFFzSMnm53IzBTL2be\n\txvCYK5Bkt8kVgCHK6PfPPR/d3J6gow0iEUp7D9/X2e4tLznFPI0L1kWkl+1T7DlQCWjr\n\tMEF3XRWuxgHqciNUarV7coEl0ehZyJXVxrG/VFukvRSQ/DPhaDbX8kX984jTwQj/B3YR\n\tUeZ1uvvE8rGRVq8qsHGIxDtzcONPhKLAeYhqHmIhMo8TOvDi43qrdQIzGvEynNX6C+ix\n\ty+7A==","X-Gm-Message-State":"AOAM533n0bDL4+fCytVbJeOUGrHrQmkLJEKR5bhJkrYIkwMPXmirbkWb\n\tPlF5QQ6Zc3rlZhSIJ3+4+n6l9lGNZm9ekN+da9WhfRa5P6o=","X-Google-Smtp-Source":"ABdhPJwcbcj0r12lEdcAi3yZYbR7Nio+ucMQxa8n6GkauyJdkF5SRdvnKlXeLKy8t/knxrR3tONFS8oFD/j9LP0Qf7Y=","X-Received":"by 2002:a05:6512:1585:b0:448:3936:a5a0 with SMTP id\n\tbp5-20020a056512158500b004483936a5a0mr21050090lfb.108.1648029228930;\n\tWed, 23 Mar 2022 02:53:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>\n\t<20211219232714.11427-3-laurent.pinchart@ideasonboard.com>\n\t<164751648117.856468.16774123449696659858@Monstersaurus>\n\t\n\t<164799218381.506124.6895018801640410453@Monstersaurus>\n\t","In-Reply-To":"","Date":"Wed, 23 Mar 2022 09:53:32 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000c52dc105dadfb4a4\"","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: cam_helper:\n\tMake exposure conversion functions virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]