[{"id":21824,"web_url":"https://patchwork.libcamera.org/comment/21824/","msgid":"","date":"2021-12-20T07:36:25","subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: camera_sensor: Add\n\tIMX296 sensor properties","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for your work.\n\nOn Sun, 19 Dec 2021 at 23:27, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> The Sony IMX296 is a global shutter sensor with a 1456x1088 pixel array\n> size, with a recommended resolution after CFA interpolation of\n> 1440x1080.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Naushir Patuck @raspberrypi.com>\n\n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp\n> b/src/libcamera/camera_sensor_properties.cpp\n> index 48305ac481ed..e0086691a61e 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -90,6 +90,10 @@ const CameraSensorProperties\n> *CameraSensorProperties::get(const std::string &sen\n> { controls::draft::TestPatternModePn9, 4 },\n> },\n> } },\n> + { \"imx296\", {\n> + .unitCellSize = { 3450, 3450 },\n> + .testPatternModes = {},\n> + } },\n> { \"ov5647\", {\n> .unitCellSize = { 1400, 1400 },\n> .testPatternModes = {},\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2DB2BF415\n\tfor ;\n\tMon, 20 Dec 2021 07:36:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D394E605A8;\n\tMon, 20 Dec 2021 08:36:45 +0100 (CET)","from mail-lf1-x130.google.com (mail-lf1-x130.google.com\n\t[IPv6:2a00:1450:4864:20::130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8F3360115\n\tfor ;\n\tMon, 20 Dec 2021 08:36:43 +0100 (CET)","by mail-lf1-x130.google.com with SMTP id g26so3830005lfv.11\n\tfor ;\n\tSun, 19 Dec 2021 23:36:43 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"qa1Eu0le\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=1b2z/1PQCSLkb8xi59kofDb2suf2gPCEcPca7JmOk3E=;\n\tb=qa1Eu0lez/cpJU4BpzUOguQHTG41BZzNtkNJuvpdLQZI/tiqXp90TnrPNsRTNTbUdA\n\t9Pgb6g95sOG+wqpjPs86o+UJJJUlKSJ57+Z5f7eoWkfhM9931t3YwFLYuGBnfWAXOX+o\n\tlfB5SDBOybxOCEmKZPcFxyZrNO1rstG4J4yTEZMVjX3SO53uZBIVj39Gj18fKJ38U65f\n\t3KAsEc67ymMxP9dhzLBm1vi8nzQA4a/X3s1aR6bU/vVVVi88DvV0ADuCiUTEceE4KBQV\n\txmX1Al0+uZeFcJfwKUxuw4czlXqr9+YBifVlSEUY+EHZ+hSrfAF7+Dyy9EDoFUfW0FLa\n\tX+pg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=1b2z/1PQCSLkb8xi59kofDb2suf2gPCEcPca7JmOk3E=;\n\tb=5K1ZdP/9b+ZzOjwRbP0PgmbXp4bBytJBTHJzcEkCYWhaOGN9qkCEDDs2+lSzLlj0mn\n\tB9SdMcupT/79ymYpoakXHq/7uH37YXzoE27uS2duTBqcn2L8A+O3fctvfxj0Eg1SKsfe\n\trMbF4zyq2ffDNajeGxOuCTA7bAn7rHhpHeKPff4+8X07zznpLa3fjIxHPCfgkCgHggKJ\n\t8DWAk3SUqtVLmRKYFiue5ZiPaFHa3+TXJqwvZkbrrPN6Giwk0M2pGm2OqbHxuGa8gMu5\n\tJf9Dzp4fiqwQccbpKlle+iBmhR/bHj1J/ZgQddGMs7irREL9qsyPLDPebq8gOj606hph\n\tHZcg==","X-Gm-Message-State":"AOAM531H/HDSEEmaIHw26Wuwv56TnOUwCeeoOnnmAUfNmnJgwcVTyTt9\n\t0/ZYxSjwAXkcxc6L60XStBGaoaxUQarOG6FN49+baVfA9Hg=","X-Google-Smtp-Source":"ABdhPJw70UiDKz6bVvIGxVxVk2jc0iEsOicL8KFaVNqp32wED75uTMAjIYOyzEiGVzaWavaT6nLoNN0fuBRrW8yKQr0=","X-Received":"by 2002:a05:6512:3ee:: with SMTP id\n\tn14mr10533474lfq.611.1639985802764; \n\tSun, 19 Dec 2021 23:36:42 -0800 (PST)","MIME-Version":"1.0","References":"<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>\n\t<20211219232714.11427-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20211219232714.11427-2-laurent.pinchart@ideasonboard.com>","From":"Naushir Patuck ","Date":"Mon, 20 Dec 2021 07:36:25 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"00000000000035f45c05d38ef39a\"","Subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: camera_sensor: Add\n\tIMX296 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22312,"web_url":"https://patchwork.libcamera.org/comment/22312/","msgid":"<164751642378.856468.4288693876725328158@Monstersaurus>","date":"2022-03-17T11:27:03","subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: camera_sensor: Add\n\tIMX296 sensor properties","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Quoting Laurent Pinchart (2021-12-19 23:27:11)\n> The Sony IMX296 is a global shutter sensor with a 1456x1088 pixel array\n> size, with a recommended resolution after CFA interpolation of\n> 1440x1080.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 48305ac481ed..e0086691a61e 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -90,6 +90,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> { controls::draft::TestPatternModePn9, 4 },\n> },\n> } },\n> + { \"imx296\", {\n> + .unitCellSize = { 3450, 3450 },\n> + .testPatternModes = {},\n> + } },\n> { \"ov5647\", {\n> .unitCellSize = { 1400, 1400 },\n> .testPatternModes = {},\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9056BDE17\n\tfor ;\n\tThu, 17 Mar 2022 11:27:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE59D604E9;\n\tThu, 17 Mar 2022 12:27:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1F88601F8\n\tfor ;\n\tThu, 17 Mar 2022 12:27:06 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55C1A493;\n\tThu, 17 Mar 2022 12:27:06 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647516427;\n\tbh=sIH4+kSMD0xrP9zlZTWVNsTE3c00d7mx5RGSAOW8N5M=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=2uQch/CHqWkjGBeRULMXqRaAfJ6zgHU2VGPhERinCTmJyhwSXCmtx11LFoma/g4Bv\n\tKD8GarpmailHrp4zyk/VKq/veMJfG52FhQGkLh6p7WmZjlU1Q2csX1/hrjTNhbPtA+\n\toO0M+oloNTHbFqsRRyRszXSN20f2QoMrVfkfvCH9Hfy8j9xCh2H9gzxrE9J2Xx0KBU\n\tvNbJtcPJNeXfDCNjl2c9NJp8XhT4docMbyZGhw1K3cgZqpP0erSNsL6hH+IzKCaXzm\n\tAUl0pIGvhI4Lqj2n86s/2mNhnNj+4hNi40zjl9/WcmOQ5jDQqXF20YnnwfB35KJELx\n\tQnpKaBZHYGt5Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647516426;\n\tbh=sIH4+kSMD0xrP9zlZTWVNsTE3c00d7mx5RGSAOW8N5M=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=OsfjtwQFQI4E4w+iNqPacpby8EKANRQmksQd33Iggk3unwmHPLvHba7y6TK7QmelE\n\tol2JFxM040s9UzMsmWXkpvwx1NqhZCU3YUrs4iplcp6PTiGbABf/RzbBULyLtIeYcf\n\tZ9C5ZaAs2CjSts8PotvafFq17fVSwq2xddonWSb0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OsfjtwQF\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211219232714.11427-2-laurent.pinchart@ideasonboard.com>","References":"<20211219232714.11427-1-laurent.pinchart@ideasonboard.com>\n\t<20211219232714.11427-2-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 17 Mar 2022 11:27:03 +0000","Message-ID":"<164751642378.856468.4288693876725328158@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/4] libcamera: camera_sensor: Add\n\tIMX296 sensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]