[{"id":21810,"web_url":"https://patchwork.libcamera.org/comment/21810/","msgid":"","date":"2021-12-17T00:18:45","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n> Hello,\n> \n> I am attaching a patch to reduce the required meson version from 0.55 to\n> 0.53. There are no features in higher meson versions that are required\n> to build libcamera and this increases the number of systems that can\n> build libcamera with packaged meson versions.\n\nWe use cmake.subproject_options() in src/android/meson.build, which\naccording to the documentation been introduced in meson 0.55 (see\nhttps://mesonbuild.com/CMake-module.html#configuration-options).\n\n> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n> From: Christian Rauch \n> Date: Thu, 16 Dec 2021 23:53:31 +0000\n> Subject: meson: reduce required version to 0.53\n> \n> Signed-off-by: Christian Rauch \n> \n> diff --git a/meson.build b/meson.build\n> index a20cc29e..3bfd26fe 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,7 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> project('libcamera', 'c', 'cpp',\n> - meson_version : '>= 0.55',\n> + meson_version : '>= 0.53',\n> version : '0.0.0',\n> default_options : [\n> 'werror=true',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 272A5BDB13\n\tfor ;\n\tFri, 17 Dec 2021 00:18:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56846608E3;\n\tFri, 17 Dec 2021 01:18:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E04F260113\n\tfor ;\n\tFri, 17 Dec 2021 01:18:48 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 545D0AF2;\n\tFri, 17 Dec 2021 01:18:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M2jOh20a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639700328;\n\tbh=P/6RnEGElvkUI2Q9E+WMOcF4cMjAfZQrahdMJMNnIM8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M2jOh20a/YGJQiEriuNyQ0FhDhpceYdnPKSrCW7nnHIACa/XuiaBLYiVUZL1odcnn\n\tXV6BkGkyO/oAEAUZV8puXvV9GsBC5vRHMEgyuf9duggnwY8FE0dKtfMv6z3PaV2WFA\n\tciIW6F5mgaVK52Aq6gN6/RNF6XfIUgWJXg4hyxn0=","Date":"Fri, 17 Dec 2021 02:18:45 +0200","From":"Laurent Pinchart ","To":"Christian Rauch ","Message-ID":"","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21811,"web_url":"https://patchwork.libcamera.org/comment/21811/","msgid":"<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>","date":"2021-12-17T00:47:19","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hello Laurent,\n\nAm 17.12.21 um 00:18 schrieb Laurent Pinchart:\n> Hi Christian,\n>\n> Thank you for the patch.\n>\n> On Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n>> Hello,\n>>\n>> I am attaching a patch to reduce the required meson version from 0.55 to\n>> 0.53. There are no features in higher meson versions that are required\n>> to build libcamera and this increases the number of systems that can\n>> build libcamera with packaged meson versions.\n>\n> We use cmake.subproject_options() in src/android/meson.build, which\n> according to the documentation been introduced in meson 0.55 (see\n> https://mesonbuild.com/CMake-module.html#configuration-options).\n\nThe android feature is optional and disabled by default. I think there\nis no option to have the minimum meson version selected automatically by\nfeatures (e.g. require 0.55 only if android=enabled). In the official\ndocumentation version 0.55 could still be required for android. But the\ndefault version will build fine with 0.53 according to the official\nbuild instructions.\n\nBest,\nChristian\n\n>\n>> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n>> From: Christian Rauch \n>> Date: Thu, 16 Dec 2021 23:53:31 +0000\n>> Subject: meson: reduce required version to 0.53\n>>\n>> Signed-off-by: Christian Rauch \n>>\n>> diff --git a/meson.build b/meson.build\n>> index a20cc29e..3bfd26fe 100644\n>> --- a/meson.build\n>> +++ b/meson.build\n>> @@ -1,7 +1,7 @@\n>> # SPDX-License-Identifier: CC0-1.0\n>>\n>> project('libcamera', 'c', 'cpp',\n>> - meson_version : '>= 0.55',\n>> + meson_version : '>= 0.53',\n>> version : '0.0.0',\n>> default_options : [\n>> 'werror=true',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38793BF415\n\tfor ;\n\tFri, 17 Dec 2021 00:47:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 975D460222;\n\tFri, 17 Dec 2021 01:47:22 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B854F60113\n\tfor ;\n\tFri, 17 Dec 2021 01:47:20 +0100 (CET)","from [192.168.1.209] ([92.26.26.152]) by mail.gmx.net (mrgmx005\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MLQxN-1nEj4l0mZ9-00IXzZ;\n\tFri, 17 Dec 2021 01:47:20 +0100"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=gmx.net header.i=@gmx.net header.b=\"kcCmqO1s\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1639702040;\n\tbh=vdvH6vOpQKYSHTI503AJNN46Yh0I0FwevGYZNRR5GGI=;\n\th=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;\n\tb=kcCmqO1szZDXEpLNGx+ExjIgnICwfdzdn5bLVHLNA4tqGe6FUB4Pgtg9Mk6xNTCMG\n\tdM9tCsfjQ2+sRXldAQNLeU1eAgH/RQaia+oCU7OV2sUJEBJ4ciYcAxZbCw/0pv8beg\n\tC/l7gS87+JAUL6lWXw3quZlFJC8RM67DhITR42rw=","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"Laurent Pinchart ","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>\n\t","From":"Christian Rauch ","Message-ID":"<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>","Date":"Fri, 17 Dec 2021 00:47:19 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.14.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-CA","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:fgowuBfaJgX3xrbRNkCyQGmkOsviJ5jBfxNFbj4/4NQQV92XKq7\n\tTTQP6+HlW63PpVp7jq+D4Af9cR8c3VyHhmw4csDTExixoTTVgTx5vkgoX1wwBiK86kjbPw2\n\t+5pk91FWnBLLvdUhEes0LTQ/JJzw2ofl7Qw4qivscqBtGdDrfODJR3RYQxqt307t59+03ZV\n\tE66G/sKvwiLxcbrW31XyQ==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:mErBTvPntag=:u0cjuzg51hqHBR6dJCR4CQ\n\t8CW/n+3Xl81LkuG7cbZtTORGiciIcG686eBzR3gIaVrnnDIbOcCYinu4178EVkuPJV+UNU3Pt\n\teaGRHCnQrafh5UjIxO01v0upVnx0cfeRRMaI5c2SNYm5/WtVelyis1I8mDO8F1niGSClbc3rE\n\tO/6CCwtjqQ5EOCVKTpymwTaR87GwoFkBcMRhjF3eFqoEUrB6SlJgIrqYG+U6vXtffcs68bTJ5\n\t052DzzH3mXcYHTOCF/hfPOPfDgkV4TlyQ2RHhDPNIvcfZVkphFghe6qr75AWpilOmroEMKTqM\n\t3TbrSeLLLVTBFfpBvuQuu/tRfh3sCwt1SoElxVSUhsf8JqX5yICu6G9xY8bDJ9swc7GSINFDy\n\tExPhbb5fQpagwYPy/wk6CV4+PZhE9B9ZJWyodcNL7zFO09ITGPaCBuoFeNOE2tpY/dZPMamJY\n\tJqloWURUKwwf6+eRch3Uir5XZevdFZz3gS0u/D8uLXnzFTJkbd2zJJJxCAWxocON4R2q+jg9d\n\tX5RN4XYNIi5sTbsskGK8NMcrw1rS22MS+hozSBPkTjp2PZnpMqlJo4KSgoN/Q6NpodnM0ucfb\n\tfiEitQ9aftmh71KsDLV5KgJH9mtPdzZvXsZIwEm9noGLdE3+sJtBXb6s4dcxx4JrOLOaZ32RU\n\t9xL80W+GS5oj2mMwi4bLLSAf4OeS48OfwOv5bGzVQZbjVzyvbuiRNDW806VwJx2CpkCsFmmBu\n\tTAoo/GCHAaytFzQ9ryX3p1cM+gbfkyZ+cObrEjL6tfZCQm2LDtg9VDz1Dh0/i38HlE0L6Grkn\n\tj48Soe/cElECho9F4Qnq6nbfgeKIUeQYGI61Nm0CVe9BNJVXI/f/zBOvYDemxcCn509NNlL6t\n\tdv+BggUr4Rs2aMuKhi2it4TJcwaGXdyRugBlJhdPC0KB1pbA8dz2FfGLPBYiV02F1bALeUjMN\n\tEz1Lc5OguQKQ8eUM3I9b9rtOD2bzqJThGCLXtdUMdXffbHWrfeThg5jg+Wn4lx8ax+KnjpcSR\n\tTrGVFsr4ki5za5sBj02/zUq2StzRJuBAU3eFxSqmBR/ODjIIlQtKfYfAFxg+kRjJL1KC/p4Q7\n\t5s+sbIMRu3E3A8=","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21812,"web_url":"https://patchwork.libcamera.org/comment/21812/","msgid":"","date":"2021-12-17T00:56:17","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nOn Fri, Dec 17, 2021 at 12:47:19AM +0000, Christian Rauch wrote:\n> Am 17.12.21 um 00:18 schrieb Laurent Pinchart:\n> > On Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n> >> Hello,\n> >>\n> >> I am attaching a patch to reduce the required meson version from 0.55 to\n> >> 0.53. There are no features in higher meson versions that are required\n> >> to build libcamera and this increases the number of systems that can\n> >> build libcamera with packaged meson versions.\n> >\n> > We use cmake.subproject_options() in src/android/meson.build, which\n> > according to the documentation been introduced in meson 0.55 (see\n> > https://mesonbuild.com/CMake-module.html#configuration-options).\n> \n> The android feature is optional and disabled by default. I think there\n> is no option to have the minimum meson version selected automatically by\n> features (e.g. require 0.55 only if android=enabled).\n\nThat's unfortunately correct.\n\n> In the official\n> documentation version 0.55 could still be required for android. But the\n> default version will build fine with 0.53 according to the official\n> build instructions.\n\nmeson will then print this warning when building the Android HAL:\n\nWARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': subproject_options.\nWARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': options arg in subproject.\n\n> >> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n> >> From: Christian Rauch \n> >> Date: Thu, 16 Dec 2021 23:53:31 +0000\n> >> Subject: meson: reduce required version to 0.53\n> >>\n> >> Signed-off-by: Christian Rauch \n> >>\n> >> diff --git a/meson.build b/meson.build\n> >> index a20cc29e..3bfd26fe 100644\n> >> --- a/meson.build\n> >> +++ b/meson.build\n> >> @@ -1,7 +1,7 @@\n> >> # SPDX-License-Identifier: CC0-1.0\n> >>\n> >> project('libcamera', 'c', 'cpp',\n> >> - meson_version : '>= 0.55',\n> >> + meson_version : '>= 0.53',\n> >> version : '0.0.0',\n> >> default_options : [\n> >> 'werror=true',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 566C6BDB13\n\tfor ;\n\tFri, 17 Dec 2021 00:56:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F7ED608A2;\n\tFri, 17 Dec 2021 01:56:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E679B60113\n\tfor ;\n\tFri, 17 Dec 2021 01:56:20 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AE1FAF2;\n\tFri, 17 Dec 2021 01:56:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dD/O61IX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639702580;\n\tbh=GYHQNG17qZog5ebzFdukrF+bGeZDN68+CA3DCLtTyuI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dD/O61IX2ao6ayDkeCMiI91FHzvNpsxWpmuNXfTJ4KONNNQMAHhiOLYEX7mtPzt6c\n\tWDgrHSiaz+PwThYdvQ02PU1uaj0InSL63JyEksSZdARtYbWj+H8LxFOiK1LSy7yKnZ\n\thnQfKv0Z+EmNymsIhyEF/wuk7oybHgKWluXMLIqk=","Date":"Fri, 17 Dec 2021 02:56:17 +0200","From":"Laurent Pinchart ","To":"Christian Rauch ","Message-ID":"","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>\n\t\n\t<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21813,"web_url":"https://patchwork.libcamera.org/comment/21813/","msgid":"","date":"2021-12-17T01:05:58","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Am 17.12.21 um 00:56 schrieb Laurent Pinchart:\n> Hi Christian,\n>\n> On Fri, Dec 17, 2021 at 12:47:19AM +0000, Christian Rauch wrote:\n>> Am 17.12.21 um 00:18 schrieb Laurent Pinchart:\n>>> On Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n>>>> Hello,\n>>>>\n>>>> I am attaching a patch to reduce the required meson version from 0.55 to\n>>>> 0.53. There are no features in higher meson versions that are required\n>>>> to build libcamera and this increases the number of systems that can\n>>>> build libcamera with packaged meson versions.\n>>>\n>>> We use cmake.subproject_options() in src/android/meson.build, which\n>>> according to the documentation been introduced in meson 0.55 (see\n>>> https://mesonbuild.com/CMake-module.html#configuration-options).\n>>\n>> The android feature is optional and disabled by default. I think there\n>> is no option to have the minimum meson version selected automatically by\n>> features (e.g. require 0.55 only if android=enabled).\n>\n> That's unfortunately correct.\n>\n>> In the official\n>> documentation version 0.55 could still be required for android. But the\n>> default version will build fine with 0.53 according to the official\n>> build instructions.\n>\n> meson will then print this warning when building the Android HAL:\n>\n> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': subproject_options.\n> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': options arg in subproject.\n\nThat's correct, but it will only work if 0.55 is already installed. On\n0.53 it will just give an error if \"android=enabled\":\n\nERROR: Module cmake does not have method subproject_options.\n\nWould the proposal above (keeping 0.53 for the default configuration and\ndocumenting 0.55 for the android feature) be a viable option? That would\nmean a build with android=enabled would show the above error, but it\nwould build after updating to 0.55.\n\nBest.\n\n>\n>>>> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n>>>> From: Christian Rauch \n>>>> Date: Thu, 16 Dec 2021 23:53:31 +0000\n>>>> Subject: meson: reduce required version to 0.53\n>>>>\n>>>> Signed-off-by: Christian Rauch \n>>>>\n>>>> diff --git a/meson.build b/meson.build\n>>>> index a20cc29e..3bfd26fe 100644\n>>>> --- a/meson.build\n>>>> +++ b/meson.build\n>>>> @@ -1,7 +1,7 @@\n>>>> # SPDX-License-Identifier: CC0-1.0\n>>>>\n>>>> project('libcamera', 'c', 'cpp',\n>>>> - meson_version : '>= 0.55',\n>>>> + meson_version : '>= 0.53',\n>>>> version : '0.0.0',\n>>>> default_options : [\n>>>> 'werror=true',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C75DBF415\n\tfor ;\n\tFri, 17 Dec 2021 01:06:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE4DA608A2;\n\tFri, 17 Dec 2021 02:06:01 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A71A860113\n\tfor ;\n\tFri, 17 Dec 2021 02:05:59 +0100 (CET)","from [192.168.1.209] ([92.26.26.152]) by mail.gmx.net (mrgmx004\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MFsZ3-1mitey0FOp-00HONU;\n\tFri, 17 Dec 2021 02:05:59 +0100"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=gmx.net header.i=@gmx.net header.b=\"OsipejUo\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1639703159;\n\tbh=3QhiWwW+cXuE2L7fzBryC9Vc647BC0DlUaXtqqwDlSA=;\n\th=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;\n\tb=OsipejUopQzssGulvhdkrsJSFpy7JnjEgy5FcnNjfs7oWjW4MAT0L6/Wc5Osc0vn0\n\teUr629xttPeloFvXeiO6j1Hs7btGsOZAEZPN7aanCWII5cM2aGcGH2Gwe9eckU2Vhv\n\t4B9bdiTLcebP8Zu2r37E+0uiRs7mL4VY6J/+FGZo=","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"Laurent Pinchart ","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>\n\t\n\t<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>\n\t","From":"Christian Rauch ","Message-ID":"","Date":"Fri, 17 Dec 2021 01:05:58 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.14.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:o0ss9xz+Hzbq3N2sYS/1vSQ0qfEc2SKyzu9ZBb5Wy4bcRiQKfrq\n\tW//s4c0rJ8H0y4MUxXY3JCQEnYWx4/EetZFgO1ZfkC4tMYpB8L77aYmO2rQu+7Y0zYS59O2\n\tolTa3vJb5RENnWWsZEABoY3P2KScXpY8PHlvei6NxuSaEpSZnyb10ydNi8BJ8CGTthXNH36\n\tg0Q6KdCiisamUBRFlc25A==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:hh8oeooo06I=:GEFKQr3/c4ytyGHSgxNIrC\n\tls+YRB1lFHC5u50gKhC9GOPRSogpbg1QDoDiUQLkJQ6wzo7C6aZwwTMNFwqzL2S1kriIw4DUJ\n\ttfXy/hVMFired108uhFJyfQXOntPxgJeEtXkBRAEHXESds39Se+lmbel00URG1JBQNq+Uo2XX\n\tniPg5dLi14pkT8407j9ZrCIspu7VlX2lv46HdJfSIaJ9j+ghKPM3qSMRtQeQGYARcGNeH/iN6\n\tS85kINn4RUKrnXKdvKiFXusL3jnKxDdo3/DfbQFmnLXUmZJHcCL6oPvnOLPZ1IvOUjpAFWvPz\n\tQC5WTzGK7MPqB8T8kWwSaHTBLhHMZzyhpH3PPMzfMQU1Eo5bYydhvS5nmQu2wym/IYqBTd9ts\n\ttlj0D8UQ3oKyr5nrjVZQiANmXMcwVOrUD1lD/hQzVWO2cBQ6biQ2oR5ckN6JYVFpyZ8NcnuVC\n\tejNe4ZJ7YPtW154+5wdeV+PHot23MHA/sgvT96MhfK+t9RyeKvyLJiDOIQxsG7TGerNN2A8dN\n\t5Fq3JOeBRvLPOfflzou3tHdUbwPs8qwmBwprr9LY7sUKj/rnaghlHOTFA/0k6nhmsCjGaS5om\n\tUf7UnZgD5zAy455MclnZDDwMS1iHflJzjlgNpyEiM/cOff2CF7x/n7mQye4uofG0UPHPa+aew\n\tCZAjtzoVk1jl83DvySKIv8CSEOY0Xo5CT9/tFv6HQr/zzkcndmRCaqw9mUvo/r1ojipTC42ui\n\tda3HTzW4VoVHeEVyMvIzsk+wtvVWN+qrDewyeDn2KuqiEqCH8WyZa5wzAqHPwwt6CI+mM8Ity\n\tUQi6ko3BV0X+7Jk9GR0d6Yyw64mcE83n7tyErK3Fn5XqUEIAaW5Eg8ugeZk5bThdjMEZ9pTzZ\n\twELlqJai7sOrOQrX5mogp8PT0WNkjZ+IYQ2aifUMR6nQ3OwJzmsnFS2TLaFeSUCf9ZRqfdkC2\n\tHQ2kIpSlB8hr84YPzI316QZNJJH1PiP1WxZB/yemjuKFcJda0fNPoG6jXb9EiRyTMs7Kkkh5E\n\tMCS8+OIY8uZIscDxwFNfufKk1r1aTICHDvM9Yq0PC7Arg7ljbIPSsJkwb70j4FgL0W/4GH7rA\n\tJX1BJir0MEEj3M=","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21819,"web_url":"https://patchwork.libcamera.org/comment/21819/","msgid":"<163973332662.2512616.4331341617980653391@Monstersaurus>","date":"2021-12-17T09:28:46","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Christian Rauch (2021-12-17 01:05:58)\n> \n> Am 17.12.21 um 00:56 schrieb Laurent Pinchart:\n> > Hi Christian,\n> >\n> > On Fri, Dec 17, 2021 at 12:47:19AM +0000, Christian Rauch wrote:\n> >> Am 17.12.21 um 00:18 schrieb Laurent Pinchart:\n> >>> On Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n> >>>> Hello,\n> >>>>\n> >>>> I am attaching a patch to reduce the required meson version from 0.55 to\n> >>>> 0.53. There are no features in higher meson versions that are required\n> >>>> to build libcamera and this increases the number of systems that can\n> >>>> build libcamera with packaged meson versions.\n\nDo you have a list of distributions (and releases) which this patch is\ntargetting to support? or at least examples?\n\nWe have required a 'newer than packaged' meson for a long time, and\nusually stated that users should upgrade meson.\n\nThat has started to stabilise more recently though, as we are not\nfinding ourselves requiring new features so often - but it would be hard\nto say it won't still happen again ...\n\n\n> >>> We use cmake.subproject_options() in src/android/meson.build, which\n> >>> according to the documentation been introduced in meson 0.55 (see\n> >>> https://mesonbuild.com/CMake-module.html#configuration-options).\n> >>\n> >> The android feature is optional and disabled by default. I think there\n> >> is no option to have the minimum meson version selected automatically by\n> >> features (e.g. require 0.55 only if android=enabled).\n> >\n> > That's unfortunately correct.\n\nThe frustrating part is that for large part 'distributions' will not\nbuild the android component. Only 'specific' builds (CRoS/AOSP) will\nenable that.\n\nTechnically the android HAL could be split to a separate package /\nproject in it's own repository, with it's own meson requriements. But\nuntil we formally stabilise ABI/API, I don't think that should happen.\n\n\n> >> In the official\n> >> documentation version 0.55 could still be required for android. But the\n> >> default version will build fine with 0.53 according to the official\n> >> build instructions.\n> >\n> > meson will then print this warning when building the Android HAL:\n> >\n> > WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': subproject_options.\n> > WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': options arg in subproject.\n> \n> That's correct, but it will only work if 0.55 is already installed. On\n> 0.53 it will just give an error if \"android=enabled\":\n> \n> ERROR: Module cmake does not have method subproject_options.\n> \n> Would the proposal above (keeping 0.53 for the default configuration and\n> documenting 0.55 for the android feature) be a viable option? That would\n> mean a build with android=enabled would show the above error, but it\n> would build after updating to 0.55.\n\nHad this been for any other part of libcamera it would have been an easy\n'no, not really' - but because the android layer really is quite\ndistinct, and only built for specific platforms who are expected to have\nfull control over their build environment, ... I'm wavering...\n\nCRoS and Android builds will have a small non-blocking warning, while\notherwise other distributions will have a hard failure.\n\nBut to push me over the edge, I'd really want to see concrete examples\nof 'who' this will enable / support, so we can see a path to when we\ncould increase it again.\n\nI.e. I don't want t 'lock' ourselves out of ever taking on new meson features\njust to support Ubuntu 18.04...\n\n> \n> Best.\n> \n> >\n> >>>> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n> >>>> From: Christian Rauch \n> >>>> Date: Thu, 16 Dec 2021 23:53:31 +0000\n> >>>> Subject: meson: reduce required version to 0.53\n> >>>>\n> >>>> Signed-off-by: Christian Rauch \n> >>>>\n> >>>> diff --git a/meson.build b/meson.build\n> >>>> index a20cc29e..3bfd26fe 100644\n> >>>> --- a/meson.build\n> >>>> +++ b/meson.build\n> >>>> @@ -1,7 +1,7 @@\n> >>>> # SPDX-License-Identifier: CC0-1.0\n> >>>>\n> >>>> project('libcamera', 'c', 'cpp',\n> >>>> - meson_version : '>= 0.55',\n> >>>> + meson_version : '>= 0.53',\n\nThis would need also need explicit commenting to say that it has been\nheld back, while the android layer uses features from 0.55.\n\n--\nKieran\n\n\n> >>>> version : '0.0.0',\n> >>>> default_options : [\n> >>>> 'werror=true',\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A719EBF415\n\tfor ;\n\tFri, 17 Dec 2021 09:28:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0DB8608A2;\n\tFri, 17 Dec 2021 10:28:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23AED60223\n\tfor ;\n\tFri, 17 Dec 2021 10:28:49 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC19492A;\n\tFri, 17 Dec 2021 10:28:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dh6pMTTq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639733328;\n\tbh=5cxJ+yf+q6wgnOv9KQvEzrdiCzSGrJ5PUQtJDm+9iWg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=dh6pMTTqOD6/yDZ8pKCsZizeqnpo/LuzCdLt+0VYvCgjFgNtSfleqsDTxTBzsfQkr\n\tNrVstOdF32sv3KVpDnpFc1XvjfdjfHd70+t+KZKV/8VYQnEQ1V0axXHz+dk3yAWdFg\n\ti+3loG96mbCVFFuKFEL1EmitWw0VYONvknFEbDs8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>\n\t\n\t<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>\n\t\n\t","From":"Kieran Bingham ","To":"Christian Rauch ,\n\tLaurent Pinchart ","Date":"Fri, 17 Dec 2021 09:28:46 +0000","Message-ID":"<163973332662.2512616.4331341617980653391@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21820,"web_url":"https://patchwork.libcamera.org/comment/21820/","msgid":"<6b54b614-434a-edd8-ff8d-3e981ff5a737@gmx.de>","date":"2021-12-17T11:01:36","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"(sending again because I forgot to CC the list)\n\nAm 17.12.21 um 09:28 schrieb Kieran Bingham:\n> Quoting Christian Rauch (2021-12-17 01:05:58)\n>>\n>> Am 17.12.21 um 00:56 schrieb Laurent Pinchart:\n>>> Hi Christian,\n>>>\n>>> On Fri, Dec 17, 2021 at 12:47:19AM +0000, Christian Rauch wrote:\n>>>> Am 17.12.21 um 00:18 schrieb Laurent Pinchart:\n>>>>> On Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n>>>>>> Hello,\n>>>>>>\n>>>>>> I am attaching a patch to reduce the required meson version from 0.55 to\n>>>>>> 0.53. There are no features in higher meson versions that are required\n>>>>>> to build libcamera and this increases the number of systems that can\n>>>>>> build libcamera with packaged meson versions.\n>\n> Do you have a list of distributions (and releases) which this patch is\n> targetting to support? or at least examples?\n\nConcretely, I need this to support Ubuntu 20.04. The short reason for\nthis is that I need libcamera to build on a build server, that requires\nthat all dependencies (even build-only dependencies) are satisfied by\ndistribution packages.\n\n>\n> We have required a 'newer than packaged' meson for a long time, and\n> usually stated that users should upgrade meson.\n\nThis makes sense. As a user, it is quite easy to upgrade meson on your\nown system. So if you are just building from source as a user, it is\nstraight forward. But running this in an automated system imposes more\nconstraints.\n\n>\n> That has started to stabilise more recently though, as we are not\n> finding ourselves requiring new features so often - but it would be hard\n> to say it won't still happen again ...\n>\n>\n>>>>> We use cmake.subproject_options() in src/android/meson.build, which\n>>>>> according to the documentation been introduced in meson 0.55 (see\n>>>>> https://mesonbuild.com/CMake-module.html#configuration-options).\n>>>>\n>>>> The android feature is optional and disabled by default. I think there\n>>>> is no option to have the minimum meson version selected automatically by\n>>>> features (e.g. require 0.55 only if android=enabled).\n>>>\n>>> That's unfortunately correct.\n>\n> The frustrating part is that for large part 'distributions' will not\n> build the android component. Only 'specific' builds (CRoS/AOSP) will\n> enable that.\n>\n> Technically the android HAL could be split to a separate package /\n> project in it's own repository, with it's own meson requriements. But\n> until we formally stabilise ABI/API, I don't think that should happen.\n>\n>\n>>>> In the official\n>>>> documentation version 0.55 could still be required for android. But the\n>>>> default version will build fine with 0.53 according to the official\n>>>> build instructions.\n>>>\n>>> meson will then print this warning when building the Android HAL:\n>>>\n>>> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': subproject_options.\n>>> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': options arg in subproject.\n>>\n>> That's correct, but it will only work if 0.55 is already installed. On\n>> 0.53 it will just give an error if \"android=enabled\":\n>>\n>> ERROR: Module cmake does not have method subproject_options.\n>>\n>> Would the proposal above (keeping 0.53 for the default configuration and\n>> documenting 0.55 for the android feature) be a viable option? That would\n>> mean a build with android=enabled would show the above error, but it\n>> would build after updating to 0.55.\n>\n> Had this been for any other part of libcamera it would have been an easy\n> 'no, not really' - but because the android layer really is quite\n> distinct, and only built for specific platforms who are expected to have\n> full control over their build environment, ... I'm wavering...\n>\n> CRoS and Android builds will have a small non-blocking warning, while\n> otherwise other distributions will have a hard failure.\n>\n> But to push me over the edge, I'd really want to see concrete examples\n> of 'who' this will enable / support, so we can see a path to when we\n> could increase it again.\n\nI am using libcamera in a robotic framework (ROS) to provide a camera\ncomponent for Raspberry PIs and other supported systems. Conveniently,\nthese components are distributed in binary via apt. If I want to have my\ncamera component distributed in binary form, the build server has to\nsatisfy all dependencies via distribution packages.\n\nSo this will benefit all users that conveniently want to install this\ncomponent in binary form, in contrast to resolving dependencies and\nbuilding manually on a PC or Raspberry Pi.\n\n>\n> I.e. I don't want t 'lock' ourselves out of ever taking on new meson features\n> just to support Ubuntu 18.04...\n>\n>>\n>> Best.\n>>\n>>>\n>>>>>> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n>>>>>> From: Christian Rauch \n>>>>>> Date: Thu, 16 Dec 2021 23:53:31 +0000\n>>>>>> Subject: meson: reduce required version to 0.53\n>>>>>>\n>>>>>> Signed-off-by: Christian Rauch \n>>>>>>\n>>>>>> diff --git a/meson.build b/meson.build\n>>>>>> index a20cc29e..3bfd26fe 100644\n>>>>>> --- a/meson.build\n>>>>>> +++ b/meson.build\n>>>>>> @@ -1,7 +1,7 @@\n>>>>>> # SPDX-License-Identifier: CC0-1.0\n>>>>>>\n>>>>>> project('libcamera', 'c', 'cpp',\n>>>>>> - meson_version : '>= 0.55',\n>>>>>> + meson_version : '>= 0.53',\n>\n> This would need also need explicit commenting to say that it has been\n> held back, while the android layer uses features from 0.55.\n>\n> --\n> Kieran\n>\n>\n>>>>>> version : '0.0.0',\n>>>>>> default_options : [\n>>>>>> 'werror=true',\n>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 429EBBDB13\n\tfor ;\n\tFri, 17 Dec 2021 11:01:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5F5D60592;\n\tFri, 17 Dec 2021 12:01:38 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10AEB60114\n\tfor ;\n\tFri, 17 Dec 2021 12:01:37 +0100 (CET)","from [192.168.1.209] ([92.26.26.152]) by mail.gmx.net (mrgmx004\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1MnJhO-1mFB8m1YsG-00jKac;\n\tFri, 17 Dec 2021 12:01:36 +0100"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=gmx.net header.i=@gmx.net header.b=\"G39Tmk0Z\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1639738896;\n\tbh=su4sCudGksRYx1s+MwVoUZQUgTryNF3YiMwlsOGoR3A=;\n\th=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;\n\tb=G39Tmk0ZDltR5oaev0OiDrsOtrrK0ZLCoY/BUqLKwwRS0/QWqCYvTB+/REysMrGZN\n\tJJKsJ0YBd+V955ezLAhvBbIdn+nnf7ny/EkgacXVr/NcRhF+aFboi9NWVgRMOhxFbY\n\tCsoUqSB2FNpdl+8HWeZMdIJ9NEpaVHabvlWX2Bms=","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"Kieran Bingham ,\n\tLaurent Pinchart ","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>\n\t\n\t<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>\n\t\n\t\n\t<163973332662.2512616.4331341617980653391@Monstersaurus>","From":"Christian Rauch ","Message-ID":"<6b54b614-434a-edd8-ff8d-3e981ff5a737@gmx.de>","Date":"Fri, 17 Dec 2021 11:01:36 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.14.0","MIME-Version":"1.0","In-Reply-To":"<163973332662.2512616.4331341617980653391@Monstersaurus>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-CA","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:cWPpgdqtiXSO6dK0UkmTKBnE5VVxxq4KSzfUuvqH0wIqHh8JCAH\n\t8ZL1+Th8rX7QLdHErlA9KapvYnNAPwurnKEnFggU4SQXf/yo2QekmmsdfxCs3L31toWBAF/\n\tsu6uoTVDHBbALCG7lX7Ph+nPmf+mzZujIy1WMS5pM09+VH7HCh358P4Wj+ni2qoiYp5XTsa\n\tJ5oJ1TCoJ6i08D8eTCpoQ==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:06V3zIW1ofI=:8QQc0Bq55fsx/6ZoSwF8wb\n\tEUEk/4BBE3O0FP2U8FYooM4EWFHJgw/CobfXzmytkCM5MqDd1ScyM4XNgcqK05hbyoOK3HCt6\n\tGKsFwWsDRvOVuwnxUCBofP7MIZ1boJDeJIiWGCdxtmQc0u2YXHuALbigyHUCnwDv5LbWHEu/z\n\tOTW8jvabfZl5e8UjYs0HG6ADa75uvanJLVWshML9VuKxN7rcxKjQhwdR/eNRvDFujlglZUcKE\n\tPEeR6oeVoZtcxPxcbkjtAQtTCef8VheZNqp/pPkR3OLkye+DA1turtbpWjQ3q5TYI7BIQ0qxU\n\t+38SZzuD0w8qpldFhCC7cmLhVaHDGV+Vh3uppjB+30OmQZ7FQuCXSmLAuiE4D7GzxpAgEgfmJ\n\tlNQg8RTeMdsCeJSlzSqhMTa+3PoDAfB8SJL0VmmwRumWiMIpIDvlBXevGK/zKp7olXutLJPF9\n\tkg1c0cVqQF/q5piEh3OKBpPv9x2O/HMZdJpnnHMEN1HOijUEtC1qG5lGhkjq8M6C4sEQYEQgA\n\t+TyNqic5N9VEhAGDKU8f8J0EktEK2PNvdFVGD9rrj+ZaC7sd5TN4JZxjKq//oyg4gvwd888io\n\t6BgsarjBP+xkYIeGGqd/C/rVBoIS+GbPIr+GFxJAAiPNWNH4g1V/GuRqUFJn45BD//xmtriQX\n\tsHeF0d/+LmiqfFM6XgUYbukI22jGMz62l9xheILdhoOigINPGLsaR1zxFgKt0wqzGj6w5VNom\n\tOZfyZBOz3Ldjj5fX/chmHZ0csh1iCm8wLUwoaCXiBCOJ2H9l7TEkjkQtId9O7qftJT9IEHGJv\n\tkOd247ZB1YbjtN/DbS9jqb+PCJuvsGZIgQDLYyxhSkUHf/IYC8xsGDTcZRf9I4DCMyxhmH1i6\n\tJXc61rlPHhDYyQnrvb/BJMgPH8LnqztBTkDv9zKcMDltYZgXkVVQUXodQV0SucS+9C619QVbJ\n\tShF6PUSZ7GOfVwFXRn8SZOgnnhsA/nETi/lZ8nVpvESH/HhtBTivlBLhMZQcm3PNCv+82bon7\n\teOhaIRhbsPXoe7g7jUvj7VP+Rtdb1js79QNsI9ZtIhGi6eE04HyjHEbICF3JRvDD+qxrilBtY\n\tNtHECyYoAhGVF8=","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21830,"web_url":"https://patchwork.libcamera.org/comment/21830/","msgid":"<8b0279eb-038a-269f-5d47-ebf9a911d467@gmx.de>","date":"2021-12-20T16:57:30","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi,\n\nCan I get some feedback on downgrading the meson requirement to 0.53 for\nthe default build configuration? I think my use-case (automatic builds\nand distribution of apt packages) is valid.\n\nHaving this upstreamed is much more favourable than maintaining custom\nforks or patches just to replace the version number.\n\nBest,\nChristian\n\n\nAm 17.12.21 um 11:01 schrieb Christian Rauch:\n> (sending again because I forgot to CC the list)\n>\n> Am 17.12.21 um 09:28 schrieb Kieran Bingham:\n>> Quoting Christian Rauch (2021-12-17 01:05:58)\n>>>\n>>> Am 17.12.21 um 00:56 schrieb Laurent Pinchart:\n>>>> Hi Christian,\n>>>>\n>>>> On Fri, Dec 17, 2021 at 12:47:19AM +0000, Christian Rauch wrote:\n>>>>> Am 17.12.21 um 00:18 schrieb Laurent Pinchart:\n>>>>>> On Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n>>>>>>> Hello,\n>>>>>>>\n>>>>>>> I am attaching a patch to reduce the required meson version from 0.55 to\n>>>>>>> 0.53. There are no features in higher meson versions that are required\n>>>>>>> to build libcamera and this increases the number of systems that can\n>>>>>>> build libcamera with packaged meson versions.\n>>\n>> Do you have a list of distributions (and releases) which this patch is\n>> targetting to support? or at least examples?\n>\n> Concretely, I need this to support Ubuntu 20.04. The short reason for\n> this is that I need libcamera to build on a build server, that requires\n> that all dependencies (even build-only dependencies) are satisfied by\n> distribution packages.\n>\n>>\n>> We have required a 'newer than packaged' meson for a long time, and\n>> usually stated that users should upgrade meson.\n>\n> This makes sense. As a user, it is quite easy to upgrade meson on your\n> own system. So if you are just building from source as a user, it is\n> straight forward. But running this in an automated system imposes more\n> constraints.\n>\n>>\n>> That has started to stabilise more recently though, as we are not\n>> finding ourselves requiring new features so often - but it would be hard\n>> to say it won't still happen again ...\n>>\n>>\n>>>>>> We use cmake.subproject_options() in src/android/meson.build, which\n>>>>>> according to the documentation been introduced in meson 0.55 (see\n>>>>>> https://mesonbuild.com/CMake-module.html#configuration-options).\n>>>>>\n>>>>> The android feature is optional and disabled by default. I think there\n>>>>> is no option to have the minimum meson version selected automatically by\n>>>>> features (e.g. require 0.55 only if android=enabled).\n>>>>\n>>>> That's unfortunately correct.\n>>\n>> The frustrating part is that for large part 'distributions' will not\n>> build the android component. Only 'specific' builds (CRoS/AOSP) will\n>> enable that.\n>>\n>> Technically the android HAL could be split to a separate package /\n>> project in it's own repository, with it's own meson requriements. But\n>> until we formally stabilise ABI/API, I don't think that should happen.\n>>\n>>\n>>>>> In the official\n>>>>> documentation version 0.55 could still be required for android. But the\n>>>>> default version will build fine with 0.53 according to the official\n>>>>> build instructions.\n>>>>\n>>>> meson will then print this warning when building the Android HAL:\n>>>>\n>>>> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': subproject_options.\n>>>> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': options arg in subproject.\n>>>\n>>> That's correct, but it will only work if 0.55 is already installed. On\n>>> 0.53 it will just give an error if \"android=enabled\":\n>>>\n>>> ERROR: Module cmake does not have method subproject_options.\n>>>\n>>> Would the proposal above (keeping 0.53 for the default configuration and\n>>> documenting 0.55 for the android feature) be a viable option? That would\n>>> mean a build with android=enabled would show the above error, but it\n>>> would build after updating to 0.55.\n>>\n>> Had this been for any other part of libcamera it would have been an easy\n>> 'no, not really' - but because the android layer really is quite\n>> distinct, and only built for specific platforms who are expected to have\n>> full control over their build environment, ... I'm wavering...\n>>\n>> CRoS and Android builds will have a small non-blocking warning, while\n>> otherwise other distributions will have a hard failure.\n>>\n>> But to push me over the edge, I'd really want to see concrete examples\n>> of 'who' this will enable / support, so we can see a path to when we\n>> could increase it again.\n>\n> I am using libcamera in a robotic framework (ROS) to provide a camera\n> component for Raspberry PIs and other supported systems. Conveniently,\n> these components are distributed in binary via apt. If I want to have my\n> camera component distributed in binary form, the build server has to\n> satisfy all dependencies via distribution packages.\n>\n> So this will benefit all users that conveniently want to install this\n> component in binary form, in contrast to resolving dependencies and\n> building manually on a PC or Raspberry Pi.\n>\n>>\n>> I.e. I don't want t 'lock' ourselves out of ever taking on new meson features\n>> just to support Ubuntu 18.04...\n>>\n>>>\n>>> Best.\n>>>\n>>>>\n>>>>>>> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n>>>>>>> From: Christian Rauch \n>>>>>>> Date: Thu, 16 Dec 2021 23:53:31 +0000\n>>>>>>> Subject: meson: reduce required version to 0.53\n>>>>>>>\n>>>>>>> Signed-off-by: Christian Rauch \n>>>>>>>\n>>>>>>> diff --git a/meson.build b/meson.build\n>>>>>>> index a20cc29e..3bfd26fe 100644\n>>>>>>> --- a/meson.build\n>>>>>>> +++ b/meson.build\n>>>>>>> @@ -1,7 +1,7 @@\n>>>>>>> # SPDX-License-Identifier: CC0-1.0\n>>>>>>>\n>>>>>>> project('libcamera', 'c', 'cpp',\n>>>>>>> - meson_version : '>= 0.55',\n>>>>>>> + meson_version : '>= 0.53',\n>>\n>> This would need also need explicit commenting to say that it has been\n>> held back, while the android layer uses features from 0.55.\n>>\n>> --\n>> Kieran\n>>\n>>\n>>>>>>> version : '0.0.0',\n>>>>>>> default_options : [\n>>>>>>> 'werror=true',\n>>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 025A5BF415\n\tfor ;\n\tMon, 20 Dec 2021 16:57:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A70C608E7;\n\tMon, 20 Dec 2021 17:57:33 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE44460223\n\tfor ;\n\tMon, 20 Dec 2021 17:57:31 +0100 (CET)","from [192.168.1.209] ([92.26.26.152]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1MUXpQ-1mqaWB0O8G-00QOwa;\n\tMon, 20 Dec 2021 17:57:31 +0100"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=gmx.net header.i=@gmx.net header.b=\"G+bWO0pV\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1640019451;\n\tbh=nzP3sxQDUloUl36be+zBQw7q5ypmYd/H0GKe+NguWq8=;\n\th=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To;\n\tb=G+bWO0pV6Qoha/0Ed39Zmx/CkIL07xVZAweBljqhgEKVh7F+/Mri1Oj/HnXYcexwG\n\tbsJgz/U0HS31/oibCFUC9eHlzzWn6PZjxaT30ZHS/HAo4w8/hV1O36w5h654/L4MkU\n\tMiCpgzlcvQ5SloFRtv5/CjtiOQoS/qoAS8VKBMPo=","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","From":"Christian Rauch ","To":"Kieran Bingham ,\n\tLaurent Pinchart ","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>\n\t\n\t<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>\n\t\n\t\n\t<163973332662.2512616.4331341617980653391@Monstersaurus>\n\t<6b54b614-434a-edd8-ff8d-3e981ff5a737@gmx.de>","Message-ID":"<8b0279eb-038a-269f-5d47-ebf9a911d467@gmx.de>","Date":"Mon, 20 Dec 2021 16:57:30 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.14.0","MIME-Version":"1.0","In-Reply-To":"<6b54b614-434a-edd8-ff8d-3e981ff5a737@gmx.de>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-CA","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:c4NFCN1aMssqfs4x2PWkjkFpA3i1sEWfjBrgL21veG/76ZFustm\n\tuCMojC0ERGhkv+p2ESeVPM4l+UGAFh6MW0u7zYkM5qcg6gufQ8pzHOHin8Ycj9pDjTuIi7l\n\t6kKkEWRpiVhfqo3GlItCV/eyRV0YRuhdQ57zye5X74ajqA6ArmEqQ8/KebCtMFAD9+GAm9p\n\tCm/gtLnLZuz/suj5NA3Hw==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:Rdtc/3vNAEY=:m7pcYnJPAojs4rYU+fsRkI\n\tfz3TFW+7lRhvXdkCKKi88wVHWAipYQ1/34HgxodUOFV5+ZPjzxflq64881c5BzWPzem+2saUf\n\tnJqXVKpA/pGgku3Zsoda5fKfP1iJ5m/4CprZmn7C5ba5vleDa1wbOhZOaYvR/m70gVAkHE86J\n\tczMCVXA2WnxXt60kADA5cdcbO/trRpWky+Jl3HfGN0+bZkGdiv9T3A3tg8gHka5GkK/EmTi6f\n\tM1pkvq53NfJs+IyG1MyEK0Z0eQPgmDhT4hTSs81/RwzFj7mfP6vPN4xGbnBeIPcJZPNzJ5UWU\n\tZznVWWaonjj47iglDdSvHpsqPEqXiqzLvqZ/ySTsPV1b+8TP5JqMA5uYge37Bqef8E4ycRjuB\n\tVhwbgvZQwBeWCNmGFA8K0PxwNWRrS2BrD+1IQ4eNVvUgBqzEMgMjBXTJpnyp42K4o348B47su\n\t7F0Ap1a/4cY/DOn664VioksYgjAnRCTqynRhbrAF+ZaK5IrZaL7LRV+0GjZ9lOXDqnInmyo0C\n\tIJIs9WlwQ3jeuHzP1BFUsI6GnRcXvzDh5yX04xZsPIkxY8LEV3+93W+TU0A2Cr/h2Y6VUfJD8\n\tBU7Bt1q8xpYDeik+1JiJLbHlepYLjqTSjW68TJ2mmYhXona+fVp7xLF7vXPSeyHzqs/UvAR2I\n\tAvuieDzHw6nl5vRnLs0BnlnJhXJ+vkhub8rDxIGx2dXLEQXJmG2I/7VoolshTGgYEMVIKUQ/K\n\t4OrTvl9uC9BnV/6q/5omsedM6hCdL++Tkp53oaFBypfNjK7NpfwAx7rbyq5ev+4NJzadWLiBw\n\tMIoRBN7opprHTK7A6qBf3fd3aakLBogmZ362Z8f27PzCfORg7YdhrILiUR3iwD3U9ERqidwdi\n\tMz0MyaxGz0oD8VuSoiRDSnMbzNwckLQuR0F6aSKwhWUjcsT/mtGn4U6kX5L4LtfVsWBBLMh9Z\n\tuT5YCZ42cOIPxlOfbOnlKKvNz71vlCqrSEC3weAwaRgkiFKsZFAfV1DTT8kBb0dLk0j5t123j\n\tLbGeuDrxrUMz+fUEj75M/zokZ8znEjfK7CTXW96aOsGAMf6rmsInQLYH6CR/hnepM5GJCZrNO\n\tqZP57tdoGLlMgc=","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21846,"web_url":"https://patchwork.libcamera.org/comment/21846/","msgid":"<164008366256.2512616.9846928356781164241@Monstersaurus>","date":"2021-12-21T10:47:42","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Christian,\n\nQuoting Christian Rauch (2021-12-20 16:57:30)\n> Hi,\n> \n> Can I get some feedback on downgrading the meson requirement to 0.53 for\n> the default build configuration? I think my use-case (automatic builds\n> and distribution of apt packages) is valid.\n\nSorry for the delay, I wanted to discuss this with others in the team.\n\n> Having this upstreamed is much more favourable than maintaining custom\n> forks or patches just to replace the version number.\n> \n> Best,\n> Christian\n> \n> \n> Am 17.12.21 um 11:01 schrieb Christian Rauch:\n> > (sending again because I forgot to CC the list)\n> >\n> > Am 17.12.21 um 09:28 schrieb Kieran Bingham:\n> >> Quoting Christian Rauch (2021-12-17 01:05:58)\n> >>>\n> >>> Am 17.12.21 um 00:56 schrieb Laurent Pinchart:\n> >>>> Hi Christian,\n> >>>>\n> >>>> On Fri, Dec 17, 2021 at 12:47:19AM +0000, Christian Rauch wrote:\n> >>>>> Am 17.12.21 um 00:18 schrieb Laurent Pinchart:\n> >>>>>> On Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n> >>>>>>> Hello,\n> >>>>>>>\n> >>>>>>> I am attaching a patch to reduce the required meson version from 0.55 to\n> >>>>>>> 0.53. There are no features in higher meson versions that are required\n> >>>>>>> to build libcamera and this increases the number of systems that can\n> >>>>>>> build libcamera with packaged meson versions.\n> >>\n> >> Do you have a list of distributions (and releases) which this patch is\n> >> targetting to support? or at least examples?\n> >\n> > Concretely, I need this to support Ubuntu 20.04. The short reason for\n> > this is that I need libcamera to build on a build server, that requires\n> > that all dependencies (even build-only dependencies) are satisfied by\n> > distribution packages.\n> >\n> >>\n> >> We have required a 'newer than packaged' meson for a long time, and\n> >> usually stated that users should upgrade meson.\n> >\n> > This makes sense. As a user, it is quite easy to upgrade meson on your\n> > own system. So if you are just building from source as a user, it is\n> > straight forward. But running this in an automated system imposes more\n> > constraints.\n\nSupporting the latest Ubuntu LTS is reasonable, so we will accept\nlowering the minimum version.\n\nPlease note, we consider this a short term solution until Ubuntu 22.04\nis released (or a bit after that), where we would expect to re-increase\nour minimum meson version to match the expectations of the code base.\n\nIf we find that we need newer meson features in the core framework\nbefore 22.04 is released however we would have to raise it in that\ninstance, but I don't see anything specific coming up, so it should be\nfine.\n\n> >> That has started to stabilise more recently though, as we are not\n> >> finding ourselves requiring new features so often - but it would be hard\n> >> to say it won't still happen again ...\n> >>\n> >>\n> >>>>>> We use cmake.subproject_options() in src/android/meson.build, which\n> >>>>>> according to the documentation been introduced in meson 0.55 (see\n> >>>>>> https://mesonbuild.com/CMake-module.html#configuration-options).\n> >>>>>\n> >>>>> The android feature is optional and disabled by default. I think there\n> >>>>> is no option to have the minimum meson version selected automatically by\n> >>>>> features (e.g. require 0.55 only if android=enabled).\n> >>>>\n> >>>> That's unfortunately correct.\n> >>\n> >> The frustrating part is that for large part 'distributions' will not\n> >> build the android component. Only 'specific' builds (CRoS/AOSP) will\n> >> enable that.\n> >>\n> >> Technically the android HAL could be split to a separate package /\n> >> project in it's own repository, with it's own meson requriements. But\n> >> until we formally stabilise ABI/API, I don't think that should happen.\n> >>\n> >>\n> >>>>> In the official\n> >>>>> documentation version 0.55 could still be required for android. But the\n> >>>>> default version will build fine with 0.53 according to the official\n> >>>>> build instructions.\n> >>>>\n> >>>> meson will then print this warning when building the Android HAL:\n> >>>>\n> >>>> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': subproject_options.\n> >>>> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': options arg in subproject.\n> >>>\n> >>> That's correct, but it will only work if 0.55 is already installed. On\n> >>> 0.53 it will just give an error if \"android=enabled\":\n> >>>\n> >>> ERROR: Module cmake does not have method subproject_options.\n> >>>\n> >>> Would the proposal above (keeping 0.53 for the default configuration and\n> >>> documenting 0.55 for the android feature) be a viable option? That would\n> >>> mean a build with android=enabled would show the above error, but it\n> >>> would build after updating to 0.55.\n> >>\n> >> Had this been for any other part of libcamera it would have been an easy\n> >> 'no, not really' - but because the android layer really is quite\n> >> distinct, and only built for specific platforms who are expected to have\n> >> full control over their build environment, ... I'm wavering...\n> >>\n> >> CRoS and Android builds will have a small non-blocking warning, while\n> >> otherwise other distributions will have a hard failure.\n> >>\n> >> But to push me over the edge, I'd really want to see concrete examples\n> >> of 'who' this will enable / support, so we can see a path to when we\n> >> could increase it again.\n> >\n> > I am using libcamera in a robotic framework (ROS) to provide a camera\n> > component for Raspberry PIs and other supported systems. Conveniently,\n> > these components are distributed in binary via apt. If I want to have my\n> > camera component distributed in binary form, the build server has to\n> > satisfy all dependencies via distribution packages.\n> >\n> > So this will benefit all users that conveniently want to install this\n> > component in binary form, in contrast to resolving dependencies and\n> > building manually on a PC or Raspberry Pi.\n> >\n> >>\n> >> I.e. I don't want t 'lock' ourselves out of ever taking on new meson features\n> >> just to support Ubuntu 18.04...\n> >>\n> >>>\n> >>> Best.\n> >>>\n> >>>>\n> >>>>>>> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n> >>>>>>> From: Christian Rauch \n> >>>>>>> Date: Thu, 16 Dec 2021 23:53:31 +0000\n> >>>>>>> Subject: meson: reduce required version to 0.53\n> >>>>>>>\n\nI think we should add a bit more detail to the commit message for\nexample:\n\n\"\"\"\nBuilding the libcamera Android layer currently makes use of features\nfrom meson 0.55. The core libcamera framework without android enabled\nmakes use of the 'summary' feature available in 0.53, and is the lowest\nsupportable meson version if the Android HAL is excluded.\n\nUbuntu 20.04 LTS currently provides meson 0.53 and represents an\nacceptable minimum version to support. Platforms utilising the Android\ncomponent will have full control over their build environment and can\nensure that they provide a more recent version of meson.\n\nReduce the supported meson version for the project to 0.53 to facilitate\nbuilding on more distributions without having to manually update the\nmeson package.\n\"\"\"\n\n> >>>>>>> Signed-off-by: Christian Rauch \n> >>>>>>>\n> >>>>>>> diff --git a/meson.build b/meson.build\n> >>>>>>> index a20cc29e..3bfd26fe 100644\n> >>>>>>> --- a/meson.build\n> >>>>>>> +++ b/meson.build\n> >>>>>>> @@ -1,7 +1,7 @@\n> >>>>>>> # SPDX-License-Identifier: CC0-1.0\n> >>>>>>>\n> >>>>>>> project('libcamera', 'c', 'cpp',\n> >>>>>>> - meson_version : '>= 0.55',\n> >>>>>>> + meson_version : '>= 0.53',\n> >>\n> >> This would need also need explicit commenting to say that it has been\n> >> held back, while the android layer uses features from 0.55.\n\nThis should certainly be added to your patch to get it in too.\n\n\n--\nRegards\n\nKieran\n\n\n> >>\n> >> --\n> >> Kieran\n> >>\n> >>\n> >>>>>>> version : '0.0.0',\n> >>>>>>> default_options : [\n> >>>>>>> 'werror=true',\n> >>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 104A4BE080\n\tfor ;\n\tTue, 21 Dec 2021 10:47:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FF7D608A2;\n\tTue, 21 Dec 2021 11:47:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D293C60113\n\tfor ;\n\tTue, 21 Dec 2021 11:47:45 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5327E881;\n\tTue, 21 Dec 2021 11:47:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MDS00lRy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640083665;\n\tbh=i47xhCNhP5YpGv3WGqwypPAA8SFZNoTt7hcXt2Fx6+U=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=MDS00lRyJihLVSci6EWADQJYQqB1S7mu4XOUo0RbKYB1HZ7qI1ISltAcpd0o+P4cB\n\tv3YZCAS7t6AhNi06wopSOvx85s3ulUqbXHIhXaYTfwBrYMtDWPu269Dxihsyw1s9gt\n\tjT8NqOprahDoTnqppwWp3pY+g8fAWgliCyEuucyc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<8b0279eb-038a-269f-5d47-ebf9a911d467@gmx.de>","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>\n\t\n\t<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>\n\t\n\t\n\t<163973332662.2512616.4331341617980653391@Monstersaurus>\n\t<6b54b614-434a-edd8-ff8d-3e981ff5a737@gmx.de>\n\t<8b0279eb-038a-269f-5d47-ebf9a911d467@gmx.de>","From":"Kieran Bingham ","To":"Christian Rauch ,\n\tLaurent Pinchart ","Date":"Tue, 21 Dec 2021 10:47:42 +0000","Message-ID":"<164008366256.2512616.9846928356781164241@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21850,"web_url":"https://patchwork.libcamera.org/comment/21850/","msgid":"<536bce26-d763-9cca-08e9-e396a3def755@gmx.de>","date":"2021-12-21T12:03:48","subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Dear Kieran\n\n\nThank you for your comments. Only supporting the latest Ubuntu LTS is\nreasonable.\n\nI attached a new patch with a more detailed commit message. I mostly\ntook your suggestion and only added that the default configuration is\nbuilt without android. Hence this will have no effect for users that\njust run the default documented build steps.\n\nBest,\nChristian\n\n\nAm 21.12.21 um 10:47 schrieb Kieran Bingham:\n> Hi Christian,\n>\n> Quoting Christian Rauch (2021-12-20 16:57:30)\n>> Hi,\n>>\n>> Can I get some feedback on downgrading the meson requirement to 0.53 for\n>> the default build configuration? I think my use-case (automatic builds\n>> and distribution of apt packages) is valid.\n>\n> Sorry for the delay, I wanted to discuss this with others in the team.\n>\n>> Having this upstreamed is much more favourable than maintaining custom\n>> forks or patches just to replace the version number.\n>>\n>> Best,\n>> Christian\n>>\n>>\n>> Am 17.12.21 um 11:01 schrieb Christian Rauch:\n>>> (sending again because I forgot to CC the list)\n>>>\n>>> Am 17.12.21 um 09:28 schrieb Kieran Bingham:\n>>>> Quoting Christian Rauch (2021-12-17 01:05:58)\n>>>>>\n>>>>> Am 17.12.21 um 00:56 schrieb Laurent Pinchart:\n>>>>>> Hi Christian,\n>>>>>>\n>>>>>> On Fri, Dec 17, 2021 at 12:47:19AM +0000, Christian Rauch wrote:\n>>>>>>> Am 17.12.21 um 00:18 schrieb Laurent Pinchart:\n>>>>>>>> On Fri, Dec 17, 2021 at 12:09:41AM +0000, Christian Rauch wrote:\n>>>>>>>>> Hello,\n>>>>>>>>>\n>>>>>>>>> I am attaching a patch to reduce the required meson version from 0.55 to\n>>>>>>>>> 0.53. There are no features in higher meson versions that are required\n>>>>>>>>> to build libcamera and this increases the number of systems that can\n>>>>>>>>> build libcamera with packaged meson versions.\n>>>>\n>>>> Do you have a list of distributions (and releases) which this patch is\n>>>> targetting to support? or at least examples?\n>>>\n>>> Concretely, I need this to support Ubuntu 20.04. The short reason for\n>>> this is that I need libcamera to build on a build server, that requires\n>>> that all dependencies (even build-only dependencies) are satisfied by\n>>> distribution packages.\n>>>\n>>>>\n>>>> We have required a 'newer than packaged' meson for a long time, and\n>>>> usually stated that users should upgrade meson.\n>>>\n>>> This makes sense. As a user, it is quite easy to upgrade meson on your\n>>> own system. So if you are just building from source as a user, it is\n>>> straight forward. But running this in an automated system imposes more\n>>> constraints.\n>\n> Supporting the latest Ubuntu LTS is reasonable, so we will accept\n> lowering the minimum version.\n>\n> Please note, we consider this a short term solution until Ubuntu 22.04\n> is released (or a bit after that), where we would expect to re-increase\n> our minimum meson version to match the expectations of the code base.\n>\n> If we find that we need newer meson features in the core framework\n> before 22.04 is released however we would have to raise it in that\n> instance, but I don't see anything specific coming up, so it should be\n> fine.\n>\n>>>> That has started to stabilise more recently though, as we are not\n>>>> finding ourselves requiring new features so often - but it would be hard\n>>>> to say it won't still happen again ...\n>>>>\n>>>>\n>>>>>>>> We use cmake.subproject_options() in src/android/meson.build, which\n>>>>>>>> according to the documentation been introduced in meson 0.55 (see\n>>>>>>>> https://mesonbuild.com/CMake-module.html#configuration-options).\n>>>>>>>\n>>>>>>> The android feature is optional and disabled by default. I think there\n>>>>>>> is no option to have the minimum meson version selected automatically by\n>>>>>>> features (e.g. require 0.55 only if android=enabled).\n>>>>>>\n>>>>>> That's unfortunately correct.\n>>>>\n>>>> The frustrating part is that for large part 'distributions' will not\n>>>> build the android component. Only 'specific' builds (CRoS/AOSP) will\n>>>> enable that.\n>>>>\n>>>> Technically the android HAL could be split to a separate package /\n>>>> project in it's own repository, with it's own meson requriements. But\n>>>> until we formally stabilise ABI/API, I don't think that should happen.\n>>>>\n>>>>\n>>>>>>> In the official\n>>>>>>> documentation version 0.55 could still be required for android. But the\n>>>>>>> default version will build fine with 0.53 according to the official\n>>>>>>> build instructions.\n>>>>>>\n>>>>>> meson will then print this warning when building the Android HAL:\n>>>>>>\n>>>>>> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': subproject_options.\n>>>>>> WARNING: Project targeting '>= 0.53' but tried to use feature introduced in '0.55.0': options arg in subproject.\n>>>>>\n>>>>> That's correct, but it will only work if 0.55 is already installed. On\n>>>>> 0.53 it will just give an error if \"android=enabled\":\n>>>>>\n>>>>> ERROR: Module cmake does not have method subproject_options.\n>>>>>\n>>>>> Would the proposal above (keeping 0.53 for the default configuration and\n>>>>> documenting 0.55 for the android feature) be a viable option? That would\n>>>>> mean a build with android=enabled would show the above error, but it\n>>>>> would build after updating to 0.55.\n>>>>\n>>>> Had this been for any other part of libcamera it would have been an easy\n>>>> 'no, not really' - but because the android layer really is quite\n>>>> distinct, and only built for specific platforms who are expected to have\n>>>> full control over their build environment, ... I'm wavering...\n>>>>\n>>>> CRoS and Android builds will have a small non-blocking warning, while\n>>>> otherwise other distributions will have a hard failure.\n>>>>\n>>>> But to push me over the edge, I'd really want to see concrete examples\n>>>> of 'who' this will enable / support, so we can see a path to when we\n>>>> could increase it again.\n>>>\n>>> I am using libcamera in a robotic framework (ROS) to provide a camera\n>>> component for Raspberry PIs and other supported systems. Conveniently,\n>>> these components are distributed in binary via apt. If I want to have my\n>>> camera component distributed in binary form, the build server has to\n>>> satisfy all dependencies via distribution packages.\n>>>\n>>> So this will benefit all users that conveniently want to install this\n>>> component in binary form, in contrast to resolving dependencies and\n>>> building manually on a PC or Raspberry Pi.\n>>>\n>>>>\n>>>> I.e. I don't want t 'lock' ourselves out of ever taking on new meson features\n>>>> just to support Ubuntu 18.04...\n>>>>\n>>>>>\n>>>>> Best.\n>>>>>\n>>>>>>\n>>>>>>>>> From 1f7e62154e1d81c47fba777b3bf2893fec558b63 Mon Sep 17 00:00:00 2001\n>>>>>>>>> From: Christian Rauch \n>>>>>>>>> Date: Thu, 16 Dec 2021 23:53:31 +0000\n>>>>>>>>> Subject: meson: reduce required version to 0.53\n>>>>>>>>>\n>\n> I think we should add a bit more detail to the commit message for\n> example:\n>\n> \"\"\"\n> Building the libcamera Android layer currently makes use of features\n> from meson 0.55. The core libcamera framework without android enabled\n> makes use of the 'summary' feature available in 0.53, and is the lowest\n> supportable meson version if the Android HAL is excluded.\n>\n> Ubuntu 20.04 LTS currently provides meson 0.53 and represents an\n> acceptable minimum version to support. Platforms utilising the Android\n> component will have full control over their build environment and can\n> ensure that they provide a more recent version of meson.\n>\n> Reduce the supported meson version for the project to 0.53 to facilitate\n> building on more distributions without having to manually update the\n> meson package.\n> \"\"\"\n>\n>>>>>>>>> Signed-off-by: Christian Rauch \n>>>>>>>>>\n>>>>>>>>> diff --git a/meson.build b/meson.build\n>>>>>>>>> index a20cc29e..3bfd26fe 100644\n>>>>>>>>> --- a/meson.build\n>>>>>>>>> +++ b/meson.build\n>>>>>>>>> @@ -1,7 +1,7 @@\n>>>>>>>>> # SPDX-License-Identifier: CC0-1.0\n>>>>>>>>>\n>>>>>>>>> project('libcamera', 'c', 'cpp',\n>>>>>>>>> - meson_version : '>= 0.55',\n>>>>>>>>> + meson_version : '>= 0.53',\n>>>>\n>>>> This would need also need explicit commenting to say that it has been\n>>>> held back, while the android layer uses features from 0.55.\n>\n> This should certainly be added to your patch to get it in too.\n>\n>\n> --\n> Regards\n>\n> Kieran\n>\n>\n>>>>\n>>>> --\n>>>> Kieran\n>>>>\n>>>>\n>>>>>>>>> version : '0.0.0',\n>>>>>>>>> default_options : [\n>>>>>>>>> 'werror=true',\n>>>>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 317C4BE080\n\tfor ;\n\tTue, 21 Dec 2021 12:03:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 650E5608A2;\n\tTue, 21 Dec 2021 13:03:50 +0100 (CET)","from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D18FC60115\n\tfor ;\n\tTue, 21 Dec 2021 13:03:48 +0100 (CET)","from [192.168.1.209] ([92.26.26.152]) by mail.gmx.net (mrgmx004\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1M59C2-1n0kKW0btU-001Eb7;\n\tTue, 21 Dec 2021 13:03:48 +0100"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=gmx.net header.i=@gmx.net header.b=\"G/WM0x7m\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1640088228;\n\tbh=VEq6XIKO5SBmlB9SPDTvG1Wc4/5EGENPXnyP5HmTmfU=;\n\th=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To;\n\tb=G/WM0x7mpA1sijEEC0vl+e8HpDRnH/mldeJ6VAjaUhfx6jf0RrjViXQA61yFixKQs\n\tnZHkzb/0DIsINN2j8g8DwdWbNIyYucvWc7vyDhLe50V0uTbHZfXqiwPkyL6e9SP9Jl\n\t9CL/KV3B0e4bQQ+rUO1+Pq9Be50Z4HCkM+WjHZtI=","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"Kieran Bingham ,\n\tLaurent Pinchart ","References":"<2abeff7b-1ded-e075-32d9-5e9e22d67d98@gmx.de>\n\t\n\t<9bf03479-7ad6-46ae-8728-2b5630202fde@gmx.de>\n\t\n\t\n\t<163973332662.2512616.4331341617980653391@Monstersaurus>\n\t<6b54b614-434a-edd8-ff8d-3e981ff5a737@gmx.de>\n\t<8b0279eb-038a-269f-5d47-ebf9a911d467@gmx.de>\n\t<164008366256.2512616.9846928356781164241@Monstersaurus>","From":"Christian Rauch ","Message-ID":"<536bce26-d763-9cca-08e9-e396a3def755@gmx.de>","Date":"Tue, 21 Dec 2021 12:03:48 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.14.0","MIME-Version":"1.0","In-Reply-To":"<164008366256.2512616.9846928356781164241@Monstersaurus>","Content-Type":"multipart/mixed;\n\tboundary=\"------------4044F9044D41660FADCC6CEA\"","Content-Language":"en-GB","X-Provags-ID":"V03:K1:7UKU915/mkIYuCOpSgm8EWwnjPSM/73hvrqLCgjhDW3uH40nAsL\n\tySw9L9jOlYhrK+yLOd+Cdt+UtRWylwVtumahEI1S+lYThz7Hpmfq8LDAoPMk7cwU5YwQwdW\n\tHMH1vuKaJOkfTKHlX1Ab8v7JfP3OVpAP52/VyWj1v98rXxB3BE+E8RRMZ4XSz58Ns+uV913\n\tFM9xpv5cQMpcBtOeKCGBQ==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:mHm1KzRCMYk=:VcdV0/BneMpDBlJkccWmlX\n\tMZfOUVULZpxC60H2mlyigTKuTdf17BpPan2yeGSKZQZrAjsZdP8h6SUzPLa87mbS5P9XAbLgi\n\tNm/vViJjgDNMy2ajPTEReEVk/+bEOx8GOLvxSBLCsxS2KQVOzs1xqjwxbu8EuTw7GjnIANnXH\n\tUT2bJD89GIuJ4rAdGJ8E+oom+flcIVbnjj9wwyW3c4TJhRqpj9VpcYUa8+7VQurmzFN1sp403\n\tBY7ywUYMAp0cRMayVli7k4rQk914Q7OkAPSy71WoXpcxAZs4joSRoEI8VSPDssoP1BqRKaUsU\n\t7OmzD0+xG0x0muzLOYoHEDKZZLFbx+xldum746kC7HgfapwdOe+87Gdc9p3WGhFi3ybxbQ/tT\n\tSxLtntgP9eH/b6ATmnfAU239C1aFFss+0IfT7WQSBchf8Wd57tRw3gf/1Brj8t4ekWB5F+Ucy\n\ta7/YXMWN/vXe4D3nbrTIkbUopZjNsIe1c13SKXW5A9Z45KB9t0CuThVLzbxm7AoY3wqRoc7gW\n\t08aj0r589VBsZW1d6Wq6PLRhlpNVbTHnVkeuB2CF68LsiAgOZ8l7Izp6jDiNglHP0zwy4hj23\n\tfsTDBSLtuJEuRdcVp/qlIq6ZStFsbKFQPippFekikxEQcnYmQoXGKhfTlzGX+9IJHQ4Kg0gch\n\tdVU+OGadjgMfTVOKV+mfbPqSUitL5QZjF2tiKJytogRSXynQxfOnQA03gJGTkooHWeJ2X0jcF\n\ttoG+NthYfWL17n0SoN1xRzy0qkjjATV4Q7ApwvieIl3SgNh5t+7xAD6INwNLrNn9Xka/UEL3L\n\tSvtSlnGU0cM5DexO8meKCQBZYMHQe+TGy8Kj/Vgd353Km+EZYHlHkMLaAefm+NoVbR17fm396\n\t1GhhYRkRXuRP3anMWxf6IwuIgleY9rGiqUfut/2SNr1XQ0AOGxQO0tGJeYbjqztVDADsgBhbl\n\tIN8xlvdGJjajaCi7HD8GrPCZScf6mSmJ47b86ZhPgET+fvfVNSW8CKwIbQPCSCp/ZCS0QFC1q\n\txWINKLLmRUirM0fQeT2cfYwbi1jB2JCTjNqncOre9tQLJYWUMB4GCH/OlmQRALWL50MvRujSo\n\t8CGMKtU6mqMOag=","Subject":"Re: [libcamera-devel] [PATCH] meson: reduce required version to 0.53","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]