[{"id":21752,"web_url":"https://patchwork.libcamera.org/comment/21752/","msgid":"<20211210144725.7pwno7xpj4nq65zz@uno.localdomain>","date":"2021-12-10T14:47:25","subject":"Re: [libcamera-devel] [PATCH v12 6/8] libcamera: v4l2_subdevice:\n\tSupport passing ColorSpaces to V4L2 subdevices","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi David\n\nOn Fri, Dec 10, 2021 at 02:44:22PM +0000, David Plowman wrote:\n> The ColorSpace from the StreamConfiguration is now handled\n> appropriately in the V4L2Subdevice.\n>\n> Signed-off-by: David Plowman \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index b782325a..fa216e85 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -415,6 +415,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> \tformat->size.width = subdevFmt.format.width;\n> \tformat->size.height = subdevFmt.format.height;\n> \tformat->mbus_code = subdevFmt.format.code;\n> +\tformat->colorSpace = toColorSpace(subdevFmt.format);\n>\n> \treturn 0;\n> }\n> @@ -442,6 +443,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> \tsubdevFmt.format.height = format->size.height;\n> \tsubdevFmt.format.code = format->mbus_code;\n> \tsubdevFmt.format.field = V4L2_FIELD_NONE;\n> +\tfromColorSpace(format->colorSpace, subdevFmt.format);\n>\n> \tint ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n> \tif (ret) {\n> @@ -454,6 +456,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> \tformat->size.width = subdevFmt.format.width;\n> \tformat->size.height = subdevFmt.format.height;\n> \tformat->mbus_code = subdevFmt.format.code;\n> +\tformat->colorSpace = toColorSpace(subdevFmt.format);\n>\n> \treturn 0;\n> }\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7959ABDB13\n\tfor ;\n\tFri, 10 Dec 2021 14:46:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3750C6089C;\n\tFri, 10 Dec 2021 15:46:36 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCBE460868\n\tfor ;\n\tFri, 10 Dec 2021 15:46:34 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 5A80B24000B;\n\tFri, 10 Dec 2021 14:46:33 +0000 (UTC)"],"Date":"Fri, 10 Dec 2021 15:47:25 +0100","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20211210144725.7pwno7xpj4nq65zz@uno.localdomain>","References":"<20211210144424.14747-1-david.plowman@raspberrypi.com>\n\t<20211210144424.14747-7-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211210144424.14747-7-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v12 6/8] libcamera: v4l2_subdevice:\n\tSupport passing ColorSpaces to V4L2 subdevices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomasz Figa , libcamera-devel@lists.libcamera.org,\n\tHans Verkuil ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]