{"id":15110,"url":"https://patchwork.libcamera.org/api/patches/15110/?format=json","web_url":"https://patchwork.libcamera.org/patch/15110/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211210112142.18441-7-david.plowman@raspberrypi.com>","date":"2021-12-10T11:21:40","name":"[libcamera-devel,v11,6/8] libcamera: v4l2_subdevice: Support passing ColorSpaces to V4L2 subdevices","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3af331aa059a54a00b09e4c2dfe80eb32d96d35d","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15110/mbox/","series":[{"id":2834,"url":"https://patchwork.libcamera.org/api/series/2834/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2834","date":"2021-12-10T11:21:34","name":"Colour spaces","version":11,"mbox":"https://patchwork.libcamera.org/series/2834/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15110/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15110/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94D55C3258\n\tfor ;\n\tFri, 10 Dec 2021 11:22:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F404608E5;\n\tFri, 10 Dec 2021 12:22:12 +0100 (CET)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCD366088E\n\tfor ;\n\tFri, 10 Dec 2021 12:22:07 +0100 (CET)","by mail-wm1-x32a.google.com with SMTP id i12so6546811wmq.4\n\tfor ;\n\tFri, 10 Dec 2021 03:22:07 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tz18sm2198469wrq.11.2021.12.10.03.22.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 10 Dec 2021 03:22:07 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Wrl2E789\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=K60rAz66vWi9F057w7dISj11FLoL/9HFVty+RyVxed8=;\n\tb=Wrl2E789/shUI1lgPdW4mncRL11LlTL/CVwhjNq67rK8hBiuGmasOuKl9shwDTqPrX\n\tCXNTkZNVesEzOwLKbuGqm19ZJwltvkR+DB/z8Ekf538Ehvyv4EEGRhs+c2MISzxjGRI0\n\tkT7nEtp8xOte53ZNADhwSdbW1tmj+A6eO2bnaVvlDmHVUqyvz85UXXN1RAlxLVw6LSC+\n\ttTjchHcPeuGiIrqljVA6rxvxtprq/BzwdPhlJtHxi00L8faxm0QUmXOcziCgVupXvFdG\n\tFfCllRtlNFdRcSkCw1ItfSAGlKD7eCnjAJTJIFRzxBeKUPl8hhxs/22F4U1FrTu5lUoX\n\tjDag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=K60rAz66vWi9F057w7dISj11FLoL/9HFVty+RyVxed8=;\n\tb=XBrooQTiOaIWpdtjKvQiU8NY0qreKYKx5pYpsZ3lI//wK6pf9MWTqyM1oWeoVxXbrE\n\tD/yOmIm4vvRkIUJCgiMBby0at2FGHJbOq6GYPPPIxRCMOi3xeZZf8gIbFYghubenL1Kv\n\tWhMElu0E/zWcJ8Y/eVf5M8FMdUxHe6mSL36SPhgbp8XT31RzQAIdb4dBTd+Nxf8iwkoT\n\tEBcErdt6n0oFVo9oj4slBd/q1Jg4lQz0MK/UKP9stK6KvGaRAAkPGN9jmr3TKbMpZfgK\n\tC5CbjaF9iuwUwTl+uYNFMUQgfCES5yeCmyLnF9rjYePqqoRBurBm3pv8ksgsGnTRSnPF\n\t9s4w==","X-Gm-Message-State":"AOAM532Tu4fggJ2421BcTwN7329b8mvWprxBTZ1qRncFz6vmGJwGScvO\n\tjKKq/8TVvUtaoJudVWsB5aRtkA==","X-Google-Smtp-Source":"ABdhPJwc4sJk9+Lsw8/M5jbaGdFQK6n3RkpRNhWiw6LaIxLB3S4D7ImedTsIMWBdhKdGwXxUPzs76w==","X-Received":"by 2002:a05:600c:4154:: with SMTP id\n\th20mr15518918wmm.189.1639135327516; \n\tFri, 10 Dec 2021 03:22:07 -0800 (PST)","From":"David Plowman ","To":"Laurent Pinchart ,\n\tKieran Bingham ,\n\tHans Verkuil , Tomasz Figa , \n\tJacopo Mondi ,\n\tNaushir Patuck , \n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 10 Dec 2021 11:21:40 +0000","Message-Id":"<20211210112142.18441-7-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20211210112142.18441-1-david.plowman@raspberrypi.com>","References":"<20211210112142.18441-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v11 6/8] libcamera: v4l2_subdevice:\n\tSupport passing ColorSpaces to V4L2 subdevices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ColorSpace from the StreamConfiguration is now handled\nappropriately in the V4L2Subdevice.\n\nSigned-off-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/v4l2_subdevice.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex b782325a..8caa73d6 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -415,6 +415,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tformat->size.width = subdevFmt.format.width;\n \tformat->size.height = subdevFmt.format.height;\n \tformat->mbus_code = subdevFmt.format.code;\n+\tformat->colorSpace = toColorSpace(subdevFmt.format);\n \n \treturn 0;\n }\n@@ -443,7 +444,13 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tsubdevFmt.format.code = format->mbus_code;\n \tsubdevFmt.format.field = V4L2_FIELD_NONE;\n \n-\tint ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n+\tint ret = fromColorSpace(format->colorSpace, subdevFmt.format);\n+\tif (ret < 0)\n+\t\tLOG(V4L2, Warning)\n+\t\t\t<< \"Setting color space unrecognised by V4L2: \"\n+\t\t\t<< ColorSpace::toString(format->colorSpace);\n+\n+\tret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n \tif (ret) {\n \t\tLOG(V4L2, Error)\n \t\t\t<< \"Unable to set format on pad \" << pad\n@@ -454,6 +461,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \tformat->size.width = subdevFmt.format.width;\n \tformat->size.height = subdevFmt.format.height;\n \tformat->mbus_code = subdevFmt.format.code;\n+\tformat->colorSpace = toColorSpace(subdevFmt.format);\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","v11","6/8"]}