[{"id":21734,"web_url":"https://patchwork.libcamera.org/comment/21734/","msgid":"<163913541690.2512616.1780878750255411840@Monstersaurus>","date":"2021-12-10T11:23:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: Restrict .gitignore build/\n\tand patches/ to the root directory","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-12-09 20:28:18)\n> The build/ and patches/ directories are listed in .gitignore as they're\n> commonly used respectively as the meson build directory (this is the\n> directory name used in README.rst) and as a local patches store (this\n> usage pattern isn't official though, and may need to be reconsidered if\n> not used anymore). As those two directories are supposed to be at the\n> root of the source tree, restrict the corresponding .gitignore patterns\n> to avoid matching other locations.\n> \n> While at it, sort the entries alphabetically, with the absolute path\n> entries separate from the entries that match any location within the\n> source tree.\n> \n> Signed-off-by: Laurent Pinchart \n\nFine with me.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> .gitignore | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/.gitignore b/.gitignore\n> index d3d73615bac1..f6d1d68e4a7c 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -1,7 +1,8 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> -__pycache__/\n> -build/\n> -patches/\n> +/build/\n> +/patches/\n> +\n> *.patch\n> *.pyc\n> +__pycache__/\n> \n> base-commit: f16acb275c85518c13e81ffa6503347abcc01dc5\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB686BF415\n\tfor ;\n\tFri, 10 Dec 2021 11:23:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93D9460894;\n\tFri, 10 Dec 2021 12:23:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DA9E6087E\n\tfor ;\n\tFri, 10 Dec 2021 12:23:39 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28925F84;\n\tFri, 10 Dec 2021 12:23:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fp3hI8Ee\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639135419;\n\tbh=IVIcCVwpiCevy9z5U86/jYWz6KCH/3E8+P4We0dSwcA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Fp3hI8EegkMb0csavSP8QVHdT7atIWXIfRDQdjYEXzOC15TYK+dKZGvsjpa2CdALp\n\t33k3oeoHtQTUHK6SGwkfg3sqnOcdmvWOYieo04W5FAnRGkYa18f907GNGkISlh64i/\n\tPcRKB62RBEerqbvjEkfINQrRm84x0LaDM1GMRUQw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211209202818.29950-1-laurent.pinchart@ideasonboard.com>","References":"<20211209202818.29950-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 10 Dec 2021 11:23:36 +0000","Message-ID":"<163913541690.2512616.1780878750255411840@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Restrict .gitignore build/\n\tand patches/ to the root directory","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21776,"web_url":"https://patchwork.libcamera.org/comment/21776/","msgid":"<20211214095529.sfsiwrjlt4dxw6j2@uno.localdomain>","date":"2021-12-14T09:55:29","subject":"Re: [libcamera-devel] [PATCH] libcamera: Restrict .gitignore build/\n\tand patches/ to the root directory","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Thu, Dec 09, 2021 at 10:28:18PM +0200, Laurent Pinchart wrote:\n> The build/ and patches/ directories are listed in .gitignore as they're\n> commonly used respectively as the meson build directory (this is the\n> directory name used in README.rst) and as a local patches store (this\n> usage pattern isn't official though, and may need to be reconsidered if\n> not used anymore). As those two directories are supposed to be at the\n> root of the source tree, restrict the corresponding .gitignore patterns\n> to avoid matching other locations.\n>\n> While at it, sort the entries alphabetically, with the absolute path\n> entries separate from the entries that match any location within the\n> source tree.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> .gitignore | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/.gitignore b/.gitignore\n> index d3d73615bac1..f6d1d68e4a7c 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -1,7 +1,8 @@\n> # SPDX-License-Identifier: CC0-1.0\n>\n> -__pycache__/\n> -build/\n> -patches/\n> +/build/\n> +/patches/\n> +\n> *.patch\n> *.pyc\n> +__pycache__/\n>\n> base-commit: f16acb275c85518c13e81ffa6503347abcc01dc5\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71D29BF415\n\tfor ;\n\tTue, 14 Dec 2021 09:54:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 324C4608A4;\n\tTue, 14 Dec 2021 10:54:38 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D62C600CA\n\tfor ;\n\tTue, 14 Dec 2021 10:54:36 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id D32D4240005;\n\tTue, 14 Dec 2021 09:54:35 +0000 (UTC)"],"Date":"Tue, 14 Dec 2021 10:55:29 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20211214095529.sfsiwrjlt4dxw6j2@uno.localdomain>","References":"<20211209202818.29950-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211209202818.29950-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Restrict .gitignore build/\n\tand patches/ to the root directory","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]