[{"id":21691,"web_url":"https://patchwork.libcamera.org/comment/21691/","msgid":"<163904330786.2066819.9593336053113424558@Monstersaurus>","date":"2021-12-09T09:48:27","subject":"Re: [libcamera-devel] [RFC v3 3/5] gitignore: add .cache","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Tomi Valkeinen (2021-12-09 09:29:04)\n> clangd produces a .cache directory. Add it to .gitignore.\n> \n\nI don't use clangd (maybe I should?) so this sounds quite specific to\nyour use case, but I don't object to it. A '.cache' certainly shouldn't\never get commited.\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> .gitignore | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/.gitignore b/.gitignore\n> index d3d73615..cca829fa 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -5,3 +5,4 @@ build/\n> patches/\n> *.patch\n> *.pyc\n> +.cache\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C846BF415\n\tfor ;\n\tThu, 9 Dec 2021 09:48:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA61160822;\n\tThu, 9 Dec 2021 10:48:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1470D60224\n\tfor ;\n\tThu, 9 Dec 2021 10:48:31 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5658501;\n\tThu, 9 Dec 2021 10:48:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qIZKrquN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639043310;\n\tbh=tkRScCzuveVOuZTycfZABRsH8YtXNkGISpEVsTPztEE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=qIZKrquN8XmjvmZQvVuxfUWg56aGE67cKza4z8aP7JSfQLpin3OgPWCORy1LTzh+s\n\tM49/QDDj1RKWAlxLRhbejiM2UcYh4Q2TVXFDBr+inGhFNnXTkOGnA1WP43yKJAMjFG\n\t3ndX5ezBeVhvNugO/F3VAdNzGtdPOvdznkeOl+bU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211209092906.37303-4-tomi.valkeinen@ideasonboard.com>","References":"<20211209092906.37303-1-tomi.valkeinen@ideasonboard.com>\n\t<20211209092906.37303-4-tomi.valkeinen@ideasonboard.com>","From":"Kieran Bingham ","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 09 Dec 2021 09:48:27 +0000","Message-ID":"<163904330786.2066819.9593336053113424558@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [RFC v3 3/5] gitignore: add .cache","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21718,"web_url":"https://patchwork.libcamera.org/comment/21718/","msgid":"","date":"2021-12-09T16:56:31","subject":"Re: [libcamera-devel] [RFC v3 3/5] gitignore: add .cache","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Thu, Dec 09, 2021 at 11:29:04AM +0200, Tomi Valkeinen wrote:\n> clangd produces a .cache directory. Add it to .gitignore.\n> \n> Signed-off-by: Tomi Valkeinen \n> ---\n> .gitignore | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/.gitignore b/.gitignore\n> index d3d73615..cca829fa 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -5,3 +5,4 @@ build/\n> patches/\n> *.patch\n> *.pyc\n> +.cache\n\nIf this is a directory,\n\n.cache/\n\ncould be better. Is the directory created at the top level only, or are\nthere multiple directories through the source tree ? In the first case,\n/.cache/ could also be a better match (I'll submit a patch to turn\nbuild/ and patches/ into /build/ and /patches/).\n\nI'm not thrilled about adding ignore patterns related to third-party\ntools, but I'm not opposed to it either. I however wonder if this use\ncase wouldn't be better supported by a /.cache/ pattern in\n$XDG_CONFIG_HOME/git/ignore though, as that would allow you to use\nclangd in all projects without adding a patch similar to this in all of\nthem. What do you think ?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46D78BF415\n\tfor ;\n\tThu, 9 Dec 2021 16:57:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 739FA6087A;\n\tThu, 9 Dec 2021 17:57:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EF70607DE\n\tfor ;\n\tThu, 9 Dec 2021 17:57:01 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9E84501;\n\tThu, 9 Dec 2021 17:57:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HoIQ2iiP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639069021;\n\tbh=IjYqxHdhN3aGK4WPjibITjXkK1hpEn3BZAoes/cyLCU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HoIQ2iiPomdYkwMjwWiXN05cG6zy3dWNKD78TTBvL3uslvP8eCB7/tCL1PebyJZCq\n\tMMEYxruzaYBECoQEwqY1wojqjkw0MPXhl2g4OfNnXOIx0A2G+75oH4pKN5i0vIBCfN\n\tZZGUQZL4AFkTLFPib2fsZ/DdfTGcewyIGPefhXgA=","Date":"Thu, 9 Dec 2021 18:56:31 +0200","From":"Laurent Pinchart ","To":"Tomi Valkeinen ","Message-ID":"","References":"<20211209092906.37303-1-tomi.valkeinen@ideasonboard.com>\n\t<20211209092906.37303-4-tomi.valkeinen@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211209092906.37303-4-tomi.valkeinen@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC v3 3/5] gitignore: add .cache","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21737,"web_url":"https://patchwork.libcamera.org/comment/21737/","msgid":"<896f31e9-e22d-6f3a-42d4-1c4d517ace29@ideasonboard.com>","date":"2021-12-10T11:44:04","subject":"Re: [libcamera-devel] [RFC v3 3/5] gitignore: add .cache","submitter":{"id":109,"url":"https://patchwork.libcamera.org/api/people/109/","name":"Tomi Valkeinen","email":"tomi.valkeinen@ideasonboard.com"},"content":"On 09/12/2021 18:56, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> Thank you for the patch.\n> \n> On Thu, Dec 09, 2021 at 11:29:04AM +0200, Tomi Valkeinen wrote:\n>> clangd produces a .cache directory. Add it to .gitignore.\n>>\n>> Signed-off-by: Tomi Valkeinen \n>> ---\n>> .gitignore | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/.gitignore b/.gitignore\n>> index d3d73615..cca829fa 100644\n>> --- a/.gitignore\n>> +++ b/.gitignore\n>> @@ -5,3 +5,4 @@ build/\n>> patches/\n>> *.patch\n>> *.pyc\n>> +.cache\n> \n> If this is a directory,\n> \n> .cache/\n> \n> could be better. Is the directory created at the top level only, or are\n> there multiple directories through the source tree ? In the first case,\n> /.cache/ could also be a better match (I'll submit a patch to turn\n> build/ and patches/ into /build/ and /patches/).\n> \n> I'm not thrilled about adding ignore patterns related to third-party\n> tools, but I'm not opposed to it either. I however wonder if this use\n> case wouldn't be better supported by a /.cache/ pattern in\n> $XDG_CONFIG_HOME/git/ignore though, as that would allow you to use\n> clangd in all projects without adding a patch similar to this in all of\n> them. What do you think ?\n\nYes, I can do that.\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48D80BF415\n\tfor ;\n\tFri, 10 Dec 2021 11:44:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A832760894;\n\tFri, 10 Dec 2021 12:44:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7715D6087E\n\tfor ;\n\tFri, 10 Dec 2021 12:44:07 +0100 (CET)","from [192.168.1.111] (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B20EF84;\n\tFri, 10 Dec 2021 12:44:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p2KYTQcg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1639136647;\n\tbh=UH6FMUFoUqxTrLYoeG5zUEYNP7R/V0RtOkfH7Rykr5Y=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=p2KYTQcggcfinhFWxFr3ij4PYGOAsTxufr8rNwJKWTCgMshQCjP1tPh8tjF/JRk87\n\tL1Y6jPiHIFzbBzUAPSXHqGGyRgdUW8DQn6rBl1F81wqSiL5hEqkSb1KjuzeE9qHY2K\n\tODX7w0UVf339CJH60v3chRSbGV9qGQbILlT6EjFU=","To":"Laurent Pinchart ","References":"<20211209092906.37303-1-tomi.valkeinen@ideasonboard.com>\n\t<20211209092906.37303-4-tomi.valkeinen@ideasonboard.com>\n\t","From":"Tomi Valkeinen ","Message-ID":"<896f31e9-e22d-6f3a-42d4-1c4d517ace29@ideasonboard.com>","Date":"Fri, 10 Dec 2021 13:44:04 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.14.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC v3 3/5] gitignore: add .cache","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]