[{"id":21665,"web_url":"https://patchwork.libcamera.org/comment/21665/","msgid":"","date":"2021-12-08T11:13:33","subject":"Re: [libcamera-devel] [PATCH 1/2] pipeline: raspberrypi: Reduce\n\tlogging verbosity","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this change. I agree that a bit less console-spamming is\nprobably a good thing!\n\nOn Wed, 8 Dec 2021 at 09:42, Naushir Patuck wrote:\n>\n> Demote a couple of lines of logging to Debug level to reduce the verbosity of\n> the log output during startup.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 62db8f26b77d..4479e732a645 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -162,10 +162,10 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size &\n> bestFormat.size = size;\n> }\n>\n> - LOG(RPI, Info) << \"Format: \" << size.toString()\n> - << \" fmt \" << format.toString()\n> - << \" Score: \" << score\n> - << \" (best \" << bestScore << \")\";\n> + LOG(RPI, Debug) << \"Format: \" << size.toString()\n> + << \" fmt \" << format.toString()\n> + << \" Score: \" << score\n> + << \" (best \" << bestScore << \")\";\n> }\n> }\n>\n> @@ -1747,8 +1747,8 @@ void RPiCameraData::checkRequestCompleted()\n> state_ = State::Idle;\n> if (dropFrameCount_) {\n> dropFrameCount_--;\n> - LOG(RPI, Info) << \"Dropping frame at the request of the IPA (\"\n> - << dropFrameCount_ << \" left)\";\n> + LOG(RPI, Debug) << \"Dropping frame at the request of the IPA (\"\n> + << dropFrameCount_ << \" left)\";\n> }\n> }\n> }\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3429BDB13\n\tfor ;\n\tWed, 8 Dec 2021 11:13:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BB0A60725;\n\tWed, 8 Dec 2021 12:13:47 +0100 (CET)","from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D391F60225\n\tfor ;\n\tWed, 8 Dec 2021 12:13:44 +0100 (CET)","by mail-wr1-x435.google.com with SMTP id a18so3432346wrn.6\n\tfor ;\n\tWed, 08 Dec 2021 03:13:44 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"AUtcVrxL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=6V3SvHWMbSAqCay5c2GFSog9r/zDZKwxPF0W0lDEm+g=;\n\tb=AUtcVrxL18s81zlnry4Pqacnma1O1kDZknCipYfIYFtr2dknid3ovN6pzLAJqastsz\n\tEr5pyCnvrKufrVfuELWhEte26Jg1040rOiS43uKxnnGm5Z1HGQm0AbjaHiu5u222nSmT\n\tGlyKATzoCZsiZzLkhdAisGzdn22WV9Zt4ZWpSOfutUXnq2ly1CRupH0qSSs5UmFRbP9W\n\tIsHuCLZ7NtCm9piQaKaHOMQBUOT/gQqldTw7UyEmB2dvzooTnDlsCNckgV4b4muc48Iu\n\tsdUjldtV0nKOSdw3RwuxwEDQxpw7GKvCPDRjpi1gEU1l6fgcHRzDd9VXDePtmRxqdfUS\n\tk1NA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=6V3SvHWMbSAqCay5c2GFSog9r/zDZKwxPF0W0lDEm+g=;\n\tb=O+j465uDFOsy3dqAzlSEf4vOqWSyOsR2iqMHuxmruhwcmgfb6AMZj2ZpvQtzi43jEV\n\tWumQP/cNV0q5fLXxKWMQ5SSNULTYHWV2/B2JYxVjC5t5ROR9kp3y9KJdYe3REpdurawp\n\tl9xbeAT0Q9QJo522MDfwErkPdN4HRY4YxAyxjt/AlD34OA6mMo2xRR0oDVV0jM8Awvom\n\t0s9/+LiQnYpYDEPrEhT9oH+LGJCQfOS0cbvSwtTW3w5Mq2bgNAj8IaNHjD/ymeimB+v8\n\tLjDKj7f1BytCbedKrmJOzYfPhwgsoAJ2ndilb5i873y3WA9iu0E0sIAggy7lStlKwL2T\n\tpPGA==","X-Gm-Message-State":"AOAM532rGD3+ibeCMcXej1WyWExb3VZ1XbYrmiEw5oZH15C6c848sSXd\n\tLrZFIJuVYQl7qpiCLYEd0/MTut/sEK5TdXn5BXW8yy4c87F4ww==","X-Google-Smtp-Source":"ABdhPJxEBUv0e8cv0YUA4iiIz+tDCBRffce1c7eOpkc3g8dKCTecixqYNFd79L404/ERuTcq1q6FE4oEpjo4BmLEHy0=","X-Received":"by 2002:a5d:52c2:: with SMTP id\n\tr2mr59227478wrv.548.1638962024383; \n\tWed, 08 Dec 2021 03:13:44 -0800 (PST)","MIME-Version":"1.0","References":"<20211208094211.1251311-1-naush@raspberrypi.com>","In-Reply-To":"<20211208094211.1251311-1-naush@raspberrypi.com>","From":"David Plowman ","Date":"Wed, 8 Dec 2021 11:13:33 +0000","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/2] pipeline: raspberrypi: Reduce\n\tlogging verbosity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21668,"web_url":"https://patchwork.libcamera.org/comment/21668/","msgid":"<163896374615.995700.7892605673477070980@Monstersaurus>","date":"2021-12-08T11:42:26","subject":"Re: [libcamera-devel] [PATCH 1/2] pipeline: raspberrypi: Reduce\n\tlogging verbosity","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2021-12-08 09:42:10)\n> Demote a couple of lines of logging to Debug level to reduce the verbosity of\n> the log output during startup.\n> \n> Signed-off-by: Naushir Patuck \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 62db8f26b77d..4479e732a645 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -162,10 +162,10 @@ V4L2SubdeviceFormat findBestFormat(const SensorFormats &formatsMap, const Size &\n> bestFormat.size = size;\n> }\n> \n> - LOG(RPI, Info) << \"Format: \" << size.toString()\n> - << \" fmt \" << format.toString()\n> - << \" Score: \" << score\n> - << \" (best \" << bestScore << \")\";\n> + LOG(RPI, Debug) << \"Format: \" << size.toString()\n> + << \" fmt \" << format.toString()\n> + << \" Score: \" << score\n> + << \" (best \" << bestScore << \")\";\n> }\n> }\n> \n> @@ -1747,8 +1747,8 @@ void RPiCameraData::checkRequestCompleted()\n> state_ = State::Idle;\n> if (dropFrameCount_) {\n> dropFrameCount_--;\n> - LOG(RPI, Info) << \"Dropping frame at the request of the IPA (\"\n> - << dropFrameCount_ << \" left)\";\n> + LOG(RPI, Debug) << \"Dropping frame at the request of the IPA (\"\n> + << dropFrameCount_ << \" left)\";\n> }\n> }\n> }\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13A33BF415\n\tfor ;\n\tWed, 8 Dec 2021 11:42:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C1BD60725;\n\tWed, 8 Dec 2021 12:42:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F40F760225\n\tfor ;\n\tWed, 8 Dec 2021 12:42:28 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B0558BB;\n\tWed, 8 Dec 2021 12:42:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r13pu2PH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638963748;\n\tbh=CA+VzPfePHtSNBVfdZ8hcRauG3G74Jn3x7cx0vvP7mE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=r13pu2PH5/uu/yLmGh8a+RUjldfyhvab4qLinMJKr94CaIiQCF8xDemgJpnLMWXq1\n\tpugMVuPuRW+81GsYPzfJPJR1voJs2MHEYqeGQljxZaYOxA7glldOnclX1xqcs1YGZM\n\t7K5/NMGWBTBSNjT42fxxHxNGw+uh+oYJ/za/2qHw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211208094211.1251311-1-naush@raspberrypi.com>","References":"<20211208094211.1251311-1-naush@raspberrypi.com>","From":"Kieran Bingham ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 08 Dec 2021 11:42:26 +0000","Message-ID":"<163896374615.995700.7892605673477070980@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/2] pipeline: raspberrypi: Reduce\n\tlogging verbosity","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]