[{"id":21621,"web_url":"https://patchwork.libcamera.org/comment/21621/","msgid":"","date":"2021-12-07T00:11:38","subject":"Re: [libcamera-devel] [PATCH 7/8] gstreamer: gstlibcamerasrc: Fix\n\tinclude ordering","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Dec 06, 2021 at 11:39:47PM +0000, Kieran Bingham wrote:\n> The libcamera coding style has libcamera headers after system headers,\n> and before any other library headers.\n> \n> Move the libcamera headers above the Gst headers accordingly.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 812ba7a2bd6e..c7292f66b17b 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -32,11 +32,11 @@\n> #include \n> #include \n> \n> -#include \n> -\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"gstlibcameraallocator.h\"\n> #include \"gstlibcamerapad.h\"\n> #include \"gstlibcamerapool.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51AD8BF415\n\tfor ;\n\tTue, 7 Dec 2021 00:12:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF9C26086C;\n\tTue, 7 Dec 2021 01:12:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDF3E60117\n\tfor ;\n\tTue, 7 Dec 2021 01:12:06 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 676F9556;\n\tTue, 7 Dec 2021 01:12:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EVQkiCAb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638835926;\n\tbh=mCXNYSho2av5dt0vsMn+3lFyDbg3fGgMMtFEJP2b1k4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EVQkiCAbHb5cVzV/CUpStm9U3A2Ab18KlzESMMY/KLuLcJUlBQd2unWckMiSM4Wvz\n\tig+IOYeJns6ieFiWV4o49b05xTa8kfqkqkfUwy5OsMvfLwX26NzZO/DNN2xxCZ4quJ\n\tBL79WA0hdbMZ73Qhf7ePe/JbvynXEaMsGHIoMquU=","Date":"Tue, 7 Dec 2021 02:11:38 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>\n\t<20211206233948.1351206-8-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211206233948.1351206-8-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 7/8] gstreamer: gstlibcamerasrc: Fix\n\tinclude ordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21642,"web_url":"https://patchwork.libcamera.org/comment/21642/","msgid":"","date":"2021-12-07T13:58:44","subject":"Re: [libcamera-devel] [PATCH 7/8] gstreamer: gstlibcamerasrc: Fix\n\tinclude ordering","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi\n\nOn 12/7/21 5:09 AM, Kieran Bingham wrote:\n> The libcamera coding style has libcamera headers after system headers,\n> and before any other library headers.\n>\n> Move the libcamera headers above the Gst headers accordingly.\n>\n> Signed-off-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 812ba7a2bd6e..c7292f66b17b 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -32,11 +32,11 @@\n> #include \n> #include \n> \n> -#include \n> -\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"gstlibcameraallocator.h\"\n> #include \"gstlibcamerapad.h\"\n> #include \"gstlibcamerapool.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4468BDB13\n\tfor ;\n\tTue, 7 Dec 2021 13:58:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6ABBF6086A;\n\tTue, 7 Dec 2021 14:58:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E1C660592\n\tfor ;\n\tTue, 7 Dec 2021 14:58:52 +0100 (CET)","from [IPv6:2401:4900:1f3e:16f1:4e1b:f869:54d4:8c0c] (unknown\n\t[IPv6:2401:4900:1f3e:16f1:4e1b:f869:54d4:8c0c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3335556;\n\tTue, 7 Dec 2021 14:58:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KPPV/BOV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638885532;\n\tbh=81KjPjyEDb/6tN4Lzd2FhoYzlZ3MRm0bInP8sx9FIPs=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=KPPV/BOVBLt1UkYlV6ZZsPs7BgN4YuuoLro0LuZMsUWiM9Su57XRbghuUWsXPmiPW\n\t/n8SobDiyDgXyAMDP5iE8MZNIxFL5vPbp4vue+PDYdhIsxzCC8kTxXENi49CkX/tQO\n\tTiOKHuF1X8LOBiKpoIxXf0DeZGj9rNZBv/g0GsHM=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>\n\t<20211206233948.1351206-8-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Tue, 7 Dec 2021 19:28:44 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211206233948.1351206-8-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 7/8] gstreamer: gstlibcamerasrc: Fix\n\tinclude ordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]