[{"id":21620,"web_url":"https://patchwork.libcamera.org/comment/21620/","msgid":"","date":"2021-12-07T00:10:49","subject":"Re: [libcamera-devel] [PATCH 5/8] qcam: main_window: Fix include\n\tordering","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Dec 06, 2021 at 11:39:45PM +0000, Kieran Bingham wrote:\n> The libcamera coding style has libcamera headers after system headers,\n> and before any other library headers.\n\nI've always considered the Qt headers to be part of the \"system\" from\nthe point of view of a Qt application :-)\n\n> Move the libcamera headers above the QT headers accordingly.\n\ns/QT/Qt/\n\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/qcam/main_window.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index ae51fa672a8c..dd0e51f55b70 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -11,6 +11,9 @@\n> #include \n> #include \n> \n> +#include \n> +#include \n> +\n> #include \n> #include \n> #include \n> @@ -25,9 +28,6 @@\n> #include \n> #include \n> \n> -#include \n> -#include \n> -\n> #include \"../cam/image.h\"\n> #include \"dng_writer.h\"\n> #ifndef QT_NO_OPENGL","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7BAFBF415\n\tfor ;\n\tTue, 7 Dec 2021 00:11:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 714D4607DE;\n\tTue, 7 Dec 2021 01:11:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB9D660117\n\tfor ;\n\tTue, 7 Dec 2021 01:11:17 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 618B6556;\n\tTue, 7 Dec 2021 01:11:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cwvwo06/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638835877;\n\tbh=mKg/+ORM2guCI824BW+/ZPVaO3vB5K+gxqDnocQkElU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cwvwo06/6BaUK/lFbU9FJ3cQL1U+TlNyS9oFalXAlTzdvsrDDaD8OqYb+PAkv/KZu\n\tHIetWSPRBbilcmv1Vu5Pcs0Yh9F6+ShYj3lL/vijIxA36lDBIYW6KFVmPWQuJqYzyn\n\toFeZLjEMbC8xG+x/lB6cz8sulOR7VkXGuZdJuSf0=","Date":"Tue, 7 Dec 2021 02:10:49 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>\n\t<20211206233948.1351206-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211206233948.1351206-6-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 5/8] qcam: main_window: Fix include\n\tordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21639,"web_url":"https://patchwork.libcamera.org/comment/21639/","msgid":"<097c77a1-8c0c-ab1c-22e5-ad9bbbc24d2e@ideasonboard.com>","date":"2021-12-07T13:56:59","subject":"Re: [libcamera-devel] [PATCH 5/8] qcam: main_window: Fix include\n\tordering","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi\n\nOn 12/7/21 5:09 AM, Kieran Bingham wrote:\n> The libcamera coding style has libcamera headers after system headers,\n> and before any other library headers.\n>\n> Move the libcamera headers above the QT headers accordingly.\n>\n> Signed-off-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/qcam/main_window.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index ae51fa672a8c..dd0e51f55b70 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -11,6 +11,9 @@\n> #include \n> #include \n> \n> +#include \n> +#include \n> +\n> #include \n> #include \n> #include \n> @@ -25,9 +28,6 @@\n> #include \n> #include \n> \n> -#include \n> -#include \n> -\n> #include \"../cam/image.h\"\n> #include \"dng_writer.h\"\n> #ifndef QT_NO_OPENGL","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1DD6BDB13\n\tfor ;\n\tTue, 7 Dec 2021 13:57:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A9236086A;\n\tTue, 7 Dec 2021 14:57:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF80460592\n\tfor ;\n\tTue, 7 Dec 2021 14:57:07 +0100 (CET)","from [IPv6:2401:4900:1f3e:16f1:4e1b:f869:54d4:8c0c] (unknown\n\t[IPv6:2401:4900:1f3e:16f1:4e1b:f869:54d4:8c0c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 717D8556;\n\tTue, 7 Dec 2021 14:57:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HhJsblUc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638885427;\n\tbh=mgYuJ3C1X65eiYO4AywdfHGcc7Mv9yPeHiuJrq1yznY=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HhJsblUcQwGOSerwseOlWR2wkCl9B7tamoJdP5I1Eb6uADr8Oz3Vv8UGs/jMOr8Uw\n\twA3sonIwB9zkpbta5lvvdWrdgr6VI2XddO5YWdEB2rGk9NkynYFv8gM2tkQ8EHpTpn\n\t5ehUa6n0eFVYdG8MA9paYrktBdKMmZqwP83w2gM8=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>\n\t<20211206233948.1351206-6-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<097c77a1-8c0c-ab1c-22e5-ad9bbbc24d2e@ideasonboard.com>","Date":"Tue, 7 Dec 2021 19:26:59 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211206233948.1351206-6-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 5/8] qcam: main_window: Fix include\n\tordering","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]