[{"id":21643,"web_url":"https://patchwork.libcamera.org/comment/21643/","msgid":"","date":"2021-12-07T14:01:05","subject":"Re: [libcamera-devel] [PATCH 1/8] libcamera: controls: Add\n\tSensorSequence metadata control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nThank you for your patch.\n\nOn Mon, 6 Dec 2021 at 23:39, Kieran Bingham \nwrote:\n\n> Provide a metadata control that allows pipeline handlers to report the\n> sequence number from the sensor for every request.\n>\n> This can be used to monitor and validate the sequence numbers of the\n> captured images and detect any frame drops.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/control_ids.yaml | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml\n> b/src/libcamera/control_ids.yaml\n> index 9d4638ae677e..8874fe75102c 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -381,6 +381,14 @@ controls:\n> \\todo Define how the sensor timestamp has to be used in the\n> reprocessing\n> use case.\n>\n> + - SensorSequence:\n> + type: int64_t\n> + description: |\n> + The monotonic sequence number from the sensor.\n> +\n> + Any break in the sequence number is an indication of frame drop\n> or error\n> + in the captured stream.\n> +\n>\n\nShould we add that there are no guarantees about this sequence number being\nreset on start/stop?\n\nReviewed-by: Naushir Patuck \n\n\n\n> #\n> ----------------------------------------------------------------------------\n> # Draft controls section\n>\n> --\n> 2.30.2\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C43BBBF415\n\tfor ;\n\tTue, 7 Dec 2021 14:01:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 164066086A;\n\tTue, 7 Dec 2021 15:01:24 +0100 (CET)","from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com\n\t[IPv6:2a00:1450:4864:20::12c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 325D360592\n\tfor ;\n\tTue, 7 Dec 2021 15:01:23 +0100 (CET)","by mail-lf1-x12c.google.com with SMTP id b40so33704818lfv.10\n\tfor ;\n\tTue, 07 Dec 2021 06:01:23 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FCzf83cU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=w7fIJdZy8WS8SEcB2bctDMi8OJBBYwB4VHCHDbSOTD8=;\n\tb=FCzf83cUbRpQD19LiD1oj8jqc1JfkSTljheXr4pE0SY0msDDtc7jA5tO8Nlgav9c6Q\n\tbcr3bkSya47Y8rQ0ynnl5njuYj4FWznga1PNA4UdoR09mh0+jcH8Nm3DKigVZsGZc2gj\n\tkXUXYz7H1oeU1AquNxVilmONLWZLWCPfUrSBGnFA6JRrYGZwmMLOVqeb1KjF7PfYfviX\n\tcwEF1xC4dACqRSV7nEnaB++jGpZlAoxkGfYwgKRWA+DceCmDOsIhuCHk7H9pMCE49XZp\n\tBg/1SxvYQoXzjuLbwoWO+Iw6+aQx7mQAIB0vlzmQ4GNddVJE0VO7eu1y4q1zsUJgnBrT\n\tHBRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=w7fIJdZy8WS8SEcB2bctDMi8OJBBYwB4VHCHDbSOTD8=;\n\tb=vfmx8QsTxaM/nQ73S0c8/WbdBy1Z56aobkB9Nh2FBeLZmIER8WQiNIBNN882jokXbU\n\teSg1pA53ZUiJ4Vig5MOICn57MLHRXEN/rDLGI7ixMYS9lAeq+DfjUllrPWdV8xGwho2l\n\tYOM0S3ktRRG+M6Bh6S5xU/cNzLhpzV78Q17ExFpFhjU6s3YiBtcGbK2Ts8Ikr4H5r8hR\n\t6hrXqUXI7MIkuXJ5V2RpqsGB22F5Dladr1lffvkNkKg7+lJzBM1eKWREwsFp0yzcEAPj\n\tSRCC5KBLW5530glztZcClP9JrrWowJFfRLGXaLJmfpMont3Ha9D36gbGYojgxpen7nOv\n\tZS3Q==","X-Gm-Message-State":"AOAM533qb+Ydnyi8uxQWJydH0Z/OZCq6VRfrCsizY1OVfFrhhKEotngH\n\twVuiACJEC7VRPdyklmsjWnOCQduveOOwf+gmOaSyq8obBsHHTg==","X-Google-Smtp-Source":"ABdhPJznj0foSqzq3bS5OC01afua0hPmtzzE4ZY4i7vfcwHlyeDClmkmdOpKkMKZjLy9+ziicN5CHayeuo0u4TJQwHw=","X-Received":"by 2002:ac2:518f:: with SMTP id\n\tu15mr42142223lfi.161.1638885681083; \n\tTue, 07 Dec 2021 06:01:21 -0800 (PST)","MIME-Version":"1.0","References":"<20211206233948.1351206-1-kieran.bingham@ideasonboard.com>\n\t<20211206233948.1351206-2-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20211206233948.1351206-2-kieran.bingham@ideasonboard.com>","From":"Naushir Patuck ","Date":"Tue, 7 Dec 2021 14:01:05 +0000","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"000000000000d94a8905d28ece33\"","Subject":"Re: [libcamera-devel] [PATCH 1/8] libcamera: controls: Add\n\tSensorSequence metadata control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]