[{"id":21630,"web_url":"https://patchwork.libcamera.org/comment/21630/","msgid":"","date":"2021-12-07T13:29:42","subject":"Re: [libcamera-devel] [PATCH v9 6/8] libcamera: Support passing\n\tColorSpaces to V4L2 subdevices","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Dec 06, 2021 at 10:50:29AM +0000, David Plowman wrote:\n> The ColorSpace from the StreamConfiguration is now handled\n> appropriately in the V4L2Subdevice.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/v4l2_subdevice.cpp | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 981645e0..f5ec6901 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -411,6 +411,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> \tformat->size.width = subdevFmt.format.width;\n> \tformat->size.height = subdevFmt.format.height;\n> \tformat->mbus_code = subdevFmt.format.code;\n> +\tformat->colorSpace = toColorSpace(subdevFmt.format);\n> \n> \treturn 0;\n> }\n> @@ -439,7 +440,13 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> \tsubdevFmt.format.code = format->mbus_code;\n> \tsubdevFmt.format.field = V4L2_FIELD_NONE;\n> \n> -\tint ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n> +\tint ret = fromColorSpace(format->colorSpace, subdevFmt.format);\n> +\tif (ret < 0)\n> +\t\tLOG(V4L2, Warning)\n> +\t\t\t<< \"Setting color space unrecognised by V4L2: \"\n> +\t\t\t<< ColorSpace::toString(format->colorSpace);\n\nSame comment as in 5/8 regarding the message.\n\nReviewed-by: Laurent Pinchart \n\n> +\n> +\tret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n> \tif (ret) {\n> \t\tLOG(V4L2, Error)\n> \t\t\t<< \"Unable to set format on pad \" << pad\n> @@ -450,6 +457,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> \tformat->size.width = subdevFmt.format.width;\n> \tformat->size.height = subdevFmt.format.height;\n> \tformat->mbus_code = subdevFmt.format.code;\n> +\tformat->colorSpace = toColorSpace(subdevFmt.format);\n> \n> \treturn 0;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7437ABDB13\n\tfor ;\n\tTue, 7 Dec 2021 13:30:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10D3660592;\n\tTue, 7 Dec 2021 14:30:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B241A60592\n\tfor ;\n\tTue, 7 Dec 2021 14:30:11 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 462EB556;\n\tTue, 7 Dec 2021 14:30:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tE7cCGK3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638883811;\n\tbh=d2OzR3wWwJjYykU52GRoN9nKnfmbLid/F2FctTH2j3Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tE7cCGK3Svh2XV9BuI/tDoJgB/v12uMBYPmYZJJ1inczQo45QipFqexZRlx74CzsY\n\twA4tKzQrXWjjP5ZAGXbAGYCFrJMbfVYc0zERgGjRkCVFx4n2ChNDEGu0A4QZFjLgPz\n\tG953q/YFLlsekIhIU31+KkFc0kygIEa/04J/xCZI=","Date":"Tue, 7 Dec 2021 15:29:42 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20211206105032.13876-1-david.plowman@raspberrypi.com>\n\t<20211206105032.13876-7-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211206105032.13876-7-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v9 6/8] libcamera: Support passing\n\tColorSpaces to V4L2 subdevices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"tfiga@google.com, libcamera-devel@lists.libcamera.org,\n\thverkuil-cisco@xs4all.nl","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21631,"web_url":"https://patchwork.libcamera.org/comment/21631/","msgid":"","date":"2021-12-07T13:31:09","subject":"Re: [libcamera-devel] [PATCH v9 6/8] libcamera: Support passing\n\tColorSpaces to V4L2 subdevices","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Dec 07, 2021 at 03:29:44PM +0200, Laurent Pinchart wrote:\n> Hi David,\n> \n> Thank you for the patch.\n\nAlso, the subject line should read\n\nlibcamera: v4l2_subdevice: Support passing ColorSpaces to V4L2 subdevices\n\nor just\n\nlibcamera: v4l2_subdevice: Support passing ColorSpaces\n\n(please update other patches in the series accordingly)\n\n> On Mon, Dec 06, 2021 at 10:50:29AM +0000, David Plowman wrote:\n> > The ColorSpace from the StreamConfiguration is now handled\n> > appropriately in the V4L2Subdevice.\n> > \n> > Signed-off-by: David Plowman \n> > ---\n> > src/libcamera/v4l2_subdevice.cpp | 10 +++++++++-\n> > 1 file changed, 9 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> > index 981645e0..f5ec6901 100644\n> > --- a/src/libcamera/v4l2_subdevice.cpp\n> > +++ b/src/libcamera/v4l2_subdevice.cpp\n> > @@ -411,6 +411,7 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> > \tformat->size.width = subdevFmt.format.width;\n> > \tformat->size.height = subdevFmt.format.height;\n> > \tformat->mbus_code = subdevFmt.format.code;\n> > +\tformat->colorSpace = toColorSpace(subdevFmt.format);\n> > \n> > \treturn 0;\n> > }\n> > @@ -439,7 +440,13 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> > \tsubdevFmt.format.code = format->mbus_code;\n> > \tsubdevFmt.format.field = V4L2_FIELD_NONE;\n> > \n> > -\tint ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n> > +\tint ret = fromColorSpace(format->colorSpace, subdevFmt.format);\n> > +\tif (ret < 0)\n> > +\t\tLOG(V4L2, Warning)\n> > +\t\t\t<< \"Setting color space unrecognised by V4L2: \"\n> > +\t\t\t<< ColorSpace::toString(format->colorSpace);\n> \n> Same comment as in 5/8 regarding the message.\n\nI meant 4/8.\n\n> Reviewed-by: Laurent Pinchart \n> \n> > +\n> > +\tret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt);\n> > \tif (ret) {\n> > \t\tLOG(V4L2, Error)\n> > \t\t\t<< \"Unable to set format on pad \" << pad\n> > @@ -450,6 +457,7 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n> > \tformat->size.width = subdevFmt.format.width;\n> > \tformat->size.height = subdevFmt.format.height;\n> > \tformat->mbus_code = subdevFmt.format.code;\n> > +\tformat->colorSpace = toColorSpace(subdevFmt.format);\n> > \n> > \treturn 0;\n> > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17918BDB13\n\tfor ;\n\tTue, 7 Dec 2021 13:31:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 86C636086A;\n\tTue, 7 Dec 2021 14:31:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4267160592\n\tfor ;\n\tTue, 7 Dec 2021 14:31:38 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CAC83556;\n\tTue, 7 Dec 2021 14:31:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TleT9zX/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638883898;\n\tbh=xRI6s6jWBqulIRdEvjmFJHs3EcB4SbM5SMGYySh8qas=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TleT9zX/61NYUUWC5ACkXS6WwA4gz1MDHLMtMzpG01DAUGmbhDQPNOWb64pkJMycZ\n\tx4drrPlfGDoutQzSKQ2J+wpAyqHCJnXSU/b8la3C89FNhb8Uwaj6YDcwYRtBd4E7nL\n\t2Hsevd8Pjlti2hph8TAJYmFjGLPFCnetxz8C8AMQ=","Date":"Tue, 7 Dec 2021 15:31:09 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20211206105032.13876-1-david.plowman@raspberrypi.com>\n\t<20211206105032.13876-7-david.plowman@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v9 6/8] libcamera: Support passing\n\tColorSpaces to V4L2 subdevices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"tfiga@google.com, libcamera-devel@lists.libcamera.org,\n\thverkuil-cisco@xs4all.nl","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]