[{"id":21591,"web_url":"https://patchwork.libcamera.org/comment/21591/","msgid":"","date":"2021-12-04T00:26:04","subject":"Re: [libcamera-devel] [PATCH v2 6/7] libcamera: ipu3: Pass lens\n\tcontrols to config info","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Daniel,\n\nThank you for the patch.\n\nOn Fri, Dec 03, 2021 at 10:42:29PM +0000, Daniel Scally wrote:\n> When configuring the pipeline we want to share the controls for any\n> VCM device against the sensor too - pass them to the lensControls\n> member of configInfo\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v2:\n> \n> \t- New patch\n> \n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 1215bdb8..4386d3e9 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -656,6 +656,11 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tipa::ipu3::IPAConfigInfo configInfo;\n> \tconfigInfo.sensorControls = data->cio2_.sensor()->controls();\n> +\n> +\tCameraLens *lens = data->cio2_.sensor()->focusLens();\n> +\tif (lens)\n> +\t\tconfigInfo.lensControls = lens->controls();\n> +\n> \tconfigInfo.sensorInfo = sensorInfo;\n> \tconfigInfo.bdsOutputSize = config->imguConfig().bds;\n> \tconfigInfo.iif = config->imguConfig().iif;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0731FBF415\n\tfor ;\n\tSat, 4 Dec 2021 00:26:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E5DB6011A;\n\tSat, 4 Dec 2021 01:26:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A177560117\n\tfor ;\n\tSat, 4 Dec 2021 01:26:31 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F49530C;\n\tSat, 4 Dec 2021 01:26:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SNblryhH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638577591;\n\tbh=pU5eOCXKuOEp1KP6RqfkSYEfMx4TOdS4UR4vejJDsHc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SNblryhH9jmRuXqX+4pkhFSSM+TTLRRrisc/qrocSnwybjXXCD2HmipWZtiINEHQT\n\tecDW2ZGV1m8F+mmw4BOarxN/1Y0fASGd88V5YylDwhHYwz2EztxBC0/vUkXFioPSq8\n\tfzDyy0Nbnbn6XoL0s+PLd7nXyL3pRFQOxhbc+GfE=","Date":"Sat, 4 Dec 2021 02:26:04 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20211203224230.38700-1-djrscally@gmail.com>\n\t<20211203224230.38700-7-djrscally@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211203224230.38700-7-djrscally@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 6/7] libcamera: ipu3: Pass lens\n\tcontrols to config info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]