[{"id":21592,"web_url":"https://patchwork.libcamera.org/comment/21592/","msgid":"","date":"2021-12-04T00:26:47","subject":"Re: [libcamera-devel] [PATCH v2 5/7] libcamera: ipa: Add lens\n\tcontrol member to ipu3 ipa interface","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Daniel,\n\nThank you for the patch.\n\nOn Fri, Dec 03, 2021 at 10:42:28PM +0000, Daniel Scally wrote:\n> Add further members to the ipu3 ipa interface that will hold lens\n> controls passed in by configInfo\n> \n> Signed-off-by: Daniel Scally \n> ---\n> Changes in v2:\n> \n> \t- New patch\n> \n> include/libcamera/ipa/ipu3.mojom | 1 +\n> src/ipa/ipu3/ipu3.cpp | 3 +++\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index cc0d822f..18cdc744 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -37,6 +37,7 @@ struct IPU3Action {\n> struct IPAConfigInfo {\n> \tlibcamera.IPACameraSensorInfo sensorInfo;\n> \tlibcamera.ControlInfoMap sensorControls;\n> +\tlibcamera.ControlInfoMap lensControls;\n> \tlibcamera.Size bdsOutputSize;\n> \tlibcamera.Size iif;\n> };\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b7b48d9a..3828650d 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -162,6 +162,7 @@ private:\n> \tstd::map buffers_;\n> \n> \tControlInfoMap ctrls_;\n\nIt could be useful to rename this to sensorCtrls_ (in a separate patch).\n\nReviewed-by: Laurent Pinchart \n\n> +\tControlInfoMap lensCtrls_;\n> \n> \tIPACameraSensorInfo sensorInfo_;\n> \n> @@ -422,6 +423,8 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n> \n> \tsensorInfo_ = configInfo.sensorInfo;\n> \n> +\tlensCtrls_ = configInfo.lensControls;\n> +\n> \t/*\n> \t * Compute the sensor V4L2 controls to be used by the algorithms and\n> \t * to be set on the sensor.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D338BF415\n\tfor ;\n\tSat, 4 Dec 2021 00:27:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC90E60822;\n\tSat, 4 Dec 2021 01:27:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5E3760117\n\tfor ;\n\tSat, 4 Dec 2021 01:27:14 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EC2130C;\n\tSat, 4 Dec 2021 01:27:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uIBzq07p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638577634;\n\tbh=L1fwTZgPI1epQpdNIZNh5hI+rDYsF6yxQAllV61ZIoY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uIBzq07pSOj21QlI4wiH5Vf0fiKCchzX6FaOqn11lI8vUVtvHLkyENgVZRtjLh6w2\n\tIEgLZcZs2i//esH/5+W2IV+HN15p1ErQyqDVy+jf5pT7pIKUWMdMQeicusQAKD+Lwp\n\ts6jE97rniOsyK2vu+qv0114eKNJBlG5HtlZHjhDU=","Date":"Sat, 4 Dec 2021 02:26:47 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20211203224230.38700-1-djrscally@gmail.com>\n\t<20211203224230.38700-6-djrscally@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211203224230.38700-6-djrscally@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2 5/7] libcamera: ipa: Add lens\n\tcontrol member to ipu3 ipa interface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]