[{"id":21585,"web_url":"https://patchwork.libcamera.org/comment/21585/","msgid":"","date":"2021-12-03T18:56:15","subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] libcamera-helpers:\n\tmapped_framebuffer: Update to new FD API","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Dec 03, 2021 at 05:48:53PM +0000, Kieran Bingham wrote:\n> The plane file descriptors API has been updated in the libcamera\n> base library.\n> \n> Update our mapped_framebuffer class accordingly.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera-helpers/mapped_framebuffer.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera-helpers/mapped_framebuffer.cpp b/src/libcamera-helpers/mapped_framebuffer.cpp\n> index a65740831331..3d231147ed91 100644\n> --- a/src/libcamera-helpers/mapped_framebuffer.cpp\n> +++ b/src/libcamera-helpers/mapped_framebuffer.cpp\n> @@ -198,7 +198,7 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> \tstd::map mappedBuffers;\n> \n> \tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n> -\t\tconst int fd = plane.fd.fd();\n> +\t\tconst int fd = plane.fd.get();\n> \t\tif (mappedBuffers.find(fd) == mappedBuffers.end()) {\n> \t\t\tconst size_t length = lseek(fd, 0, SEEK_END);\n> \t\t\tmappedBuffers[fd] = MappedBufferInfo{ nullptr, 0, length };\n> @@ -220,7 +220,7 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> \t}\n> \n> \tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n> -\t\tconst int fd = plane.fd.fd();\n> +\t\tconst int fd = plane.fd.get();\n> \t\tauto &info = mappedBuffers[fd];\n> \t\tif (!info.address) {\n> \t\t\tvoid *address = mmap(nullptr, info.mapLength, mmapFlags,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77B80BDB13\n\tfor ;\n\tFri, 3 Dec 2021 18:56:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7F1D607DE;\n\tFri, 3 Dec 2021 19:56:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FB8B60725\n\tfor ;\n\tFri, 3 Dec 2021 19:56:43 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3C88A59;\n\tFri, 3 Dec 2021 19:56:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NorYpZnW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638557803;\n\tbh=oaXw0BcgvxrjJpUqLOAdei2+riA0REphYC5weFixH+Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NorYpZnWFceApeo/ek05+5ufmmKuSCGSD48xEYdMorszL8C5fl48HWEbW3gS/7IsW\n\tIlyiw/Pf7phkFI4HbKjCAMXvDX0KdWwqgUq1nFia+lByvPLO89KoAo+Dt7e6GZ5H5h\n\t3R/l384WWZ3XOPtDzAGcp32MAeKKs8KT03XOmA5E=","Date":"Fri, 3 Dec 2021 20:56:15 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211203174853.130537-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211203174853.130537-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] libcamera-helpers:\n\tmapped_framebuffer: Update to new FD API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21600,"web_url":"https://patchwork.libcamera.org/comment/21600/","msgid":"","date":"2021-12-06T05:51:42","subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] libcamera-helpers:\n\tmapped_framebuffer: Update to new FD API","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 12/3/21 11:18 PM, Kieran Bingham wrote:\n> The plane file descriptors API has been updated in the libcamera\n> base library.\n>\n> Update our mapped_framebuffer class accordingly.\n>\n> Signed-off-by: Kieran Bingham \nReviewed-by: Umang Jain \n> ---\n> src/libcamera-helpers/mapped_framebuffer.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera-helpers/mapped_framebuffer.cpp b/src/libcamera-helpers/mapped_framebuffer.cpp\n> index a65740831331..3d231147ed91 100644\n> --- a/src/libcamera-helpers/mapped_framebuffer.cpp\n> +++ b/src/libcamera-helpers/mapped_framebuffer.cpp\n> @@ -198,7 +198,7 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> \tstd::map mappedBuffers;\n> \n> \tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n> -\t\tconst int fd = plane.fd.fd();\n> +\t\tconst int fd = plane.fd.get();\n> \t\tif (mappedBuffers.find(fd) == mappedBuffers.end()) {\n> \t\t\tconst size_t length = lseek(fd, 0, SEEK_END);\n> \t\t\tmappedBuffers[fd] = MappedBufferInfo{ nullptr, 0, length };\n> @@ -220,7 +220,7 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> \t}\n> \n> \tfor (const FrameBuffer::Plane &plane : buffer->planes()) {\n> -\t\tconst int fd = plane.fd.fd();\n> +\t\tconst int fd = plane.fd.get();\n> \t\tauto &info = mappedBuffers[fd];\n> \t\tif (!info.address) {\n> \t\t\tvoid *address = mmap(nullptr, info.mapLength, mmapFlags,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A19A8BDB13\n\tfor ;\n\tMon, 6 Dec 2021 05:51:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC33E60872;\n\tMon, 6 Dec 2021 06:51:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A2DF60224\n\tfor ;\n\tMon, 6 Dec 2021 06:51:47 +0100 (CET)","from [192.168.1.108] (unknown [103.74.73.222])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8023FEE;\n\tMon, 6 Dec 2021 06:51:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UHdboyNh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638769907;\n\tbh=JfTWlwavPt3StXCeAIUQ9ZB7pRdnbsaqeH954sRG1dA=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=UHdboyNhmhRaePoXlEiQlKk/RB6DiVY+Zi0MC88NJbxaSZCYPqdKTed7gT5oRdKVJ\n\tseutxX6Mr6hxMtS4wrLEE/CStlsyZIZEpwjCzfml8DFZH5h5QqlQFg98w46ubRFPXF\n\tUX7V/G/OmZ0bbOrCcRxY2+Jh/NN8dpU/gw+jhh2s=","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20211203174853.130537-1-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Mon, 6 Dec 2021 11:21:42 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211203174853.130537-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [IPU3-IPA PATCH] libcamera-helpers:\n\tmapped_framebuffer: Update to new FD API","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]