{"id":15019,"url":"https://patchwork.libcamera.org/api/patches/15019/?format=json","web_url":"https://patchwork.libcamera.org/patch/15019/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211203164619.1541033-7-hiroh@chromium.org>","date":"2021-12-03T16:46:18","name":"[libcamera-devel,6/7] v4l2: v4l2_camera_proxy: Apply clang thread safety annotation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6c97abbb1e8306c01d1c37b28f2eb73493c1c47b","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15019/mbox/","series":[{"id":2812,"url":"https://patchwork.libcamera.org/api/series/2812/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2812","date":"2021-12-03T16:46:12","name":"Apply clang thread safety annotation libcamera-core and v4l2","version":1,"mbox":"https://patchwork.libcamera.org/series/2812/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15019/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15019/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1550DC3250\n\tfor ;\n\tFri, 3 Dec 2021 16:46:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9B27607DE;\n\tFri, 3 Dec 2021 17:46:38 +0100 (CET)","from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B887360832\n\tfor ;\n\tFri, 3 Dec 2021 17:46:36 +0100 (CET)","by mail-pj1-x1029.google.com with SMTP id\n\tn15-20020a17090a160f00b001a75089daa3so5631321pja.1\n\tfor ;\n\tFri, 03 Dec 2021 08:46:36 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:cd78:3a5f:d792:6177])\n\tby smtp.gmail.com with ESMTPSA id\n\th18sm4123149pfh.172.2021.12.03.08.46.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 03 Dec 2021 08:46:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ke8+NzHz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=JaMrsxLXuEEZtzL4x5CBJKy9cwdODa5T8VqnK8aUtUU=;\n\tb=ke8+NzHzsoGLQwq91uklPiglqgf32s2wqbJF8hlJwmQDEWU8lKdhn/5fxacdrOcWnt\n\tTTdcfwe1gBso8XFT9RHc7xFTkI9dlLztkHw8AghMmfATvPzW+eUQ93wyhG6vL3MsTf+p\n\tSAZ7EP3BVzSEYhBQAOIRTMYt/SSwUatV34jFY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=JaMrsxLXuEEZtzL4x5CBJKy9cwdODa5T8VqnK8aUtUU=;\n\tb=6Ubq4WbTZcws3jRWAa5oVwORGAfu2rQI+pWn9Gbeb0UnCVaojFbzvRJl4HVd2c4iiE\n\ta1CdGE41Qh/TAj2XmfbRrJLWykL0YJHLCJZqCLdqCop9Aw+iJPhKghsY9ISwSXHJlkCt\n\tiZML4Eaarudt4rXhUs7E51QWMuqa+hq7CKz1xiCE+0LFyPwEjNKJSyhpCsy0lPUxDROF\n\teN4lfZG/EGjQ5QXZSvVPXMHZHtqp/4P0WeXWCSG9PH+A0XXh2WeSBHDffYhX12TqwO/g\n\ti2LQy2jcrdY7bGjGaPwqmMrWKZL62ZeVXe3tvc8ZNCtnKJuP9WWXcLI7eM+bjugeBp3u\n\tg4Gg==","X-Gm-Message-State":"AOAM532M5LWLtrvpMeOD65p1ZuFogtzsgnsZqNwg2MEXWMFMOMoEclql\n\tI+B0ionpRMJ50NHXVFDxHsMMJ7Ks2k/QJQ==","X-Google-Smtp-Source":"ABdhPJwQBM2YApX62D2fA7o/YXEf9HVKGINIA8KQFEUwkw46Q0pd7bGbzGtB/JgwfDo5xLFA7SA6/w==","X-Received":"by 2002:a17:90b:fd5:: with SMTP id\n\tgd21mr15848909pjb.37.1638549995041; \n\tFri, 03 Dec 2021 08:46:35 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 4 Dec 2021 01:46:18 +0900","Message-Id":"<20211203164619.1541033-7-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.0.384.gca35af8252-goog","In-Reply-To":"<20211203164619.1541033-1-hiroh@chromium.org>","References":"<20211203164619.1541033-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 6/7] v4l2: v4l2_camera_proxy: Apply clang\n\tthread safety annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This annotates member functions of V4L2CameraProxy by clang\nthread safety annotations.\n\nSigned-off-by: Hirokazu Honda \n---\n src/v4l2/v4l2_camera_proxy.h | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\nindex fa0a49e0..993562ef 100644\n--- a/src/v4l2/v4l2_camera_proxy.h\n+++ b/src/v4l2/v4l2_camera_proxy.h\n@@ -27,12 +27,14 @@ class V4L2CameraProxy\n public:\n \tV4L2CameraProxy(unsigned int index, std::shared_ptr camera);\n \n-\tint open(V4L2CameraFile *file);\n-\tvoid close(V4L2CameraFile *file);\n-\tvoid *mmap(void *addr, size_t length, int prot, int flags, off64_t offset);\n-\tint munmap(void *addr, size_t length);\n-\n-\tint ioctl(V4L2CameraFile *file, unsigned long request, void *arg);\n+\tint open(V4L2CameraFile *file) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n+\tvoid close(V4L2CameraFile *file) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n+\tvoid *mmap(void *addr, size_t length, int prot, int flags, off64_t offset)\n+\t\tLIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n+\tint munmap(void *addr, size_t length) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n+\n+\tint ioctl(V4L2CameraFile *file, unsigned long request, void *arg)\n+\t\tLIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n \n private:\n \tbool validateBufferType(uint32_t type);\n","prefixes":["libcamera-devel","6/7"]}