[{"id":21577,"web_url":"https://patchwork.libcamera.org/comment/21577/","msgid":"","date":"2021-12-03T14:17:35","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Only process focus\n\tif we have a lens","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Dec 03, 2021 at 12:53:59PM +0000, Kieran Bingham wrote:\n> If there is no lens detected by the system, then we will not be able to\n> set the control, so we can skip processing of the list.\n> \n> Furthermore, if the IPA has not set a V4L2_CID_FOCUS_ABSOLUTE control,\n> then a warning will be printed as the lensControls.get() will not\n> succeed.\n> \n> Break out of the control parsing when there is no CameraLens\n> device, or if there is no absolute focus control set by the IPA.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +++++++++---\n> 1 file changed, 9 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 1215bdb84224..16380d2091b2 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1242,13 +1242,19 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> \t\tconst ControlList &sensorControls = action.sensorControls;\n> \t\tdelayedCtrls_->push(sensorControls);\n> \n> +\t\tCameraLens *focusLens = cio2_.sensor()->focusLens();\n> +\t\tif (!focusLens)\n> +\t\t\tbreak;\n> +\n> \t\tconst ControlList lensControls = action.lensControls;\n> +\t\tif (!lensControls.contains(V4L2_CID_FOCUS_ABSOLUTE))\n> +\t\t\tbreak;\n> +\n> \t\tconst ControlValue &focusValue =\n> \t\t\tlensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n> \n\nI'd drop this blank line.\n\nReviewed-by: Laurent Pinchart \n\n> -\t\tCameraLens *focusLens = cio2_.sensor()->focusLens();\n> -\t\tif (focusLens && !focusValue.isNone())\n> -\t\t\tfocusLens->setFocusPostion(focusValue.get());\n> +\t\tfocusLens->setFocusPostion(focusValue.get());\n> +\n> \t\tbreak;\n> \t}\n> \tcase ipa::ipu3::ActionParamFilled: {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55BECBF415\n\tfor ;\n\tFri, 3 Dec 2021 14:18:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2A4F607DE;\n\tFri, 3 Dec 2021 15:18:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D41E160725\n\tfor ;\n\tFri, 3 Dec 2021 15:18:02 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DE23EE;\n\tFri, 3 Dec 2021 15:18:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H94xMHC9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638541082;\n\tbh=hrJm5QIbUDp+FRizU9g6prWvHuRZoielIIUbHY2vSN0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H94xMHC9qbuI3ZAG6gEirmSD1wT4TgGJeiOWDjBUulNrBUYGO/5DcnZr+AlcEnS+z\n\take2zk5sADw4652a4MRgwZlMHefbdqYEWYFXUtdI4e39kj8QoC5nmU0vpgPjgHpjnB\n\tD3y8pETwpjdMfCdkODuTPgiDtiky7328lhUIXk1I=","Date":"Fri, 3 Dec 2021 16:17:35 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211203125359.25191-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211203125359.25191-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Only process focus\n\tif we have a lens","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21578,"web_url":"https://patchwork.libcamera.org/comment/21578/","msgid":"<163854190470.3059017.15524278316114357920@Monstersaurus>","date":"2021-12-03T14:31:44","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Only process focus\n\tif we have a lens","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-12-03 14:17:35)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Dec 03, 2021 at 12:53:59PM +0000, Kieran Bingham wrote:\n> > If there is no lens detected by the system, then we will not be able to\n> > set the control, so we can skip processing of the list.\n> > \n> > Furthermore, if the IPA has not set a V4L2_CID_FOCUS_ABSOLUTE control,\n> > then a warning will be printed as the lensControls.get() will not\n> > succeed.\n> > \n> > Break out of the control parsing when there is no CameraLens\n> > device, or if there is no absolute focus control set by the IPA.\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +++++++++---\n> > 1 file changed, 9 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 1215bdb84224..16380d2091b2 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -1242,13 +1242,19 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> > const ControlList &sensorControls = action.sensorControls;\n> > delayedCtrls_->push(sensorControls);\n> > \n> > + CameraLens *focusLens = cio2_.sensor()->focusLens();\n> > + if (!focusLens)\n> > + break;\n> > +\n> > const ControlList lensControls = action.lensControls;\n> > + if (!lensControls.contains(V4L2_CID_FOCUS_ABSOLUTE))\n> > + break;\n> > +\n> > const ControlValue &focusValue =\n> > lensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n> > \n> \n> I'd drop this blank line.\n\nI can, I kind of prefer it when the line above is broken over two lines\nthough:\n\n\t\tconst ControlValue &focusValue =\n\t\t\tlensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n\n\t\tfocusLens->setFocusPostion(focusValue.get());\n\nvs\n\n\t\tconst ControlValue &focusValue = lensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n\t\tfocusLens->setFocusPostion(focusValue.get());\n\nThat takes us to 92 chars on the FOCUS_ABSOLUTE,\nso if you prefer without the blank line, I'll move that up. It's still\nwithin our hard-line-lenght-limit.\n\n> Reviewed-by: Laurent Pinchart \n\nThanks\n--\nKieran\n\n\n> \n> > - CameraLens *focusLens = cio2_.sensor()->focusLens();\n> > - if (focusLens && !focusValue.isNone())\n> > - focusLens->setFocusPostion(focusValue.get());\n> > + focusLens->setFocusPostion(focusValue.get());\n> > +\n> > break;\n> > }\n> > case ipa::ipu3::ActionParamFilled: {\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF278BDB13\n\tfor ;\n\tFri, 3 Dec 2021 14:31:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1906B60839;\n\tFri, 3 Dec 2021 15:31:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D2CF60725\n\tfor ;\n\tFri, 3 Dec 2021 15:31:47 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0DEAD2A5;\n\tFri, 3 Dec 2021 15:31:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sDrJxNN+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638541907;\n\tbh=Zv4hxi//WpzZrMLTxp9BfI3mV6A6ESVoTtdMQPCEnR4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sDrJxNN+osYUkTB2jSGO2Yuz4Uwf/mnbkFJTFNymHRe0RfdDlO4iZV50VWv5QhR1p\n\t7bsIWd2xdy1gAfQe8iECt3zJ8FKcqOqxoAu6Q9TqsBv2gpPI54FCrbz+mIOeRZj71I\n\t1NDttK/pciS/IQwM5whH8y03Xk0JNU85mNxjBP8s=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211203125359.25191-1-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","To":"Laurent Pinchart ","Date":"Fri, 03 Dec 2021 14:31:44 +0000","Message-ID":"<163854190470.3059017.15524278316114357920@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Only process focus\n\tif we have a lens","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21579,"web_url":"https://patchwork.libcamera.org/comment/21579/","msgid":"<20211203143301.zhd6nlhainira6fb@uno.localdomain>","date":"2021-12-03T14:33:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Only process focus\n\tif we have a lens","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Fri, Dec 03, 2021 at 04:17:35PM +0200, Laurent Pinchart wrote:\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Fri, Dec 03, 2021 at 12:53:59PM +0000, Kieran Bingham wrote:\n> > If there is no lens detected by the system, then we will not be able to\n> > set the control, so we can skip processing of the list.\n> >\n> > Furthermore, if the IPA has not set a V4L2_CID_FOCUS_ABSOLUTE control,\n> > then a warning will be printed as the lensControls.get() will not\n> > succeed.\n> >\n> > Break out of the control parsing when there is no CameraLens\n> > device, or if there is no absolute focus control set by the IPA.\n> >\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +++++++++---\n> > 1 file changed, 9 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 1215bdb84224..16380d2091b2 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -1242,13 +1242,19 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> > \t\tconst ControlList &sensorControls = action.sensorControls;\n> > \t\tdelayedCtrls_->push(sensorControls);\n> >\n> > +\t\tCameraLens *focusLens = cio2_.sensor()->focusLens();\n> > +\t\tif (!focusLens)\n> > +\t\t\tbreak;\n> > +\n> > \t\tconst ControlList lensControls = action.lensControls;\n> > +\t\tif (!lensControls.contains(V4L2_CID_FOCUS_ABSOLUTE))\n> > +\t\t\tbreak;\n> > +\n> > \t\tconst ControlValue &focusValue =\n> > \t\t\tlensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n> >\n>\n> I'd drop this blank line.\n\nWas about to suggest the same!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > -\t\tCameraLens *focusLens = cio2_.sensor()->focusLens();\n> > -\t\tif (focusLens && !focusValue.isNone())\n> > -\t\t\tfocusLens->setFocusPostion(focusValue.get());\n> > +\t\tfocusLens->setFocusPostion(focusValue.get());\n> > +\n> > \t\tbreak;\n> > \t}\n> > \tcase ipa::ipu3::ActionParamFilled: {\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 308C3BDB13\n\tfor ;\n\tFri, 3 Dec 2021 14:32:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E465A60832;\n\tFri, 3 Dec 2021 15:32:10 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23A6D60725\n\tfor ;\n\tFri, 3 Dec 2021 15:32:10 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 73527C000D;\n\tFri, 3 Dec 2021 14:32:09 +0000 (UTC)"],"Date":"Fri, 3 Dec 2021 15:33:01 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20211203143301.zhd6nlhainira6fb@uno.localdomain>","References":"<20211203125359.25191-1-kieran.bingham@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Only process focus\n\tif we have a lens","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]