[{"id":21570,"web_url":"https://patchwork.libcamera.org/comment/21570/","msgid":"","date":"2021-12-03T11:07:39","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Fix doxygen\n\twarning","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch\n\nOn 12/3/21 4:35 PM, Laurent Pinchart wrote:\n> Commit ad2bcbe5b55c (\"libcamera: camera_lens: add CameraLens as a member\n> of CameraSensor\") incorrectly named the focusLens() function\n> \"focusLens_\" in the documentation, causing a doxygen warning. Fix it.\n>\n> Fixes: ad2bcbe5b55c (\"libcamera: camera_lens: add CameraLens as a member of CameraSensor\")\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> Han-lin, could you please make sure to have a look for doxygen warnings\n> in future patches ? We'll also update our integration scripts to detect\n> them.\n> ---\n> src/libcamera/camera_sensor.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index c89d39e1488c..4c142a5825f7 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -789,7 +789,7 @@ void CameraSensor::updateControlInfo()\n> }\n> \n> /**\n> - * \\fn CameraSensor::focusLens_()\n> + * \\fn CameraSensor::focusLens()\n> * \\brief Retrieve the focus lens controller\n> *\n> * \\return The focus lens controller. nullptr if no focus lens controller is\n>\n> base-commit: 3f881dbc338e8f24f478567ee890c1f36ccb8996","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6CE4BF415\n\tfor ;\n\tFri, 3 Dec 2021 11:07:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5097A607DE;\n\tFri, 3 Dec 2021 12:07:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFE2460725\n\tfor ;\n\tFri, 3 Dec 2021 12:07:44 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E689DA59;\n\tFri, 3 Dec 2021 12:07:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nqNxLgC7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638529664;\n\tbh=B8FJmr/01hy29qv5pEBWWS+awbu/CKovWdNP4Y6AnOQ=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=nqNxLgC7XoWvZPWo7D1QRKF7Z0pQDBWc+N2SwaOtWBWV8JhWVJoUlfyjO9vrf6Qkn\n\tD/PVQP0aodNu61OhhRedyPWIYbJhQoDr42ngx7zEPaaZrjwN+YNyvK/BfC7FHK1ckH\n\tjEpM/vEeRT7n5KSnjMs269zXE9ymiGCd2e8bRCpQ=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211203110527.19559-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Fri, 3 Dec 2021 16:37:39 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211203110527.19559-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Fix doxygen\n\twarning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21571,"web_url":"https://patchwork.libcamera.org/comment/21571/","msgid":"<78499ef8-0f40-1dac-4d84-2d0a2e3847cc@ideasonboard.com>","date":"2021-12-03T11:11:44","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Fix doxygen\n\twarning","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 03/12/2021 12:07, Umang Jain wrote:\n> Hi Laurent,\n> \n> Thanks for the patch\n> \n> On 12/3/21 4:35 PM, Laurent Pinchart wrote:\n>> Commit ad2bcbe5b55c (\"libcamera: camera_lens: add CameraLens as a member\n>> of CameraSensor\") incorrectly named the focusLens() function\n>> \"focusLens_\" in the documentation, causing a doxygen warning. Fix it.\n>>\n>> Fixes: ad2bcbe5b55c (\"libcamera: camera_lens: add CameraLens as a \n>> member of CameraSensor\")\n>> Signed-off-by: Laurent Pinchart \n> \n> \n> Reviewed-by: Umang Jain \n\nReviewed-by: Jean-Michel Hautbois \n> \n>> ---\n>> Han-lin, could you please make sure to have a look for doxygen warnings\n>> in future patches ? We'll also update our integration scripts to detect\n>> them.\n>> ---\n>>   src/libcamera/camera_sensor.cpp | 2 +-\n>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/camera_sensor.cpp \n>> b/src/libcamera/camera_sensor.cpp\n>> index c89d39e1488c..4c142a5825f7 100644\n>> --- a/src/libcamera/camera_sensor.cpp\n>> +++ b/src/libcamera/camera_sensor.cpp\n>> @@ -789,7 +789,7 @@ void CameraSensor::updateControlInfo()\n>>   }\n>>   /**\n>> - * \\fn CameraSensor::focusLens_()\n>> + * \\fn CameraSensor::focusLens()\n>>    * \\brief Retrieve the focus lens controller\n>>    *\n>>    * \\return The focus lens controller. nullptr if no focus lens \n>> controller is\n>>\n>> base-commit: 3f881dbc338e8f24f478567ee890c1f36ccb8996","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97B0BBDB13\n\tfor ;\n\tFri, 3 Dec 2021 11:11:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 059E5607DE;\n\tFri, 3 Dec 2021 12:11:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45DB660725\n\tfor ;\n\tFri, 3 Dec 2021 12:11:47 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:458d:6388:c3ac:74bf] (unknown\n\t[IPv6:2a01:e0a:169:7140:458d:6388:c3ac:74bf])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C85F8A59;\n\tFri, 3 Dec 2021 12:11:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pcRCl8t2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638529906;\n\tbh=cczPHIM+GxaKMpoei96EHKxTFseSHOeNCpUPrwDE0tU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=pcRCl8t2EHj/PvzJppmzhTtrslMxpRdaFBzcEtSABg36LAnTJAPYnaeskDPbIGTzn\n\tckH/1H2IJ60cq96K2/QibQ3fK8EynF7OMIKzOPo4oNTQ0HEqGdGH+w3b7qSLU5Eoql\n\tnfGbi3kVeolNO2vejHrN0hS7thX3MZcR4a1DE1Bk=","Message-ID":"<78499ef8-0f40-1dac-4d84-2d0a2e3847cc@ideasonboard.com>","Date":"Fri, 3 Dec 2021 12:11:44 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.3.1","Content-Language":"en-US","To":"Umang Jain ,\n\tLaurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211203110527.19559-1-laurent.pinchart@ideasonboard.com>\n\t","From":"Jean-Michel Hautbois ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Fix doxygen\n\twarning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21572,"web_url":"https://patchwork.libcamera.org/comment/21572/","msgid":"<163853006475.3059017.5999335258436337094@Monstersaurus>","date":"2021-12-03T11:14:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Fix doxygen\n\twarning","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-12-03 11:05:27)\n> Commit ad2bcbe5b55c (\"libcamera: camera_lens: add CameraLens as a member\n> of CameraSensor\") incorrectly named the focusLens() function\n> \"focusLens_\" in the documentation, causing a doxygen warning. Fix it.\n> \n> Fixes: ad2bcbe5b55c (\"libcamera: camera_lens: add CameraLens as a member of CameraSensor\")\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> Han-lin, could you please make sure to have a look for doxygen warnings\n> in future patches ? We'll also update our integration scripts to detect\n> them.\n\nYes, sorry - looking at the logs it got flagged up - but doesn't cause\na fatal stop, so it didn't trap, and I missed it.\n\nI'll have to figure out how to make doxygen -Werror ... ?\n\n--\nKieran\n\n\n> ---\n> src/libcamera/camera_sensor.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index c89d39e1488c..4c142a5825f7 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -789,7 +789,7 @@ void CameraSensor::updateControlInfo()\n> }\n> \n> /**\n> - * \\fn CameraSensor::focusLens_()\n> + * \\fn CameraSensor::focusLens()\n> * \\brief Retrieve the focus lens controller\n> *\n> * \\return The focus lens controller. nullptr if no focus lens controller is\n> \n> base-commit: 3f881dbc338e8f24f478567ee890c1f36ccb8996\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47888BF415\n\tfor ;\n\tFri, 3 Dec 2021 11:14:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92F5F60832;\n\tFri, 3 Dec 2021 12:14:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 182A760725\n\tfor ;\n\tFri, 3 Dec 2021 12:14:28 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AEAC3A59;\n\tFri, 3 Dec 2021 12:14:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JKxQHWqp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638530067;\n\tbh=POAEQTjMJ1qn9T0IsT4sHv+ubaAnVvQeM6PDREnp7PY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=JKxQHWqpfdBGr6AgtmgyJlnGs4VnaWuFVQ7lSfeCmKB3nkXwS8HmyMNE2siXQmy3K\n\tMlrdJU8X8SmvH/8MVnIWqpvvJ6Vc2QCtMGb7Xw18KN5zw5SPV0B2bvphoIHao8a4NZ\n\tYfheWJBgV/1yoKX+5XDe4TEPdqVEmy4ResSuoAmw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211203110527.19559-1-laurent.pinchart@ideasonboard.com>","References":"<20211203110527.19559-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 03 Dec 2021 11:14:24 +0000","Message-ID":"<163853006475.3059017.5999335258436337094@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Fix doxygen\n\twarning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21573,"web_url":"https://patchwork.libcamera.org/comment/21573/","msgid":"","date":"2021-12-03T11:23:42","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Fix doxygen\n\twarning","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Dec 03, 2021 at 11:14:24AM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2021-12-03 11:05:27)\n> > Commit ad2bcbe5b55c (\"libcamera: camera_lens: add CameraLens as a member\n> > of CameraSensor\") incorrectly named the focusLens() function\n> > \"focusLens_\" in the documentation, causing a doxygen warning. Fix it.\n> > \n> > Fixes: ad2bcbe5b55c (\"libcamera: camera_lens: add CameraLens as a member of CameraSensor\")\n> > Signed-off-by: Laurent Pinchart \n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > Han-lin, could you please make sure to have a look for doxygen warnings\n> > in future patches ? We'll also update our integration scripts to detect\n> > them.\n> \n> Yes, sorry - looking at the logs it got flagged up - but doesn't cause\n> a fatal stop, so it didn't trap, and I missed it.\n> \n> I'll have to figure out how to make doxygen -Werror ... ?\n\ndiff --git a/Documentation/Doxyfile.in b/Documentation/Doxyfile.in\nindex 3d20e3ca460f..0fbf00acf439 100644\n--- a/Documentation/Doxyfile.in\n+++ b/Documentation/Doxyfile.in\n@@ -760,7 +760,7 @@ WARN_NO_PARAMDOC = NO\n # a warning is encountered.\n # The default value is: NO.\n\n-WARN_AS_ERROR = NO\n+WARN_AS_ERROR = YES\n\n # The WARN_FORMAT tag determines the format of the warning messages that doxygen\n # can produce. The string should contain the $file, $line, and $text tags, which\n\nIt may be a bit harsh to enable that unconditionally though, as we\ncurrently require a very recent doxygen version to build without\nwarning. This is something that could be set conditionally based on the\ndoxygen version possibly. We already generate Doxyfile from Doxyfile.in,\nso it shouldn't be too hard.\n\n> > ---\n> > src/libcamera/camera_sensor.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > index c89d39e1488c..4c142a5825f7 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -789,7 +789,7 @@ void CameraSensor::updateControlInfo()\n> > }\n> > \n> > /**\n> > - * \\fn CameraSensor::focusLens_()\n> > + * \\fn CameraSensor::focusLens()\n> > * \\brief Retrieve the focus lens controller\n> > *\n> > * \\return The focus lens controller. nullptr if no focus lens controller is\n> > \n> > base-commit: 3f881dbc338e8f24f478567ee890c1f36ccb8996","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAA8FBDB13\n\tfor ;\n\tFri, 3 Dec 2021 11:24:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28687607DE;\n\tFri, 3 Dec 2021 12:24:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C57E60725\n\tfor ;\n\tFri, 3 Dec 2021 12:24:09 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0704A59;\n\tFri, 3 Dec 2021 12:24:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ym/SwOXc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638530649;\n\tbh=P+X9kh8vKUl3dMsVnfwpRvIy3ks07hGO7JhKWbFYPTQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ym/SwOXcVdl3zmydmts3M4cvp15GlOWAsbZIhL2CH/56d1ovqgfsP7f/16SKdAYfR\n\tGbSjgZIlEXcgXfSKXQ6LeZC9p+OP0uSknQ/2pxizGXjPVRvHiHGnSBwkhFYng+0xRQ\n\tYiCm5RULFOYm4tZcpJ+L8pa2Ad3VysKoan0wa8b0=","Date":"Fri, 3 Dec 2021 13:23:42 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211203110527.19559-1-laurent.pinchart@ideasonboard.com>\n\t<163853006475.3059017.5999335258436337094@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<163853006475.3059017.5999335258436337094@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Fix doxygen\n\twarning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]