{"id":15004,"url":"https://patchwork.libcamera.org/api/patches/15004/?format=json","web_url":"https://patchwork.libcamera.org/patch/15004/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211203094426.101454-3-hanlinchen@chromium.org>","date":"2021-12-03T09:44:23","name":"[libcamera-devel,v8,2/5] libcamera: add model() for retrieving model name in V4L2Subdevice","commit_ref":"5d2aad02e86d456f77ca2bab5025ff7044f10125","pull_url":null,"state":"accepted","archived":false,"hash":"a2cbd2e40a8d332695986dac4d556df9064d81fe","submitter":{"id":98,"url":"https://patchwork.libcamera.org/api/people/98/?format=json","name":"Hanlin Chen","email":"hanlinchen@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15004/mbox/","series":[{"id":2807,"url":"https://patchwork.libcamera.org/api/series/2807/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2807","date":"2021-12-03T09:44:21","name":"Introduce Lens class and apply auto focus on ipu3","version":8,"mbox":"https://patchwork.libcamera.org/series/2807/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15004/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15004/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E474BDB13\n\tfor ;\n\tFri, 3 Dec 2021 09:44:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5FCB607DE;\n\tFri, 3 Dec 2021 10:44:38 +0100 (CET)","from mail-pl1-x634.google.com (mail-pl1-x634.google.com\n\t[IPv6:2607:f8b0:4864:20::634])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C69D560710\n\tfor ;\n\tFri, 3 Dec 2021 10:44:36 +0100 (CET)","by mail-pl1-x634.google.com with SMTP id k4so1710060plx.8\n\tfor ;\n\tFri, 03 Dec 2021 01:44:36 -0800 (PST)","from localhost ([2401:fa00:1:10:110e:45d1:2f92:6647])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\ty6sm2817203pfi.154.2021.12.03.01.44.33\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 03 Dec 2021 01:44:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mf1RH6W5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Z4QqmdJUB/xMXj6lpUpiLyim0Gmrw/FIaSyOxP2tj9A=;\n\tb=mf1RH6W5fIYIwtmVmNp82txbSVDqJJpA5JioVjt75EHMsTKEqSHu9D9cI5E+dhfMl/\n\tLJW9yn/rV8z/OuARNzZTFJcMziU5qwn+Cu+UiSAmsQV73+XBQBRUkS12cdV2x8z8RHGa\n\t+TGzxXAeZtKgHY764eZCrKTrTP0un1aX+8tPc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Z4QqmdJUB/xMXj6lpUpiLyim0Gmrw/FIaSyOxP2tj9A=;\n\tb=y6UhhCN8WWQ2gfq6AHjuq++7IGKshw8wXZQmn7JGYPXL0dTPRYzhtSOx2THL1n8Kna\n\tnNoDYvReJ6H5Qob/puMTxFnLIReSm0q0XrKG3gFoVHtg/ZKXFjek43EguvXs5DpH6qEb\n\tCDQbm7JK6JL47hentJW78oU33yTAWb2+KCTh+FUTSYeoB46EWP5IHaAhCJYe1mWFj1Np\n\tbRdBlRYd/8zXAa1nUAUJeTMk9G2syH5sJU0Mk2olZiRylzWCSeWMzHNUpaNrbOnLW3sc\n\tVQSF3yaZvfGzn+viWWSBDjW7IlnhmrQVr51S1AHSEUi0vxb8Bs97cLTsORMjscKx/2wr\n\tSFgg==","X-Gm-Message-State":"AOAM5303kRiqHAVIgTtrcdtqfmpqHSmaemWXwAaiPiTXwfDNLE3+YPFe\n\tgX+97VHL4tpQapW01nUotP40QLRVSNKVow==","X-Google-Smtp-Source":"ABdhPJw1eXKrFHaDYGsgWR4mnCHTjY6MKhZueE/OhziRm2+SnwF70SSs/xYGwb5UP0opAJM2aDLL8Q==","X-Received":"by 2002:a17:90a:c286:: with SMTP id\n\tf6mr12913665pjt.45.1638524674770; \n\tFri, 03 Dec 2021 01:44:34 -0800 (PST)","From":"Han-Lin Chen ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 3 Dec 2021 17:44:23 +0800","Message-Id":"<20211203094426.101454-3-hanlinchen@chromium.org>","X-Mailer":"git-send-email 2.34.0.384.gca35af8252-goog","In-Reply-To":"<20211203094426.101454-1-hanlinchen@chromium.org>","References":"<20211203094426.101454-1-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 2/5] libcamera: add model() for\n\tretrieving model name in V4L2Subdevice","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"CameraSensor retrieves model name from media entity. Move the heuristics\nmethod into V4L2Subdevice, so CameraLens can reuse the function.\n\nSigned-off-by: Han-Lin Chen \nReviewed-by: Kieran Bingham \nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \n---\n include/libcamera/internal/v4l2_subdevice.h | 4 ++\n src/libcamera/camera_sensor.cpp | 32 +------------\n src/libcamera/v4l2_subdevice.cpp | 53 +++++++++++++++++++++\n 3 files changed, 59 insertions(+), 30 deletions(-)","diff":"diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\nindex 484fcfdd..a6873b67 100644\n--- a/include/libcamera/internal/v4l2_subdevice.h\n+++ b/include/libcamera/internal/v4l2_subdevice.h\n@@ -61,6 +61,8 @@ public:\n \tint setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \t\t Whence whence = ActiveFormat);\n \n+\tconst std::string &model();\n+\n \tstatic std::unique_ptr\n \tfromEntityName(const MediaDevice *media, const std::string &entity);\n \n@@ -75,6 +77,8 @@ private:\n \t\t\t\t\t unsigned int code);\n \n \tconst MediaEntity *entity_;\n+\n+\tstd::string model_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 9fdb8c09..6151b32e 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -13,7 +13,6 @@\n #include \n #include \n #include \n-#include \n #include \n \n #include \n@@ -347,34 +346,7 @@ void CameraSensor::initTestPatternModes(\n \n int CameraSensor::initProperties()\n {\n-\t/*\n-\t * Extract the camera sensor model name from the media entity name.\n-\t *\n-\t * There is no standardized naming scheme for sensor entities in the\n-\t * Linux kernel at the moment.\n-\t *\n-\t * - The most common rule, used by I2C sensors, associates the model\n-\t * name with the I2C bus number and address (e.g. 'imx219 0-0010').\n-\t *\n-\t * - When the sensor exposes multiple subdevs, the model name is\n-\t * usually followed by a function name, as in the smiapp driver (e.g.\n-\t * 'jt8ew9 pixel_array 0-0010').\n-\t *\n-\t * - The vimc driver names its sensors 'Sensor A' and 'Sensor B'.\n-\t *\n-\t * Other schemes probably exist. As a best effort heuristic, use the\n-\t * part of the entity name before the first space if the name contains\n-\t * an I2C address, and use the full entity name otherwise.\n-\t */\n-\tstd::string entityName = entity_->name();\n-\tstd::regex i2cRegex{ \" [0-9]+-[0-9a-f]{4}\" };\n-\tstd::smatch match;\n-\n-\tif (std::regex_search(entityName, match, i2cRegex))\n-\t\tmodel_ = entityName.substr(0, entityName.find(' '));\n-\telse\n-\t\tmodel_ = entityName;\n-\n+\tmodel_ = subdev_->model();\n \tproperties_.set(properties::Model, utils::toAscii(model_));\n \n \t/* Generate a unique ID for the sensor. */\n@@ -832,7 +804,7 @@ int CameraSensor::generateId()\n \t/*\n \t * Virtual sensors not described in firmware\n \t *\n-\t * Verify it's a platform device and construct ID from the deive path\n+\t * Verify it's a platform device and construct ID from the device path\n \t * and model of sensor.\n \t */\n \tif (devPath.find(\"/sys/devices/platform/\", 0) == 0) {\ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 023e2328..61e15b69 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -9,6 +9,7 @@\n \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -442,6 +443,58 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format,\n \treturn 0;\n }\n \n+/**\n+ * \\brief Retrieve the model name of the device\n+ *\n+ * The model name allows identification of the specific device model. This can\n+ * be used to infer device characteristics, for instance to determine the\n+ * analogue gain model of a camera sensor based on the sensor model name.\n+ *\n+ * Neither the V4L2 API nor the Media Controller API expose an explicit model\n+ * name. This function implements a heuristics to extract the model name from\n+ * the subdevice's entity name. This should produce accurate results for\n+ * I2C-based devices. If the heuristics can't match a known naming pattern,\n+ * the function returns the full entity name.\n+ *\n+ * \\return The model name of the device\n+ */\n+const std::string &V4L2Subdevice::model()\n+{\n+\tif (!model_.empty())\n+\t\treturn model_;\n+\n+\t/*\n+\t * Extract model name from the media entity name.\n+\t *\n+\t * There is no standardized naming scheme for sensor or other entities\n+\t * in the Linux kernel at the moment.\n+\t *\n+\t * - The most common rule, used by I2C sensors, associates the model\n+\t * name with the I2C bus number and address (e.g. 'imx219 0-0010').\n+\t *\n+\t * - When the sensor exposes multiple subdevs, the model name is\n+\t * usually followed by a function name, as in the smiapp driver (e.g.\n+\t * 'jt8ew9 pixel_array 0-0010').\n+\t *\n+\t * - The vimc driver names its sensors 'Sensor A' and 'Sensor B'.\n+\t *\n+\t * Other schemes probably exist. As a best effort heuristic, use the\n+\t * part of the entity name before the first space if the name contains\n+\t * an I2C address, and use the full entity name otherwise.\n+\t */\n+\tstd::string entityName = entity_->name();\n+\tstd::regex i2cRegex{ \" [0-9]+-[0-9a-f]{4}\" };\n+\tstd::smatch match;\n+\n+\tstd::string model;\n+\tif (std::regex_search(entityName, match, i2cRegex))\n+\t\tmodel_ = entityName.substr(0, entityName.find(' '));\n+\telse\n+\t\tmodel_ = entityName;\n+\n+\treturn model_;\n+}\n+\n /**\n * \\brief Create a new video subdevice instance from \\a entity in media device\n * \\a media\n","prefixes":["libcamera-devel","v8","2/5"]}