[{"id":17,"web_url":"https://patchwork.libcamera.org/comment/17/","msgid":"<6363238.9eg0yNof58@avalon>","date":"2018-11-27T01:24:16","subject":"Re: [libcamera-devel] [PATCH 1/2] lib: Include library in the\n\tinstall target","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Monday, 26 November 2018 16:01:10 EET Kieran Bingham wrote:\n> The shared library build target does not install the library when 'ninja\n> install' is executed.\n> \n> Flag it as an installable item.\n> \n> Signed-off-by: Kieran Bingham \n\nI think this improves the usability of the installed library a lot, even if \nit's still not very useful yet :-)\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> lib/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/lib/meson.build b/lib/meson.build\n> index 37876cee48ff..eee99b7525ce 100644\n> --- a/lib/meson.build\n> +++ b/lib/meson.build\n> @@ -2,4 +2,5 @@ sources = ['main.cpp']\n> \n> libcamera = shared_library('camera',\n> \t\t\t sources,\n> +\t\t\t install : true,\n> \t\t\t include_directories : inc)","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0179A60B0C\n\tfor ;\n\tTue, 27 Nov 2018 02:23:53 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CB6759;\n\tTue, 27 Nov 2018 02:23:52 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1543281832;\n\tbh=R68Jw9M9UlXl94TbyaosOmlqouKNF7G2F042CPNxq/I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hvKITIZ2HtTAf33G6Aywq8eSg26YtAKfxNR/jBcckruO/9W1FP8s1qpGbnhKjgjDL\n\tlXD2RpMYE1KfPhEhiCX+bUkcIl7MLOyJvvRNpFvdvBAZAzpPHKFE8pxfFSKppVxH4b\n\tffqbqEbyKa196oOwiNPJOeGFreM1HbmFdA/Rf2fs=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 27 Nov 2018 03:24:16 +0200","Message-ID":"<6363238.9eg0yNof58@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20181126140111.13255-2-kieran.bingham@ideasonboard.com>","References":"<20181126140111.13255-1-kieran.bingham@ideasonboard.com>\n\t<20181126140111.13255-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH 1/2] lib: Include library in the\n\tinstall target","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 27 Nov 2018 01:23:53 -0000"}}]