[{"id":21562,"web_url":"https://patchwork.libcamera.org/comment/21562/","msgid":"","date":"2021-12-03T02:34:15","subject":"Re: [libcamera-devel] [PATCH v1 3/6] ipa: rkisp1: Introduce Black\n\tLevel Correction","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Thu, Dec 02, 2021 at 07:04:07PM +0100, Jean-Michel Hautbois wrote:\n> In order to have the proper pixel levels, apply a fixed black level\n> correction, based on the imx219 tuning file in RPi. The value is 4096 on\n> 16 bits, and the pipeline for RkISP1 is on 12 bits, scale it.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/rkisp1/algorithms/blc.cpp | 55 +++++++++++++++++++++++++++\n> src/ipa/rkisp1/algorithms/blc.h | 30 +++++++++++++++\n> src/ipa/rkisp1/algorithms/meson.build | 1 +\n> src/ipa/rkisp1/rkisp1.cpp | 2 +\n> 4 files changed, 88 insertions(+)\n> create mode 100644 src/ipa/rkisp1/algorithms/blc.cpp\n> create mode 100644 src/ipa/rkisp1/algorithms/blc.h\n> \n> diff --git a/src/ipa/rkisp1/algorithms/blc.cpp b/src/ipa/rkisp1/algorithms/blc.cpp\n> new file mode 100644\n> index 000000000..f27a8e439\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/algorithms/blc.cpp\n> @@ -0,0 +1,55 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021, Ideas On Board\n> + *\n> + * blc.cpp - RkISP1 Black Level Correction control\n> + */\n> +\n> +#include \"blc.h\"\n> +\n> +/**\n> + * \\file blc.h\n> + */\n> +\n> +namespace libcamera {\n> +\n> +namespace ipa::rkisp1::algorithms {\n> +\n> +/**\n> + * \\class BlackLevelCorrection\n> + * \\brief RkISP1 Black Level Correction control\n> + *\n> + * The pixels output by the camera normally include a black level, because\n> + * sensors do not always report a signal level of '0' for black. Pixels at or\n> + * below this level should be considered black. To achieve that, the RkISP BLC\n> + * algorithm subtracts a configurable offset from all pixels.\n> + *\n> + * The black level can be measured at runtime from an optical dark region of the\n> + * camera sensor, or measured during the camera tuning process. The first option\n> + * isn't currently supported.\n> + */\n> +\n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::prepare\n> + */\n> +void BlackLevelCorrection::prepare([[maybe_unused]] IPAContext &context,\n> +\t\t\t\t rkisp1_params_cfg *params)\n> +{\n> +\t/*\n> +\t * Substract fixed values taken from imx219 tuning file.\n> +\t * \\todo Use a configuration file for it ?\n> +\t */\n> +\tparams->others.bls_config.enable_auto = 0;\n> +\tparams->others.bls_config.fixed_val.r = 256;\n> +\tparams->others.bls_config.fixed_val.gr = 256;\n> +\tparams->others.bls_config.fixed_val.gb = 256;\n> +\tparams->others.bls_config.fixed_val.b = 256;\n> +\n> +\tparams->module_en_update |= RKISP1_CIF_ISP_MODULE_BLS;\n> +\tparams->module_ens |= RKISP1_CIF_ISP_MODULE_BLS;\n> +\tparams->module_cfg_update |= RKISP1_CIF_ISP_MODULE_BLS;\n\nSame as previously, if the values are fixed, we shouldn't change them\nfor every frame.\n\nApart from that, this looks good.\n\n> +}\n> +\n> +} /* namespace ipa::rkisp1::algorithms */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/rkisp1/algorithms/blc.h b/src/ipa/rkisp1/algorithms/blc.h\n> new file mode 100644\n> index 000000000..331a22097\n> --- /dev/null\n> +++ b/src/ipa/rkisp1/algorithms/blc.h\n> @@ -0,0 +1,30 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2021, Ideas On Board\n> + *\n> + * blc.h - RkISP1 Black Level Correction control\n> + */\n> +\n> +#pragma once\n> +\n> +#include \n> +\n> +#include \"algorithm.h\"\n> +\n> +namespace libcamera {\n> +\n> +struct IPACameraSensorInfo;\n> +\n> +namespace ipa::rkisp1::algorithms {\n> +\n> +class BlackLevelCorrection : public Algorithm\n> +{\n> +public:\n> +\tBlackLevelCorrection() = default;\n> +\t~BlackLevelCorrection() = default;\n> +\n> +\tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n> +};\n> +\n> +} /* namespace ipa::rkisp1::algorithms */\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/rkisp1/algorithms/meson.build b/src/ipa/rkisp1/algorithms/meson.build\n> index 0678518d8..e6767aa5f 100644\n> --- a/src/ipa/rkisp1/algorithms/meson.build\n> +++ b/src/ipa/rkisp1/algorithms/meson.build\n> @@ -2,5 +2,6 @@\n> \n> rkisp1_ipa_algorithms = files([\n> 'agc.cpp',\n> + 'blc.cpp',\n> 'sdg.cpp',\n> ])\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index cd425a2e1..ec879ba37 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -27,6 +27,7 @@\n> \n> #include \"algorithms/agc.h\"\n> #include \"algorithms/algorithm.h\"\n> +#include \"algorithms/blc.h\"\n> #include \"algorithms/sdg.h\"\n> #include \"libipa/camera_sensor_helper.h\"\n> \n> @@ -126,6 +127,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision)\n> \n> \t/* Construct our Algorithms */\n> \talgorithms_.push_back(std::make_unique());\n> +\talgorithms_.push_back(std::make_unique());\n> \talgorithms_.push_back(std::make_unique());\n> \n> \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EA03BF415\n\tfor ;\n\tFri, 3 Dec 2021 02:34:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEE2360592;\n\tFri, 3 Dec 2021 03:34:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FC5E60118\n\tfor ;\n\tFri, 3 Dec 2021 03:34:42 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 784C6A59;\n\tFri, 3 Dec 2021 03:34:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L+/epDgf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638498881;\n\tbh=pTS8+xdYCo0xRU5MwcfWrPZFTFBf0YWajJ7z2pFmS2o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=L+/epDgfk5I9BGQAS3XI9AQ7jIg3GYGT50KM46skM4ts/ZgCNM/GTq5Aar/RhwmGf\n\tOk9I5iKi2LLcBOfNapUGqS0P3dYssJFX8Kx9UJ6WgepB+bPsqs8CFbobA0g6PEDDgY\n\ts1MTeQ6v/SCxUBbeCZW+86Urd47NRcq3Hu7ujLvQ=","Date":"Fri, 3 Dec 2021 04:34:15 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211202180410.518232-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211202180410.518232-4-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211202180410.518232-4-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 3/6] ipa: rkisp1: Introduce Black\n\tLevel Correction","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]