{"id":1499,"url":"https://patchwork.libcamera.org/api/patches/1499/?format=json","web_url":"https://patchwork.libcamera.org/patch/1499/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190621161401.28337-7-kieran.bingham@ideasonboard.com>","date":"2019-06-21T16:13:58","name":"[libcamera-devel,RFC,v2,6/9] libcamera: request: Add a ControlList","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"afe3504fa5d1a3584fc179b4ff047ddf3eea5df8","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1499/mbox/","series":[{"id":370,"url":"https://patchwork.libcamera.org/api/series/370/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=370","date":"2019-06-21T16:13:52","name":"Libcamera Controls","version":2,"mbox":"https://patchwork.libcamera.org/series/370/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1499/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1499/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14664615AB\n\tfor ;\n\tFri, 21 Jun 2019 18:14:08 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B236E67;\n\tFri, 21 Jun 2019 18:14:07 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1561133647;\n\tbh=sMIEUyHP6455q7DFJ3S2G5zFuwEuRoYuAPlgKSKbygg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Pdw1pv7FU8LYmakRJzxf+J6oC/qdNJ92LbOQmyjv4VQjLfKvqHPaW+wxUyPqn3W2D\n\tTf9zkIAFjG/In7xSBlqhtMc5Sp5N3IS+LcHvQPOYg5AC4jIccnhfiXatrswnkaaOQ0\n\tDz0GPNdG3i9K3+BI1q5JH424uefqwV+fdWoFs5kI=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Fri, 21 Jun 2019 17:13:58 +0100","Message-Id":"<20190621161401.28337-7-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190621161401.28337-1-kieran.bingham@ideasonboard.com>","References":"<20190621161401.28337-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v2 6/9] libcamera: request: Add a\n\tControlList","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 21 Jun 2019 16:14:08 -0000"},"content":"Provide a ControlList on request objects to facilitate setting controls\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/request.h | 3 +++\n src/libcamera/request.cpp | 10 ++++++++++\n 2 files changed, 13 insertions(+)","diff":"diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 58de6f00a554..8075270a9a12 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -11,6 +11,7 @@\n #include \n \n #include \n+#include \n \n namespace libcamera {\n \n@@ -32,6 +33,7 @@ public:\n \tRequest(const Request &) = delete;\n \tRequest &operator=(const Request &) = delete;\n \n+\tControlList &controls() { return controls_; }\n \tconst std::map &buffers() const { return bufferMap_; }\n \tint setBuffers(const std::map &streamMap);\n \tBuffer *findBuffer(Stream *stream) const;\n@@ -50,6 +52,7 @@ private:\n \tbool completeBuffer(Buffer *buffer);\n \n \tCamera *camera_;\n+\tControlList controls_;\n \tstd::map bufferMap_;\n \tstd::unordered_set pending_;\n \ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex fa3ee46da440..9a0409b46017 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -52,6 +52,16 @@ Request::Request(Camera *camera)\n {\n }\n \n+/**\n+ * \\fn Request::controls()\n+ * \\brief Retrieve the request's ControlList\n+ *\n+ * Return a reference to the ControlList that stores all the controls relevant\n+ * to this request.\n+ *\n+ * \\return A reference to the ControlList in this request\n+ */\n+\n /**\n * \\fn Request::buffers()\n * \\brief Retrieve the request's streams to buffers map\n","prefixes":["libcamera-devel","RFC","v2","6/9"]}