[{"id":21552,"web_url":"https://patchwork.libcamera.org/comment/21552/","msgid":"<051fa8b2-e870-c44b-944d-e82ea6306c4c@ideasonboard.com>","date":"2021-12-02T17:00:13","subject":"Re: [libcamera-devel] [PATCH v7 1/5] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Han-Lin\n\nOn 12/2/21 7:33 PM, Han-Lin Chen wrote:\n> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor\n> V4L2 controls. The patch extend one more field for lens V4L2 controls\n> for auto focus usage.\n>\n> Signed-off-by: Han-Lin Chen \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 16e3462e..cc0d822f 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -24,12 +24,14 @@ struct IPU3Event {\n> \tuint32 bufferId;\n> \tlibcamera.ControlList controls;\n> \tlibcamera.ControlList sensorControls;\n> +\tlibcamera.ControlList lensControls;\n> };\n> \n> struct IPU3Action {\n> \tIPU3Operations op;\n> \tlibcamera.ControlList controls;\n> \tlibcamera.ControlList sensorControls;\n> +\tlibcamera.ControlList lensControls;\n> };\n> \n> struct IPAConfigInfo {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE263BF415\n\tfor ;\n\tThu, 2 Dec 2021 17:00:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAD636082A;\n\tThu, 2 Dec 2021 18:00:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD1D06011A\n\tfor ;\n\tThu, 2 Dec 2021 18:00:19 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B04642A5;\n\tThu, 2 Dec 2021 18:00:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q3yDFu2h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638464419;\n\tbh=aUUpB3leHVtgpEdkK5AO5JijWWKr3vPHklLY91P7XBk=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=q3yDFu2hlN+T/BZkkoeOGmpLE1mlMGReCsNpctJueJ2FBxQQ23ra+tZRgEtMh7SVp\n\twlAQMQvq+CslbPuWY5d3AjXXpJ57rVAlTqTrqRBTI642eC02We2QBhlgB4fk2R/ZFX\n\tCow8NGk4gVoUWB/dRdxVVpJVjX1fw3RYDznVguNM=","To":"Han-Lin Chen ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211202140317.3118364-1-hanlinchen@chromium.org>\n\t<20211202140317.3118364-2-hanlinchen@chromium.org>","From":"Umang Jain ","Message-ID":"<051fa8b2-e870-c44b-944d-e82ea6306c4c@ideasonboard.com>","Date":"Thu, 2 Dec 2021 22:30:13 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211202140317.3118364-2-hanlinchen@chromium.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v7 1/5] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]