[{"id":21543,"web_url":"https://patchwork.libcamera.org/comment/21543/","msgid":"","date":"2021-12-01T22:49:32","subject":"Re: [libcamera-devel] [PATCH v2] backtrace: Include cxxabi.h\n\twithout HAVE_DW","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Khem,\n\nThank you for the patch.\n\nOn Wed, Dec 01, 2021 at 12:15:48PM -0800, Khem Raj wrote:\n> Since its used in code without HAVE_DW, it fails to compile on such\n\ns/its/it's/\n\n> systems e.g. linux/musl\n> \n> Fixes\n> src/libcamera/base/backtrace.cpp:235:16: error: use of undeclared identifier 'abi'\n> char *name = abi::__cxa_demangle(symbol, nullptr, nullptr, nullptr);\n> ^\n> 1 error generated.\n> \n> Signed-off-by: Khem Raj \n> ---\n> v2: Fix typo in subject\n> \n> src/libcamera/base/backtrace.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/base/backtrace.cpp b/src/libcamera/base/backtrace.cpp\n> index d93e5518..42c60f7c 100644\n> --- a/src/libcamera/base/backtrace.cpp\n> +++ b/src/libcamera/base/backtrace.cpp\n> @@ -13,11 +13,12 @@\n> #endif\n> \n> #ifdef HAVE_DW\n> -#include \n> #include \n> #include \n> #endif\n> \n> +#include \n> +\n\nLet's move it a bit further down, after the HAVE_UNWIND block, just\nbefore #include . I can do this when merging the patch.\n\nReviewed-by: Laurent Pinchart \n\n> #if HAVE_UNWIND\n> /*\n> * Disable support for remote unwinding to enable a more optimized","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A39FBF415\n\tfor ;\n\tWed, 1 Dec 2021 22:50:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C84D560828;\n\tWed, 1 Dec 2021 23:49:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7356E607DE\n\tfor ;\n\tWed, 1 Dec 2021 23:49:58 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F03EC8AE;\n\tWed, 1 Dec 2021 23:49:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uds/TksF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638398998;\n\tbh=pBeWSxHOaZASh+Kka9ZIOla6dLKXldhib05KL9NbYuU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uds/TksFr3N0yxoi474x40D4tV4SjQ6RPpJEqU8XDT5iBw4x1IVXReORUjPa57qK5\n\twjKdnHyIR8uk1b4zvSUBpVNUvxjxO6auN61hfdHTGYL+WdbB5dJCrBktTp7qLSAXzm\n\t/FqHMSCQfGUwJ00hgia7flOoX1HBBSvBogDJc/Tw=","Date":"Thu, 2 Dec 2021 00:49:32 +0200","From":"Laurent Pinchart ","To":"Khem Raj ","Message-ID":"","References":"<20211201201548.2023225-1-raj.khem@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211201201548.2023225-1-raj.khem@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v2] backtrace: Include cxxabi.h\n\twithout HAVE_DW","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21546,"web_url":"https://patchwork.libcamera.org/comment/21546/","msgid":"<163844811028.3059017.447656295178861051@Monstersaurus>","date":"2021-12-02T12:28:30","subject":"Re: [libcamera-devel] [PATCH v2] backtrace: Include cxxabi.h\n\twithout HAVE_DW","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-12-01 22:49:32)\n> Hi Khem,\n> \n> Thank you for the patch.\n> \n> On Wed, Dec 01, 2021 at 12:15:48PM -0800, Khem Raj wrote:\n> > Since its used in code without HAVE_DW, it fails to compile on such\n> \n> s/its/it's/\n> \n> > systems e.g. linux/musl\n> > \n> > Fixes\n> > src/libcamera/base/backtrace.cpp:235:16: error: use of undeclared identifier 'abi'\n> > char *name = abi::__cxa_demangle(symbol, nullptr, nullptr, nullptr);\n> > ^\n> > 1 error generated.\n> > \n> > Signed-off-by: Khem Raj \n> > ---\n> > v2: Fix typo in subject\n> > \n> > src/libcamera/base/backtrace.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/base/backtrace.cpp b/src/libcamera/base/backtrace.cpp\n> > index d93e5518..42c60f7c 100644\n> > --- a/src/libcamera/base/backtrace.cpp\n> > +++ b/src/libcamera/base/backtrace.cpp\n> > @@ -13,11 +13,12 @@\n> > #endif\n> > \n> > #ifdef HAVE_DW\n> > -#include \n> > #include \n> > #include \n> > #endif\n> > \n> > +#include \n> > +\n> \n> Let's move it a bit further down, after the HAVE_UNWIND block, just\n> before #include . I can do this when merging the patch.\n> \n> Reviewed-by: Laurent Pinchart \n\nFine with me.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> > #if HAVE_UNWIND\n> > /*\n> > * Disable support for remote unwinding to enable a more optimized\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03A0CBF415\n\tfor ;\n\tThu, 2 Dec 2021 12:28:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CCEE6082A;\n\tThu, 2 Dec 2021 13:28:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 054CC6011A\n\tfor ;\n\tThu, 2 Dec 2021 13:28:33 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D6CAD8C;\n\tThu, 2 Dec 2021 13:28:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oMdTabsm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638448112;\n\tbh=Qa5uJajB4Z6vwdUwdj7AXfvZyPAsMCp39D9QY4yxoB8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=oMdTabsmvzCPwSP2jk1KsbMkz3pp4PTn5SVPsR+S7TUVy9nHV2nUQY2/YCo1r04KD\n\tLIfnMdLdkRLvrIstcUucZOMOz+boja8FRbdAKPEZqE29+oLTKJe/0apbBYp6tPB2NK\n\t+eVEdUioOGIu/8794ci7R26ir/Mx1lEX0m1khVEk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211201201548.2023225-1-raj.khem@gmail.com>\n\t","From":"Kieran Bingham ","To":"Khem Raj ,\n\tLaurent Pinchart ","Date":"Thu, 02 Dec 2021 12:28:30 +0000","Message-ID":"<163844811028.3059017.447656295178861051@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2] backtrace: Include cxxabi.h\n\twithout HAVE_DW","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]